Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
C
chat_webview
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abookCommunication
  • chat_webview
  • Merge Requests
  • !11

Merged
Opened Apr 01, 2021 by Lee Daehyun@lee-dh 3 of 3 tasks completed3/3 tasks
  • Report abuse
Report abuse

ネームカードグループスクロールデザイン修正

Reviewer

LGTMの場合、チェックをしてください。

  • @kim-p
  • @lee-mk
  • @miura-t
Edited Apr 01, 2021 by Takatoshi Miura
  • Discussion 4
  • Commits 4
  • Changes 3
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Lee Daehyun @lee-dh

    added 1 commit

    • 0935fdd5 - ユーザーネームカードデザイン修正

    Compare with previous version

    Apr 01, 2021

    added 1 commit

    • 0935fdd5 - ユーザーネームカードデザイン修正

    Compare with previous version

    added 1 commit * 0935fdd5 - ユーザーネームカードデザイン修正 [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/11/diffs?diff_id=5625&start_sha=c1333bb6bf2559a92057bdccf829d2f84495fe8f)
    Toggle commit list
  • Lee Daehyun @lee-dh

    assigned to @lee-mk

    Apr 01, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Apr 01, 2021
    Resolved by Lee Daehyun Apr 01, 2021
    public_new/template/template_user_name_card.html
    10 10 <span aria-hidden="true">&times;</span>
    11 11 </button>
    12 12 </div>
    13 <div class="modal-body">
    14 {{#groupPathList}}
    15 <li onclick="CHAT_UI.refreshAllGroupSearch({{groupId}});"><b>{{groupPath}}</b></li>
    16 {{/groupPathList}}
    13 <div class="modal-body" id="userNameCard-scroll">
    14 {{#groupPathList}}
    • Kim Peace @kim-p commented Apr 01, 2021
      Master

      [nits] この画面でのインデントはスペース2個を使っているので、それに合わせていただけますか。

      Edited Apr 01, 2021
      [nits] この画面でのインデントは`スペース2個`を使っているので、それに合わせていただけますか。
    • Lee Daehyun @lee-dh

      changed this line in version 3 of the diff

      Apr 01, 2021

      changed this line in version 3 of the diff

      changed this line in [version 3 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/11/diffs?diff_id=5643&start_sha=0935fdd59466070cd1f55c110cb70dc762b0e414#ddead13c4f4362c9ee07b57a4e389592cef6c70b_14_14)
      Toggle commit list
    • Lee Daehyun @lee-dh commented Apr 01, 2021
      Developer

      修正しました。

      Edited Apr 01, 2021
      修正しました。
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Apr 01, 2021
    Resolved by Lee Daehyun Apr 01, 2021
    public_new/css/common.css
    119 119 height: 60px;
    120 120 border-radius: 50%;
    121 121 }
    122 .profile_modal #userNameCard-scroll {
    123 height: 200px;
    124 overflow:auto;
    • Kim Peace @kim-p commented Apr 01, 2021
      Master

      [nits] 上の行と下の行では:の後にスペースを空けているので、こちらも同じく:の後、スペースを空けてください。

      Edited Apr 01, 2021
      [nits] 上の行と下の行では`:`の後にスペースを空けているので、こちらも同じく`:`の後、スペースを空けてください。
    • Lee Daehyun @lee-dh

      changed this line in version 3 of the diff

      Apr 01, 2021

      changed this line in version 3 of the diff

      changed this line in [version 3 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/11/diffs?diff_id=5643&start_sha=0935fdd59466070cd1f55c110cb70dc762b0e414#ed03458772a8a5f16d0b329749eca6d521239c31_124_124)
      Toggle commit list
    • Lee Daehyun @lee-dh commented Apr 01, 2021
      Developer

      修正しました。

      Edited Apr 01, 2021
      修正しました。
    Please register or sign in to reply
  • Lee Daehyun @lee-dh

    added 1 commit

    • 716b0d7b - インデント修正

    Compare with previous version

    Apr 01, 2021

    added 1 commit

    • 716b0d7b - インデント修正

    Compare with previous version

    added 1 commit * 716b0d7b - インデント修正 [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/11/diffs?diff_id=5643&start_sha=0935fdd59466070cd1f55c110cb70dc762b0e414)
    Toggle commit list
  • Lee Daehyun @lee-dh

    added 1 commit

    • 5c16f5ea - インデント修正

    Compare with previous version

    Apr 01, 2021

    added 1 commit

    • 5c16f5ea - インデント修正

    Compare with previous version

    added 1 commit * 5c16f5ea - インデント修正 [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/11/diffs?diff_id=5644&start_sha=716b0d7b0c3573fa144b00e8c5ff2100f34c126c)
    Toggle commit list
  • Lee Daehyun @lee-dh

    resolved all discussions

    Apr 01, 2021

    resolved all discussions

    resolved all discussions
    Toggle commit list
  • Kim Peace @kim-p

    marked the task @kim-p as completed

    Apr 01, 2021

    marked the task @kim-p as completed

    marked the task **@kim-p** as completed
    Toggle commit list
  • Lee Munkyeong @lee-mk

    marked the task @lee-mk as completed

    Apr 01, 2021

    marked the task @lee-mk as completed

    marked the task **@lee-mk** as completed
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @lee-dh

    Apr 01, 2021

    assigned to @lee-dh

    assigned to @lee-dh
    Toggle commit list
  • Lee Daehyun @lee-dh

    assigned to @miura-t

    Apr 01, 2021

    assigned to @miura-t

    assigned to @miura-t
    Toggle commit list
  • Takatoshi Miura @miura-t

    marked the task @miura-t as completed

    Apr 01, 2021

    marked the task @miura-t as completed

    marked the task **@miura-t** as completed
    Toggle commit list
  • Takatoshi Miura @miura-t

    assigned to @lee-dh

    Apr 01, 2021

    assigned to @lee-dh

    assigned to @lee-dh
    Toggle commit list
  • Lee Daehyun @lee-dh

    merged

    Apr 01, 2021

    merged

    merged
    Toggle commit list
  • Lee Daehyun @lee-dh

    mentioned in commit 45f74721

    Apr 01, 2021

    mentioned in commit 45f74721

    mentioned in commit 45f747217526f38511ea7092429f6ba287d1b317
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Lee Daehyun
Assignee
Lee Daehyun @lee-dh
Assign to
None
Milestone
None
Assign milestone
Time tracking
4
4 participants
Reference: abookCommunication/chat_webview!11
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.