Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
C
chat_webview
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abookCommunication
  • chat_webview
  • Merge Requests
  • !110

Merged
Opened May 07, 2021 by Kang Donghun@kang-dh 3 of 3 tasks completed3/3 tasks
  • Report abuse
Report abuse

協業内ユーザー招待機能追加実装

Reviewer

LGTMの場合、チェックをしてください。

  • @kim-p
  • @lee-mk
  • @miura-t
Edited May 11, 2021 by Kim Peace
  • Discussion 2
  • Commits 4
  • Changes 5
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Lee Munkyeong @lee-mk

    marked the task @lee-mk as completed

    May 10, 2021

    marked the task @lee-mk as completed

    marked the task **@lee-mk** as completed
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @kang-dh

    May 10, 2021

    assigned to @kang-dh

    assigned to @kang-dh
    Toggle commit list
  • Kang Donghun @kang-dh

    added 3 commits

    • 3642add4...124722a1 - 2 commits from branch release_sp3
    • 0c51f3b9 - Merge branch 'release_sp3' into release_sp3_add_user

    Compare with previous version

    May 10, 2021

    added 3 commits

    • 3642add4...124722a1 - 2 commits from branch release_sp3
    • 0c51f3b9 - Merge branch 'release_sp3' into release_sp3_add_user

    Compare with previous version

    added 3 commits * 3642add4...124722a1 - 2 commits from branch `release_sp3` * 0c51f3b9 - Merge branch 'release_sp3' into release_sp3_add_user [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/110/diffs?diff_id=6174&start_sha=3642add46c9a685822cb80547c7ce929c42ed4a4)
    Toggle commit list
  • Kang Donghun @kang-dh

    added 1 commit

    • 515433b6 - ルームタイプによって協業中にユーザー招待ボタンを非表示にするように修正

    Compare with previous version

    May 10, 2021

    added 1 commit

    • 515433b6 - ルームタイプによって協業中にユーザー招待ボタンを非表示にするように修正

    Compare with previous version

    added 1 commit * 515433b6 - ルームタイプによって協業中にユーザー招待ボタンを非表示にするように修正 [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/110/diffs?diff_id=6177&start_sha=0c51f3b90a186449d9f1480bacc4e1cca1fc5221)
    Toggle commit list
  • Kang Donghun @kang-dh

    assigned to @kim-p

    May 10, 2021

    assigned to @kim-p

    assigned to @kim-p
    Toggle commit list
  • Kang Donghun @kang-dh

    changed the description

    May 10, 2021

    changed the description

    changed the description
    Toggle commit list
  • Kang Donghun @kang-dh

    assigned to @miura-t

    May 10, 2021

    assigned to @miura-t

    assigned to @miura-t
    Toggle commit list
  • Takatoshi Miura @miura-t

    marked the task @miura-t as completed

    May 10, 2021

    marked the task @miura-t as completed

    marked the task **@miura-t** as completed
    Toggle commit list
  • Takatoshi Miura @miura-t

    assigned to @kim-p

    May 10, 2021

    assigned to @kim-p

    assigned to @kim-p
    Toggle commit list
  • Kim Peace
    @kim-p started a discussion on the diff May 11, 2021
    Resolved by Kang Donghun May 11, 2021
    public_new/collaboration_video.html
    52 53
    53 54 <!-- ユーザー追加オーバーレイ -->
    54 55 <div id="add_user_list"></div>
    56 <div id="modal_add_user_confirm" ></div>
    • Kim Peace @kim-p commented May 11, 2021
      Master

      [nits] "modal_add_user_confirm" >間のスペースを消してください。

      [nits] `"modal_add_user_confirm" >`間のスペースを消してください。
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff May 11, 2021
    Resolved by Kang Donghun May 11, 2021
    public_new/collaboration_voice.html
    52 52 <!-- プロフィールモーダル -->
    53 53 <div id="userProfileModalInCollaboration"></div>
    54 54 <div id="modal_collabo_profile2"></div>
    55 <!-- ユーザー追加オーバーレイ -->
    55 56 <div id="add_user_list" ></div>
    56 57 <div id="modal_add_user_confirm" ></div>
    57 <!-- ホスト変更モーダル -->
    58 <!-- ホスト変更モーダル -->
    • Kim Peace @kim-p commented May 11, 2021
      Master

      [nits] indent?

      [nits] indent?
    • Kang Donghun @kang-dh

      changed this line in version 4 of the diff

      May 11, 2021

      changed this line in version 4 of the diff

      changed this line in [version 4 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/110/diffs?diff_id=6182&start_sha=515433b61a96f4847d18417b806b717b819961da#f14653721915919d0fac42813a23de06d2a081e1_58_57)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace @kim-p

    marked the task @kim-p as completed

    May 11, 2021

    marked the task @kim-p as completed

    marked the task **@kim-p** as completed
    Toggle commit list
  • Kim Peace @kim-p

    assigned to @kang-dh

    May 11, 2021

    assigned to @kang-dh

    assigned to @kang-dh
    Toggle commit list
  • Kang Donghun @kang-dh

    added 1 commit

    • a1e48b6f - レビューされた部分のコード修正

    Compare with previous version

    May 11, 2021

    added 1 commit

    • a1e48b6f - レビューされた部分のコード修正

    Compare with previous version

    added 1 commit * a1e48b6f - レビューされた部分のコード修正 [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/110/diffs?diff_id=6182&start_sha=515433b61a96f4847d18417b806b717b819961da)
    Toggle commit list
  • Kang Donghun @kang-dh

    merged

    May 11, 2021

    merged

    merged
    Toggle commit list
  • Kang Donghun @kang-dh

    mentioned in commit cd102226

    May 11, 2021

    mentioned in commit cd102226

    mentioned in commit cd10222617bc2f21926ce36da66b2961d09b25d9
    Toggle commit list
  • Kang Donghun @kang-dh

    resolved all discussions

    May 11, 2021

    resolved all discussions

    resolved all discussions
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Kang Donghun
Assignee
Kang Donghun @kang-dh
Assign to
None
Milestone
None
Assign milestone
Time tracking
4
4 participants
Reference: abookCommunication/chat_webview!110
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.