Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
C
chat_webview
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abookCommunication
  • chat_webview
  • Merge Requests
  • !14

Closed
Opened Apr 02, 2021 by Lee Daehyun@lee-dh 1 of 3 tasks completed1/3 tasks
  • Report abuse
Report abuse

Bug fix/#433group screen corporate top button

Reviewer

LGTMの場合、チェックをしてください。

  • @kim-p
  • @lee-mk
  • @miura-t
Edited Apr 02, 2021 by Lee Munkyeong
  • Discussion 11
  • Commits 39
  • Changes 37
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Lee Daehyun @lee-dh

    added 1 commit

    • cade5986 - インデント修正

    Compare with previous version

    Apr 02, 2021

    added 1 commit

    • cade5986 - インデント修正

    Compare with previous version

    added 1 commit * cade5986 - インデント修正 [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/14/diffs?diff_id=5666&start_sha=03210a55f025ef22aed25c5b361c131057f2c189)
    Toggle commit list
  • Lee Daehyun @lee-dh

    assigned to @lee-mk

    Apr 02, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Munkyeong @lee-mk

    marked the task @lee-mk as completed

    Apr 02, 2021

    marked the task @lee-mk as completed

    marked the task **@lee-mk** as completed
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @lee-dh

    Apr 02, 2021

    assigned to @lee-dh

    assigned to @lee-dh
    Toggle commit list
  • Kim Peace
    @kim-p started a discussion on the diff Apr 02, 2021
    public/css/chat.css
    760 762 text-align: center;
    761 763 }
    762 764
    765 <<<<<<< HEAD
    • Kim Peace @kim-p commented Apr 02, 2021
      Master

      [must] conflict resolvingの残りだと思うのですが、削除をお願いします。

      [must] conflict resolvingの残りだと思うのですが、削除をお願いします。
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on the diff Apr 02, 2021
    public/css/chat.css
    888 928 text-align: center;
    889 929 overflow: hidden;
    890 930 }
    931 <<<<<<< HEAD
    932 =======
    933 >>>>>>> origin/develop_apply_design_chat
    934 >>>>>>> origin/develop_createRoom_UI
    • Kim Peace @kim-p commented Apr 02, 2021
      Master

      [must] conflict resolvingの残りだと思うのですが、削除をお願いします。

      [must] conflict resolvingの残りだと思うのですが、削除をお願いします。
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on the diff Apr 02, 2021
    public/index.html
    250 <div id="allGroupArea">
    251 <label class="contact-seperator" id="groupPathSeperator">GROUP PATH</label>
    252 <div id="groupPathArea" style="float:left;">
    253 </div>
    254 <label class="contact-seperator" id="moveBtnSeperator">MOVE BUTTON</label>
    255 <div id="groupBtnArea">
    256 <div class="user_list col-12" id="rootGroupBtn">
    257 <div class="user_people">
    258 <div class="user_ib">
    259 <h5>MOVE TO ROOT GROUP</h5>
    260 </div>
    261 </div>
    262 </div>
    263 <div class="user_list col-12" id="parentGroupBtn">
    264 <div class="user_people">
    265 <div class="user_ib">
    • Kim Peace @kim-p commented Apr 02, 2021
      Master

      [ask] user_ib? or id?

      [ask] user_ib? or id?
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on the diff Apr 02, 2021
    public/index.html
    398 433 </div>
    399 434 </nav>
    400 435 <script id="my-namecard-template" type="text/template">
    401 <div style="float: right;"><i class="fa fa-times my-name-card-close" aria-hidden="true"></i></div>
    436 <div style="float: right;"><i class="fa fa-times my-name-card-close" aria-hidden="true" onclick="CHAT_UI.hideNamecard('myNamecard');"></i></div>
    • Kim Peace @kim-p commented Apr 02, 2021
      Master

      [ask] myNamecardを使っているのか確認を願いします。

      [ask] `myNamecard`を使っているのか確認を願いします。
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on the diff Apr 02, 2021
    public/js/chat-db.js
    14 14
    15 15 //ロカールDBからログインしたユーザのデータを取得する。
    16 16 CHAT_DB.getMyInfo = function(input) {
    17 var result = JSON.parse(android.getMyInfo());
    18 CHAT.globalLoginParameter.shopMemberId = result.shopMemberId;
    • Kim Peace @kim-p commented Apr 02, 2021
      Master

      [nits] =の後ろにスペースが2つ入っています。

      [nits] `=`の後ろにスペースが2つ入っています。
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on the diff Apr 02, 2021
    public/js/chat-db.js
    58 61 }
    59 62 };
    60 63
    64 <<<<<<< HEAD
    65 =======
    • Kim Peace @kim-p commented Apr 02, 2021
      Master

      [must] conflict resolvingの残りだと思うのですが、削除をお願いします。

      [must] conflict resolvingの残りだと思うのですが、削除をお願いします。
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on the diff Apr 02, 2021
    public/js/chat-db.js
    68 //TODO IOS処理追加必要
    69 } else if (CHAT_UTIL.isAndroid()) {
    70 //String形式をJsonに変更してReturn
    71 return JSON.parse(android.getGroupInfo(groupId));
    72 }
    73 };
    74
    75 CHAT_DB.getNameCardData = function(shopMemberId) {
    76 if (CHAT_UTIL.isIOS()) {
    77 //TODO IOS処理追加必要
    78 } else if (CHAT_UTIL.isAndroid()) {
    79 //String形式をJsonに変更してReturn
    80 return JSON.parse(android.getNameCardData(shopMemberId));
    81 }
    82 };
    83 >>>>>>> origin/develop_createRoom_UI
    • Kim Peace @kim-p commented Apr 02, 2021
      Master

      [must] conflict resolvingの残りだと思うのですが、削除をお願いします。

      [must] conflict resolvingの残りだと思うのですが、削除をお願いします。
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on the diff Apr 02, 2021
    public/js/chat-db.js
    123 146 //TODO Android処理追加必要
    124 147 }
    125 148 };
    149 <<<<<<< HEAD
    • Kim Peace @kim-p commented Apr 02, 2021
      Master

      [must] conflict resolvingの残りだと思うのですが、削除をお願いします。

      [must] conflict resolvingの残りだと思うのですが、削除をお願いします。
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on the diff Apr 02, 2021
    public/js/chat-ui.js
    906 916 }
    907 917
    908 918 $('#contactButton').on('click', function(event){
    909 CHAT_UI.refreshContactScreen();
    919 let isCreate = false;
    920 let isInvite = false;
    921 CHAT_UI.refreshContactScreen(isCreate, isInvite);
    910 922 });
    911 923
    912 924 $('#chatButton').on('click', function(event){
    913 925 CHAT_UI.refreshRoomList(chatRoomType.DM);
    914 926 });
    915 927
    928 <<<<<<< HEAD
    929 =======
    930 <<<<<<< HEAD
    • Kim Peace @kim-p commented Apr 02, 2021
      Master

      [must] conflict resolvingの残りだと思うのですが、削除をお願いします。

      [must] conflict resolvingの残りだと思うのですが、削除をお願いします。
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on the diff Apr 02, 2021
    public/js/chat-ui.js
    1055 }
    1056 }
    1057 });
    1058
    1059 $('#myGroupBtn').off().on('click', function() {
    1060 let isCreate = true;
    1061 CHAT_UI.refreshContactScreen(isCreate, isInvite);
    1062 });
    1063
    1064 CHAT_UI.dismissLoadingIndicator();
    1065 $('.userCheckBox').show();
    1066 $('#groupButtonArea').show();
    1067 $('#allGroupArea').show();
    1068 $('#myGroupArea').hide();
    1069 }
    1070 >>>>>>> origin/develop_createRoom_UI
    • Kim Peace @kim-p commented Apr 02, 2021
      Master

      [must] conflict resolvingの残りだと思うのですが、削除をお願いします。

      [must] conflict resolvingの残りだと思うのですが、削除をお願いします。
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on the diff Apr 02, 2021
    public/js/chat-ui.js
    1065 $('.userCheckBox').show();
    1066 $('#groupButtonArea').show();
    1067 $('#allGroupArea').show();
    1068 $('#myGroupArea').hide();
    1069 }
    1070 >>>>>>> origin/develop_createRoom_UI
    916 1071 $('#archiveButton').on('click', function(event){
    917 1072 CHAT_UI.refreshArchiveScreen();
    918 1073 });
    919 1074
    1075 <<<<<<< HEAD
    920 1076 CHAT_UI.refreshContactScreen = function() {
    1077 =======
    1078 CHAT_UI.refreshContactScreen = function(isCreate, isInvite) {
    1079
    1080 >>>>>>> origin/develop_createRoom_UI
    • Kim Peace @kim-p commented Apr 02, 2021
      Master

      [must] conflict resolvingの残りだと思うのですが、削除をお願いします。

      [must] conflict resolvingの残りだと思うのですが、削除をお願いします。
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on commit ce69af2e Apr 02, 2021
    • Kim Peace @kim-p

      mentioned in commit a4ea3c56

      Apr 02, 2021

      mentioned in commit a4ea3c56

      mentioned in commit a4ea3c5695b85547a69c0e218f8043d5ae528443
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace @kim-p

    added 9 commits

    • 1beaa6ca - コード整理
    • 5ac1daad - Merge branch 'origin/develop_apply_design_chat' into origin/develop_createRoom_UI
    • 5a808744 - 検索画面でチェックロジック修正
    • 7194ca24 - InviteUser
    • 8548e74d - Merge branch 'origin/develop_apply_design_chat' of…
    • b977262b - add-user
    • 5f1420ea - Merge branch 'origin/develop_apply_design_chat' of…
    • ce69af2e - remove log
    • a4ea3c56 - Merge commit 'ce69af2e' into…

    Compare with previous version

    Apr 02, 2021

    added 9 commits

    • 1beaa6ca - コード整理
    • 5ac1daad - Merge branch 'origin/develop_apply_design_chat' into origin/develop_createRoom_UI
    • 5a808744 - 検索画面でチェックロジック修正
    • 7194ca24 - InviteUser
    • 8548e74d - Merge branch 'origin/develop_apply_design_chat' of…
    • b977262b - add-user
    • 5f1420ea - Merge branch 'origin/develop_apply_design_chat' of…
    • ce69af2e - remove log
    • a4ea3c56 - Merge commit 'ce69af2e' into…

    Compare with previous version

    added 9 commits * 1beaa6ca - コード整理 * 5ac1daad - Merge branch &#x27;origin&#x2F;develop_apply_design_chat&#x27; into origin&#x2F;develop_createRoom_UI * 5a808744 - 検索画面でチェックロジック修正 * 7194ca24 - InviteUser * 8548e74d - Merge branch &#x27;origin&#x2F;develop_apply_design_chat&#x27; of… * b977262b - add-user * 5f1420ea - Merge branch &#x27;origin&#x2F;develop_apply_design_chat&#x27; of… * ce69af2e - remove log * a4ea3c56 - Merge commit &#x27;ce69af2e646df7e41d107cc3eb201f5b217dd865&#x27; into… [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/14/diffs?diff_id=5674&start_sha=cade59867a6bd821709b01d843cd1bb2b7a591cd)
    Toggle commit list
  • Kim Peace @kim-p

    closed

    Apr 02, 2021

    closed

    closed
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Lee Daehyun
Assignee
Lee Daehyun @lee-dh
Assign to
None
Milestone
None
Assign milestone
Time tracking
4
4 participants
Reference: abookCommunication/chat_webview!14