Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
C
chat_webview
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abookCommunication
  • chat_webview
  • Merge Requests
  • !147

Merged
Opened May 27, 2021 by Lee Munkyeong@lee-mk 2 of 2 tasks completed2/2 tasks
  • Report abuse
Report abuse

Feature/develop encode video

  • @kim-p
  • @miura-t
Edited May 27, 2021 by Kim Peace
  • Discussion 3
  • Commits 4
  • Changes 5
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Takatoshi Miura @miura-t

    marked the task @miura-t as completed

    May 27, 2021

    marked the task @miura-t as completed

    marked the task **@miura-t** as completed
    Toggle commit list
  • Takatoshi Miura @miura-t

    assigned to @kim-p

    May 27, 2021

    assigned to @kim-p

    assigned to @kim-p
    Toggle commit list
  • Kim Peace
    @kim-p started a discussion on an old version of the diff May 27, 2021
    Last updated by Lee Munkyeong May 27, 2021
    public_new/js/chat-ui.js
    839 blob.lastModifiedDate = new Date();
    840 blob.name = name;
    841 return blob;
    842 };
    843 var GetFileObjectFromURL = function(filePathOrUrl, convertBlob) {
    844 GetFileBlobUsingURL(filePathOrUrl, function (blob) {
    845 convertBlob(blobToFile(blob, 'testFile.mp4'));
    846 });
    847 };
    848
    849 CHAT_UI.videoEncodeEnd = function(encodedUri) {
    850 console.log('encode end');
    851 console.log('file:'+encodedUri);
    852 var fileName = encodedUri.split('/')[encodedUri.split('/').length-1];
    853 //var testFile = new File(decodeURI('file://'+encodedUri));
    854 var FileURL='file:'+encodedUri;
    • Kim Peace @kim-p commented May 27, 2021
      Master

      [nits] FileURL -> fileURL

      [nits] `FileURL` -> fileURL
    • Lee Munkyeong @lee-mk

      changed this line in version 2 of the diff

      May 27, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/147/diffs?diff_id=6334&start_sha=62fbf72b96531d719d9c8fa35a2a8758ab3ea7a5#cb43321944b8dcb1e2b3b87cea1e1f7c22f3d3cf_854_856)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff May 27, 2021
    Last updated by Lee Munkyeong May 27, 2021
    public_new/js/chat-ui.js
    845 convertBlob(blobToFile(blob, 'testFile.mp4'));
    846 });
    847 };
    848
    849 CHAT_UI.videoEncodeEnd = function(encodedUri) {
    850 console.log('encode end');
    851 console.log('file:'+encodedUri);
    852 var fileName = encodedUri.split('/')[encodedUri.split('/').length-1];
    853 //var testFile = new File(decodeURI('file://'+encodedUri));
    854 var FileURL='file:'+encodedUri;
    855 var xhr = new XMLHttpRequest();
    856 xhr.open("GET", FileURL);
    857 xhr.responseType = "blob";
    858 xhr.addEventListener('load', function() {
    859 console.log(xhr.response);
    860 var formData=new FormData();
    • Kim Peace @kim-p commented May 27, 2021
      Master

      [nits]

      // not preferred
      var formData=new FormData();
      // preferred
      var formData = new FormData();
      [nits] ```js // not preferred var formData=new FormData(); // preferred var formData = new FormData(); ```
    • Lee Munkyeong @lee-mk

      changed this line in version 2 of the diff

      May 27, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/147/diffs?diff_id=6334&start_sha=62fbf72b96531d719d9c8fa35a2a8758ab3ea7a5#cb43321944b8dcb1e2b3b87cea1e1f7c22f3d3cf_860_861)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff May 27, 2021
    Last updated by Lee Munkyeong May 27, 2021
    public_new/js/chat-ui.js
    851 console.log('file:'+encodedUri);
    852 var fileName = encodedUri.split('/')[encodedUri.split('/').length-1];
    853 //var testFile = new File(decodeURI('file://'+encodedUri));
    854 var FileURL='file:'+encodedUri;
    855 var xhr = new XMLHttpRequest();
    856 xhr.open("GET", FileURL);
    857 xhr.responseType = "blob";
    858 xhr.addEventListener('load', function() {
    859 console.log(xhr.response);
    860 var formData=new FormData();
    861 formData.append("image", xhr.response, fileName);
    862 formData.append('sid', CHAT.globalLoginParameter.sid);
    863 formData.append('roomId', CHAT.globalLoginParameter.roomId);
    864 jQuery.ajax({
    865 async: true,
    866 url: CMS_SERVER_URL+"/chatapi/file/upload",
    • Kim Peace @kim-p commented May 27, 2021
      Master

      [nits] space btwn +

      [nits] space btwn `+`
    • Lee Munkyeong @lee-mk

      changed this line in version 2 of the diff

      May 27, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/147/diffs?diff_id=6334&start_sha=62fbf72b96531d719d9c8fa35a2a8758ab3ea7a5#cb43321944b8dcb1e2b3b87cea1e1f7c22f3d3cf_866_867)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace @kim-p

    marked the task @kim-p as completed

    May 27, 2021

    marked the task @kim-p as completed

    marked the task **@kim-p** as completed
    Toggle commit list
  • Kim Peace @kim-p

    assigned to @lee-mk

    May 27, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Munkyeong @lee-mk

    added 1 commit

    • a2f34c2e - コードレビュー対応及び動画エンコード失敗の処理追加。

    Compare with previous version

    May 27, 2021

    added 1 commit

    • a2f34c2e - コードレビュー対応及び動画エンコード失敗の処理追加。

    Compare with previous version

    added 1 commit * a2f34c2e - コードレビュー対応及び動画エンコード失敗の処理追加。 [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/147/diffs?diff_id=6334&start_sha=62fbf72b96531d719d9c8fa35a2a8758ab3ea7a5)
    Toggle commit list
  • Lee Munkyeong @lee-mk

    merged

    May 28, 2021

    merged

    merged
    Toggle commit list
  • Lee Munkyeong @lee-mk

    mentioned in commit 23735ee1

    May 28, 2021

    mentioned in commit 23735ee1

    mentioned in commit 23735ee1c1e487983a376edcc3167fc313dfc50f
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Lee Munkyeong
Assignee
Lee Munkyeong @lee-mk
Assign to
None
Milestone
None
Assign milestone
Time tracking
3
3 participants
Reference: abookCommunication/chat_webview!147
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.