isOnile の判定を文字列からbool値に変更した。 (!197) · Merge Requests · abookCommunication / chat_webview · GitLab

isOnile の判定を文字列からbool値に変更した。

request内容

Reviewer

LGTMの場合、チェックをしてください。

Edited Jul 20, 2021 by Kim Jinsung

{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved

@kim_j started a discussion on commit 0cf492de Jul 20, 2021

Last updated by onuma Jul 20, 2021

66	66	};
67	67
68	68	NativeBridgeDelegate.updateContactInfo = function () {
69		if (serverInfo.isOnline != "true") {
	69	if (serverInfo.isOnline != true) {
		Kim Jinsung @kim_j commented Jul 20, 2021 Master `if (serverInfo.isOnline != true) {` よりは以下で改善したほうが良いかと思います。 `if (serverInfo.isOnline == false) {` `if (serverInfo.isOnline != true) {`<br> よりは以下で改善したほうが良いかと思います。<br> `if (serverInfo.isOnline == false) {` onuma @onuma commented Jul 20, 2021 Developer 修正します。修正します。 Please register or sign in to reply

onuma @onuma
added 1 commit

5604a81d - != true で判定していた箇所を == falseで判定するように修正

Compare with previous version
Jul 20, 2021
added 1 commit

5604a81d - != true で判定していた箇所を == falseで判定するように修正

Compare with previous version
added 1 commit * 5604a81d - != true で判定していた箇所を == falseで判定するように修正 [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/197/diffs?diff_id=6658&start_sha=0cf492de4b1a0273d68f855cfb7775a9426acd8f)

Toggle commit list
onuma @onuma
added 1 commit

bf18ef8c - deviceInfo の isMobile を booleanに変更

Compare with previous version
Jul 20, 2021
added 1 commit

bf18ef8c - deviceInfo の isMobile を booleanに変更

Compare with previous version
added 1 commit * bf18ef8c - deviceInfo の isMobile を booleanに変更 [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/197/diffs?diff_id=6659&start_sha=5604a81ddc369abb81a059f3bec46dd1bdc9cd36)

Toggle commit list
Kim Peace @kim-p
marked the task @kim-p as completed
Jul 20, 2021

marked the task @kim-p as completed

marked the task **@kim-p** as completed

Toggle commit list
Kim Peace @kim-p
assigned to @kim_j
Jul 20, 2021

assigned to @kim_j

assigned to @kim_j

Toggle commit list
Kim Jinsung @kim_j
marked the task @kim_j as completed
Jul 20, 2021

marked the task @kim_j as completed

marked the task **@kim_j** as completed

Toggle commit list
onuma @onuma
merged
Jul 20, 2021

merged

merged

Toggle commit list
onuma @onuma
mentioned in commit c153ba62
Jul 20, 2021

mentioned in commit c153ba62

mentioned in commit c153ba62c62d6bcad7ad557c525553412be1bc25

Toggle commit list

Please register or to comment