Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
C
chat_webview
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abookCommunication
  • chat_webview
  • Merge Requests
  • !20

Merged
Opened Apr 05, 2021 by Lee Daehyun@lee-dh 3 of 3 tasks completed3/3 tasks
  • Report abuse
Report abuse

Bug fix/#436 message picture modal

Reviewer

LGTMの場合、チェックをしてください。

  • @kim-p
  • @lee-mk
  • @kang-dh
Edited Apr 06, 2021 by Kim Peace
  • Discussion 1
  • Commits 3
  • Changes 4
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Lee Daehyun @lee-dh

    assigned to @lee-mk

    Apr 06, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Munkyeong @lee-mk

    marked the task @lee-mk as completed

    Apr 06, 2021

    marked the task @lee-mk as completed

    marked the task **@lee-mk** as completed
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @lee-dh

    Apr 06, 2021

    assigned to @lee-dh

    assigned to @lee-dh
    Toggle commit list
  • Lee Daehyun @lee-dh

    assigned to @kang-dh

    Apr 06, 2021

    assigned to @kang-dh

    assigned to @kang-dh
    Toggle commit list
  • Kang Donghun @kang-dh

    marked the task @kang-dh as completed

    Apr 06, 2021

    marked the task @kang-dh as completed

    marked the task **@kang-dh** as completed
    Toggle commit list
  • Kang Donghun @kang-dh

    assigned to @lee-dh

    Apr 06, 2021

    assigned to @lee-dh

    assigned to @lee-dh
    Toggle commit list
  • Lee Daehyun @lee-dh

    assigned to @kim-p

    Apr 06, 2021

    assigned to @kim-p

    assigned to @kim-p
    Toggle commit list
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Apr 06, 2021
    Resolved by Lee Daehyun Apr 06, 2021
    public_new/js/chat.js
    111 111 }
    112 112 let downloadPath = CMS_SERVER_URL + '/chatapi/file/download?fileName=' + imageName + '&roomId=' + CHAT.globalLoginParameter.roomId;
    113 113 // アップロードが終了した後ローディング画面から離れてメッセージをメッセージを転送する
    114 const lightbox = $('<a/>',{href:imgPath, 'data-lightbox':'attachedImages','data-title':imageName});
    115 const image = $('<img/>',{src:imgPath, width:'auto',style:'max-width:100%'});
    114 const lightbox = $('<a/>',{'data-lightbox':'attachedImages','data-title':imageName});
    115 const image = $('<img/>',{src:imgPath, width:'auto', style:'max-width:100%','data-toggle':'modal', onclick:'test(this);'});
    • Kim Peace @kim-p commented Apr 06, 2021
      Master

      [nits] ,の後にスペースを空けてください。

      Edited Apr 06, 2021
      [nits] `,`の後にスペースを空けてください。
    • Lee Daehyun @lee-dh

      changed this line in version 2 of the diff

      Apr 06, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/20/diffs?diff_id=5717&start_sha=2a06af43adb292c8fe5d3b189a5044aaf5c24659#53b4b38e40d367a2ef7dae2dc126dcc0c1d056c4_115_114)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace @kim-p

    marked the task @kim-p as completed

    Apr 06, 2021

    marked the task @kim-p as completed

    marked the task **@kim-p** as completed
    Toggle commit list
  • Kim Peace @kim-p

    assigned to @lee-dh

    Apr 06, 2021

    assigned to @lee-dh

    assigned to @lee-dh
    Toggle commit list
  • Lee Daehyun @lee-dh

    added 1 commit

    • 66aac1cd - , インデント修正

    Compare with previous version

    Apr 06, 2021

    added 1 commit

    • 66aac1cd - , インデント修正

    Compare with previous version

    added 1 commit * 66aac1cd - , インデント修正 [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/20/diffs?diff_id=5717&start_sha=2a06af43adb292c8fe5d3b189a5044aaf5c24659)
    Toggle commit list
  • Lee Daehyun @lee-dh

    resolved all discussions

    Apr 06, 2021

    resolved all discussions

    resolved all discussions
    Toggle commit list
  • Lee Daehyun @lee-dh

    merged

    Apr 06, 2021

    merged

    merged
    Toggle commit list
  • Lee Daehyun @lee-dh

    mentioned in commit e50b71b5

    Apr 06, 2021

    mentioned in commit e50b71b5

    mentioned in commit e50b71b594bdee44f569bd20e51c8331e5760eac
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Lee Daehyun
Assignee
Lee Daehyun @lee-dh
Assign to
None
Milestone
None
Assign milestone
Time tracking
4
4 participants
Reference: abookCommunication/chat_webview!20
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.