Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
C
chat_webview
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abookCommunication
  • chat_webview
  • Merge Requests
  • !211

Merged
Opened Jul 30, 2021 by onuma@onuma 2 of 2 tasks completed2/2 tasks
  • Report abuse
Report abuse

動画にサムネイルを追加した。

LGTMの場合、チェックをしてください。

  • @kim-p
  • @kim_j
Edited Jul 30, 2021 by Kim Jinsung
  • Discussion 2
  • Commits 3
  • Changes 3
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Jul 30, 2021
    Last updated by onuma Jul 30, 2021
    public_new/js/utils/chat-media-handler.js
    64 64 var fd = new FormData($(this)[0]);
    65 65
    66 66 if (!file.type.includes("image")) {
    67 // video 保存
    • Kim Peace @kim-p commented Jul 30, 2021
      Master

      [nits] 今後、ちゃんとしたthumbnailのために、コメントアウトだけしているところです。 気に入ったら、この内容をソースのコメントに残して、このコードは削除しないようにしていただけますか。

      [nits] 今後、ちゃんとしたthumbnailのために、コメントアウトだけしているところです。 気に入ったら、この内容をソースのコメントに残して、このコードは削除しないようにしていただけますか。
    • onuma @onuma commented Jul 30, 2021
      Developer

      了解しました。

      了解しました。
    • onuma @onuma

      changed this line in version 2 of the diff

      Jul 30, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/211/diffs?diff_id=6774&start_sha=125880a24187d5e7b7ab575063593ea09ef03897#de0d8651c14488b949b19ea0ceb70369276e1cf9_67_67)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace @kim-p

    marked the task @kim-p as completed

    Jul 30, 2021

    marked the task @kim-p as completed

    marked the task **@kim-p** as completed
    Toggle commit list
  • Kim Peace @kim-p

    assigned to @kim_j

    Jul 30, 2021

    assigned to @kim_j

    assigned to @kim_j
    Toggle commit list
  • Kim Jinsung @kim_j

    marked the task @kim_j as completed

    Jul 30, 2021

    marked the task @kim_j as completed

    marked the task **@kim_j** as completed
    Toggle commit list
  • Kim Jinsung @kim_j

    assigned to @onuma

    Jul 30, 2021

    assigned to @onuma

    assigned to @onuma
    Toggle commit list
  • onuma @onuma

    added 1 commit

    • 07a3c9fd - コメントを元に戻しました。

    Compare with previous version

    Jul 30, 2021

    added 1 commit

    • 07a3c9fd - コメントを元に戻しました。

    Compare with previous version

    added 1 commit * 07a3c9fd - コメントを元に戻しました。 [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/211/diffs?diff_id=6774&start_sha=125880a24187d5e7b7ab575063593ea09ef03897)
    Toggle commit list
  • onuma @onuma

    assigned to @kim-p

    Jul 30, 2021

    assigned to @kim-p

    assigned to @kim-p
    Toggle commit list
  • Kim Peace @kim-p

    merged

    Jul 30, 2021

    merged

    merged
    Toggle commit list
  • Kim Peace @kim-p

    mentioned in commit 09ce81e9

    Jul 30, 2021

    mentioned in commit 09ce81e9

    mentioned in commit 09ce81e970a41d122bae263b21e5ecac66e73ef5
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Kim Peace
Assignee
Kim Peace @kim-p
Assign to
None
Milestone
None
Assign milestone
Time tracking
3
3 participants
Reference: abookCommunication/chat_webview!211
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.