Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
C
chat_webview
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abookCommunication
  • chat_webview
  • Merge Requests
  • !22

Merged
Opened Apr 06, 2021 by Lee Daehyun@lee-dh 3 of 3 tasks completed3/3 tasks
  • Report abuse
Report abuse

bugFix/#42192操作改善1

  • @kim-p
  • @miura-t
  • @lee-mk
Edited Apr 08, 2021 by Kim Peace
  • Discussion 5
  • Commits 6
  • Changes 2
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Lee Daehyun @lee-dh

    assigned to @lee-mk

    Apr 06, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Munkyeong @lee-mk

    marked the task @lee-mk as completed

    Apr 06, 2021

    marked the task @lee-mk as completed

    marked the task **@lee-mk** as completed
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @lee-dh

    Apr 06, 2021

    assigned to @lee-dh

    assigned to @lee-dh
    Toggle commit list
  • Lee Daehyun @lee-dh

    added 1 commit

    • 3d741e2c - 元HTML変換

    Compare with previous version

    Apr 06, 2021

    added 1 commit

    • 3d741e2c - 元HTML変換

    Compare with previous version

    added 1 commit * 3d741e2c - 元HTML変換 [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/22/diffs?diff_id=5731&start_sha=2efb8f53aeecfcca794d136d5fe9ee8a291cbbc2)
    Toggle commit list
  • Lee Daehyun @lee-dh

    assigned to @miura-t

    Apr 06, 2021

    assigned to @miura-t

    assigned to @miura-t
    Toggle commit list
  • Takatoshi Miura @miura-t

    marked the task @miura-t as completed

    Apr 06, 2021

    marked the task @miura-t as completed

    marked the task **@miura-t** as completed
    Toggle commit list
  • Takatoshi Miura @miura-t

    assigned to @lee-dh

    Apr 06, 2021

    assigned to @lee-dh

    assigned to @lee-dh
    Toggle commit list
  • Lee Daehyun @lee-dh

    assigned to @kim-p

    Apr 07, 2021

    assigned to @kim-p

    assigned to @kim-p
    Toggle commit list
  • Lee Daehyun @lee-dh

    changed the description

    Apr 07, 2021

    changed the description

    changed the description
    Toggle commit list
  • Lee Daehyun @lee-dh

    changed target branch from origin/develop_apply_design to release_sp3

    Apr 07, 2021

    changed target branch from origin/develop_apply_design to release_sp3

    changed target branch from `origin/develop_apply_design` to `release_sp3`
    Toggle commit list
  • Lee Daehyun @lee-dh

    added 29 commits

    • 3d741e2c...f4dcc293 - 28 commits from branch release_sp3
    • 5b50ed5d - Merge branch 'release_sp3' into 'bugFix/#42192操作改善1'

    Compare with previous version

    Apr 07, 2021

    added 29 commits

    • 3d741e2c...f4dcc293 - 28 commits from branch release_sp3
    • 5b50ed5d - Merge branch 'release_sp3' into 'bugFix/#42192操作改善1'

    Compare with previous version

    added 29 commits * 3d741e2c...f4dcc293 - 28 commits from branch `release_sp3` * 5b50ed5d - Merge branch 'release_sp3' into 'bugFix/#42192操作改善1' [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/22/diffs?diff_id=5737&start_sha=3d741e2c011b32177231a14057ed86526bd1f20f)
    Toggle commit list
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Apr 07, 2021
    Resolved by Lee Daehyun Apr 08, 2021
    public_new/chat_room.html
    159 166 <script src="./js/chat-websocket.js"></script>
    160 167 <script src="./js/chat-room.js"></script>
    161 168 <script>
    169 function test(image) {
    • Kim Peace @kim-p commented Apr 07, 2021
      Master

      [must] test?

      Edited Apr 08, 2021
      [must] test?
    • Lee Daehyun @lee-dh commented Apr 08, 2021
      Developer

      imageModalに変更しました

      Edited Apr 08, 2021
      `imageModal`に変更しました
    • Lee Daehyun @lee-dh

      changed this line in version 6 of the diff

      Apr 08, 2021

      changed this line in version 6 of the diff

      changed this line in [version 6 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/22/diffs?diff_id=5762&start_sha=5b50ed5d9da51c3ecc581f11e476421cdfc55a9f#f0bfa7a9ed0d0c1e3dcf08be05ad16caa636f4c5_169_169)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace @kim-p

    assigned to @lee-dh

    Apr 07, 2021

    assigned to @lee-dh

    assigned to @lee-dh
    Toggle commit list
  • Lee Daehyun @lee-dh

    resolved all discussions

    Apr 08, 2021

    resolved all discussions

    resolved all discussions
    Toggle commit list
  • Lee Daehyun @lee-dh

    added 1 commit

    • 0a563678 - MR修正

    Compare with previous version

    Apr 08, 2021

    added 1 commit

    • 0a563678 - MR修正

    Compare with previous version

    added 1 commit * 0a563678 - MR修正 [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/22/diffs?diff_id=5762&start_sha=5b50ed5d9da51c3ecc581f11e476421cdfc55a9f)
    Toggle commit list
  • Lee Daehyun @lee-dh

    assigned to @kim-p

    Apr 08, 2021

    assigned to @kim-p

    assigned to @kim-p
    Toggle commit list
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Apr 08, 2021
    Resolved by Lee Daehyun Apr 08, 2021
    public_new/chat_room.html
    159 166 <script src="./js/chat-websocket.js"></script>
    160 167 <script src="./js/chat-room.js"></script>
    161 168 <script>
    169 function imageModal(image) {
    170 $('#modal_image').attr('src',image.src);
    • Kim Peace @kim-p commented Apr 08, 2021
      Master

      [nits] space after ,

      Edited Apr 08, 2021
      [nits] space after `,`
    • Lee Daehyun @lee-dh

      changed this line in version 7 of the diff

      Apr 08, 2021

      changed this line in version 7 of the diff

      changed this line in version 7 of the diff
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Apr 08, 2021
    Resolved by Lee Daehyun Apr 08, 2021
    public_new/css/chat.css
    240 240 font: 26px FontAwesome;
    241 241 font-family: "Font Awesome 5 Free";
    242 242 font-weight: 900;
    243 color: #f5d256;
    243 color: #F5D256;
    244 padding: 20px
    244 245 }
    245 246 .star.disable:before {
    246 247 content: "\f005";
    247 248 font: 26px FontAwesome;
    248 249 font-family: "Font Awesome 5 Free";
    249 250 font-weight: 400;
    250 color: #c4c4c4;
    251 color: #C4C4C4;
    252 padding: 20px
    • Kim Peace @kim-p commented Apr 08, 2021
      Master

      [must] add ; after px

      Edited Apr 08, 2021
      [must] add `;` after px
    • Lee Daehyun @lee-dh

      changed this line in version 8 of the diff

      Apr 08, 2021

      changed this line in version 8 of the diff

      changed this line in [version 8 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/22/diffs?diff_id=5775&start_sha=558f93caf7ec75745ffc3d3a6c7325df3341d734#38f51759ac918471c315119579d30bdd66bd6b91_252_252)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Apr 08, 2021
    Resolved by Lee Daehyun Apr 08, 2021
    public_new/css/chat.css
    240 240 font: 26px FontAwesome;
    241 241 font-family: "Font Awesome 5 Free";
    242 242 font-weight: 900;
    243 color: #f5d256;
    243 color: #F5D256;
    244 padding: 20px
    • Kim Peace @kim-p commented Apr 08, 2021
      Master

      [must] add ; after px

      Edited Apr 08, 2021
      [must] add `;` after px
    • Lee Daehyun @lee-dh

      changed this line in version 8 of the diff

      Apr 08, 2021

      changed this line in version 8 of the diff

      changed this line in [version 8 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/22/diffs?diff_id=5775&start_sha=558f93caf7ec75745ffc3d3a6c7325df3341d734#38f51759ac918471c315119579d30bdd66bd6b91_244_244)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace @kim-p

    assigned to @lee-dh

    Apr 08, 2021

    assigned to @lee-dh

    assigned to @lee-dh
    Toggle commit list
  • Lee Daehyun @lee-dh

    added 23 commits

    • 0a563678...42b78026 - 22 commits from branch release_sp3
    • 558f93ca - Merge branch 'release_sp3' into 'bugFix/#42192操作改善1'

    Compare with previous version

    Apr 08, 2021

    added 23 commits

    • 0a563678...42b78026 - 22 commits from branch release_sp3
    • 558f93ca - Merge branch 'release_sp3' into 'bugFix/#42192操作改善1'

    Compare with previous version

    added 23 commits * 0a563678...42b78026 - 22 commits from branch `release_sp3` * 558f93ca - Merge branch &#x27;release_sp3&#x27; into &#x27;bugFix&#x2F;#42192操作改善1&#x27; [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/22/diffs?diff_id=5774&start_sha=0a5636784656a326a01437a4468ce15a09e443f3)
    Toggle commit list
  • Lee Daehyun @lee-dh

    added 1 commit

    • 2a9b485a - インデント修正

    Compare with previous version

    Apr 08, 2021

    added 1 commit

    • 2a9b485a - インデント修正

    Compare with previous version

    added 1 commit * 2a9b485a - インデント修正 [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/22/diffs?diff_id=5775&start_sha=558f93caf7ec75745ffc3d3a6c7325df3341d734)
    Toggle commit list
  • Lee Daehyun @lee-dh

    resolved all discussions

    Apr 08, 2021

    resolved all discussions

    resolved all discussions
    Toggle commit list
  • Lee Daehyun @lee-dh

    assigned to @kim-p

    Apr 08, 2021

    assigned to @kim-p

    assigned to @kim-p
    Toggle commit list
  • Kim Peace @kim-p

    marked the task @kim-p as completed

    Apr 08, 2021

    marked the task @kim-p as completed

    marked the task **@kim-p** as completed
    Toggle commit list
  • Kim Peace @kim-p

    assigned to @lee-dh

    Apr 08, 2021

    assigned to @lee-dh

    assigned to @lee-dh
    Toggle commit list
  • Lee Daehyun @lee-dh

    merged

    Apr 08, 2021

    merged

    merged
    Toggle commit list
  • Lee Daehyun @lee-dh

    mentioned in commit 45c0c6ba

    Apr 08, 2021

    mentioned in commit 45c0c6ba

    mentioned in commit 45c0c6bad4f46971fd7ad52b6324bd10eead21b9
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Lee Daehyun
Assignee
Lee Daehyun @lee-dh
Assign to
None
Milestone
None
Assign milestone
Time tracking
4
4 participants
Reference: abookCommunication/chat_webview!22
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.