Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
C
chat_webview
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abookCommunication
  • chat_webview
  • Merge Requests
  • !3

Merged
Opened Feb 24, 2021 by Lee Munkyeong@lee-mk 5 of 5 tasks completed5/5 tasks
  • Report abuse
Report abuse

Devlop contact ui

  • @jung-k

  • @kim-p

  • @lee-dh

  • @kang-dh

  • @miura-t

Edited Mar 02, 2021 by Jung Kwangkyu
  • Discussion 21
  • Commits 18
  • Changes 12
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Lee Munkyeong @lee-mk

    added 1 commit

    • d214c054 - Favorite

    Compare with previous version

    Feb 24, 2021

    added 1 commit

    • d214c054 - Favorite

    Compare with previous version

    added 1 commit * d214c054 - Favorite [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/3/diffs?diff_id=5249&start_sha=50c56bc6b1c1a1615b710f01be75ed50c78994c4)
    Toggle commit list
  • Lee Munkyeong @lee-mk

    changed the description

    Feb 24, 2021

    changed the description

    changed the description
    Toggle commit list
  • Lee Munkyeong @lee-mk

    added 1 commit

    • 67e11f79 - fix bug

    Compare with previous version

    Feb 24, 2021

    added 1 commit

    • 67e11f79 - fix bug

    Compare with previous version

    added 1 commit * 67e11f79 - fix bug [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/3/diffs?diff_id=5250&start_sha=d214c054135b517d22e38dc31ba68f6197ef7544)
    Toggle commit list
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Feb 24, 2021
    Resolved by Lee Munkyeong Feb 24, 2021
    public/js/chat-websocket.js
    1 1 var socket;
    2 connectSocket(IS_ONLINE);
    3 2
    4 function connectSocket(isOnline) {
    5 if (isOnline == 'true') {
    3 function getGlobalParam(chatServerUrl, cmsServerUrl, platform, isMobile, isOnline) {
    4 CHAT_SERVER_URL = chatServerUrl;
    • Kim Peace @kim-p commented Feb 24, 2021
      Master

      [nits] 4 space indentに合わせて下さい。

      Edited Feb 24, 2021
      [nits] 4 space indentに合わせて下さい。
    • Lee Munkyeong @lee-mk

      changed this line in version 4 of the diff

      Feb 24, 2021

      changed this line in version 4 of the diff

      changed this line in [version 4 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/3/diffs?diff_id=5262&start_sha=67e11f79258e9b15ed09cbdb2709fb6601221d43#545eb949e18804dc3e5b6b017bbed7343a9b232d_4_4)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Feb 24, 2021
    Resolved by Lee Munkyeong Feb 24, 2021
    public/js/chat-websocket.js
    3 function getGlobalParam(chatServerUrl, cmsServerUrl, platform, isMobile, isOnline) {
    4 CHAT_SERVER_URL = chatServerUrl;
    5 CMS_SERVER_URL = cmsServerUrl;
    6 PLATFORM = platform;
    7 IS_MOBILE = isMobile;
    8 IS_ONLINE = isOnline;
    9 connectSocket();
    10 };
    11
    12 android.getGlobalParameter();
    13
    14 function connectSocket() {
    15 CHAT_UI.dismissLoadingIndicator();
    16 if (IS_ONLINE == 'true') {
    6 17 socket = io(CHAT_SERVER_URL);
    18 console.log('insOnline');
    • Kim Peace @kim-p commented Feb 24, 2021
      Master

      [nits] insOnline -> isOnline ?

      Edited Feb 24, 2021
      [nits] `insOnline` -> `isOnline` ?
    • Lee Munkyeong @lee-mk

      changed this line in version 4 of the diff

      Feb 24, 2021

      changed this line in version 4 of the diff

      changed this line in [version 4 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/3/diffs?diff_id=5262&start_sha=67e11f79258e9b15ed09cbdb2709fb6601221d43#545eb949e18804dc3e5b6b017bbed7343a9b232d_18_19)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Feb 24, 2021
    Resolved by Lee Munkyeong Feb 24, 2021
    public/js/chat-websocket.js
    11
    12 android.getGlobalParameter();
    13
    14 function connectSocket() {
    15 CHAT_UI.dismissLoadingIndicator();
    16 if (IS_ONLINE == 'true') {
    6 17 socket = io(CHAT_SERVER_URL);
    18 console.log('insOnline');
    7 19 setSocketAction();
    8 20 android.updateRoomList();
    9 CHAT_UI.refreshRoomList();
    21 CHAT_UI.refreshRoomList("1");
    10 22 CHAT_UI.dismissLoadingIndicator();
    11 23 $('#createChatRoom').show();
    12 24 } else {
    25 console.log('insOffline');
    • Kim Peace @kim-p commented Feb 24, 2021
      Master

      [nit] isOffline?

      Edited Feb 24, 2021
      [nit] `isOffline`?
    • Lee Munkyeong @lee-mk

      changed this line in version 4 of the diff

      Feb 24, 2021

      changed this line in version 4 of the diff

      changed this line in [version 4 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/3/diffs?diff_id=5262&start_sha=67e11f79258e9b15ed09cbdb2709fb6601221d43#545eb949e18804dc3e5b6b017bbed7343a9b232d_25_25)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Feb 24, 2021
    Resolved by Lee Munkyeong Feb 24, 2021
    public/js/chat.js
    267 267 CHAT.leaveRoom = function() {
    268 268 socket.emit('leaveRoom', function() {
    269 269 });
    270 }
    271
    272 CHAT.requestMyinfo = function() {
    273 jQuery.ajax({
    274 async: true,
    275 url: CMS_SERVER_URL+"/chatapi/user?sid="+CHAT.globalLoginParameter.sid+"&cmd="+userAPICmd.MYINFO,
    • Kim Peace @kim-p commented Feb 24, 2021
      Master

      [nits] url: CMS_SERVER_URLの間のスペースは1個だけにして下さい。

      Edited Feb 24, 2021
      [nits] `url: CMS_SERVER_URL`の間のスペースは1個だけにして下さい。
    • Kim Peace @kim-p commented Feb 24, 2021
      Master

      [nits] +の前後はスペースを空けて下さい。

      Edited Feb 24, 2021
      [nits] `+`の前後はスペースを空けて下さい。
    • Lee Munkyeong @lee-mk

      changed this line in version 4 of the diff

      Feb 24, 2021

      changed this line in version 4 of the diff

      changed this line in [version 4 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/3/diffs?diff_id=5262&start_sha=67e11f79258e9b15ed09cbdb2709fb6601221d43#2423f9836931bf9097f000721576347d5e2d7407_275_275)
      Toggle commit list
    Please register or sign in to reply
  • Lee Daehyun
    @lee-dh started a discussion on the diff Feb 24, 2021
    Resolved by Lee Daehyun Feb 24, 2021
    public/js/chat-ui.js
    130 131 // 検索結果が有る場合、結果を表示する
    131 132 socket.emit('roomSearch', encodeURIComponent($('#room-search').val()));
    132 133 } else {
    133 socket.emit('getRoomList');
    134 if (IS_ONLINE == 'true') {
    • Lee Daehyun @lee-dh commented Feb 24, 2021
      Developer

      インデントを合わしてください

      Edited Feb 24, 2021
      インデントを合わしてください
    Please register or sign in to reply
  • Lee Daehyun
    @lee-dh started a discussion on the diff Feb 24, 2021
    Resolved by Lee Daehyun Feb 24, 2021
    public/js/chat-ui.js
    385 391 $('#newRoomName').val('');
    386 392 $('#userSelectionLength').text('');
    387 393 CHAT.globalSelectedUserList = [];
    388
    394 $('#bottomNav').hide();
    • Lee Daehyun @lee-dh commented Feb 24, 2021
      Developer

      インデントを合わしてください

      Edited Feb 24, 2021
      インデントを合わしてください
    Please register or sign in to reply
  • Lee Daehyun
    @lee-dh started a discussion on the diff Feb 24, 2021
    Resolved by Lee Daehyun Feb 24, 2021
    public/js/chat-ui.js
    385 391 $('#newRoomName').val('');
    386 392 $('#userSelectionLength').text('');
    387 393 CHAT.globalSelectedUserList = [];
    388
    394 $('#bottomNav').hide();
    389 395 $('#backButton').off().on('click', function() {
    390 396 //loadingIndicatorを表示
    391 397 CHAT_UI.showLoadingIndicator();
    392 socket.emit('leaveRoom', function() {
    393 CHAT.saveRoomInfo();
    394 socket.emit('getRoomList');
    395 });
    398 CHAT.saveRoomInfo();
    399 if (IS_ONLINE == 'true') {
    400 socket.emit('leaveRoom', function() {
    401 android.updateRoomList();
    • Lee Daehyun @lee-dh commented Feb 24, 2021
      Developer

      インデントを合わしてください

      Edited Feb 24, 2021
      インデントを合わしてください
    Please register or sign in to reply
  • Lee Daehyun
    @lee-dh started a discussion on the diff Feb 24, 2021
    Resolved by Lee Daehyun Feb 24, 2021
    public/js/chat-ui.js
    405 415 $('#room-search').val('');
    406 416 // set Title
    407 417 let roomListTitle = getLocalizedString("roomListTitle")
    408
    418 $('#bottomNav').show();
    • Lee Daehyun @lee-dh commented Feb 24, 2021
      Developer

      インデントを合わしてください

      Edited Feb 24, 2021
      インデントを合わしてください
    Please register or sign in to reply
  • Lee Daehyun
    @lee-dh started a discussion on an old version of the diff Feb 24, 2021
    Resolved by Lee Daehyun Feb 24, 2021
    public/js/chat-ui.js
    431 455 //loadingIndicatorを表示しない
    432 456 CHAT_UI.dismissLoadingIndicator();
    433 457 $('#homeButton').hide();
    458 $('#bottomNav').hide();
    434 459 $('.user_people').css("paddingLeft", "0px");
    435 460 break;
    436 461 case '#pills-communication': // コミュニケーションのタブ
    437 462 case '#pills-setting': // 設定のタブ
    438 463 case '#pills-profile': // ユーザプロファイルのタブ
    464 $('#bottomNav').hide();
    • Lee Daehyun @lee-dh commented Feb 24, 2021
      Developer

      インデントを合わしてください

      Edited Feb 24, 2021
      インデントを合わしてください
    • Lee Munkyeong @lee-mk

      changed this line in version 4 of the diff

      Feb 24, 2021

      changed this line in version 4 of the diff

      changed this line in [version 4 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/3/diffs?diff_id=5262&start_sha=67e11f79258e9b15ed09cbdb2709fb6601221d43#592e19e9bf87556e2256309d4bf2f8b1b96262f7_464_419)
      Toggle commit list
    Please register or sign in to reply
  • Lee Daehyun
    @lee-dh started a discussion on an old version of the diff Feb 24, 2021
    Resolved by Lee Daehyun Feb 24, 2021
    public/js/chat-ui.js
    921 //TODO need onClick Action
    922 console.log('groupClick');
    923 });
    924
    925 $('#favorite_list').append(obj);
    926 })
    927
    928 var favoriteUserList = CHAT_DB.getFavoriteUsers();
    929 favoriteUserList.forEach(function(favoriteUser) {
    930 let html = Mustache.render(groupTemplate, {
    931 id: favoriteUser.shopMemberId,
    932 profileImage: favoriteUser.profileImagePath,
    933 name: favoriteUser.shopMemberName
    934 });
    935
    936 let obj = $(jQuery.parseHTML(html)).on('click',function(){
    • Lee Daehyun @lee-dh commented Feb 24, 2021
      Developer

      インデントを合わしてください

      Edited Feb 24, 2021
      インデントを合わしてください
    • Lee Munkyeong @lee-mk

      changed this line in version 4 of the diff

      Feb 24, 2021

      changed this line in version 4 of the diff

      changed this line in [version 4 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/3/diffs?diff_id=5262&start_sha=67e11f79258e9b15ed09cbdb2709fb6601221d43#592e19e9bf87556e2256309d4bf2f8b1b96262f7_936_939)
      Toggle commit list
    Please register or sign in to reply
  • Lee Daehyun
    @lee-dh started a discussion on an old version of the diff Feb 24, 2021
    Resolved by Lee Daehyun Feb 24, 2021
    public/js/chat-ui.js
    846 1028 // loadingIndicatorを表示しない
    847 1029 CHAT_UI.dismissLoadingIndicator();
    848 1030 };
    1031
    1032 CHAT_UI.joinRoom = function(roomId,roomName) {
    1033 console.log(roomId);
    1034 if (IS_ONLINE == 'true') {
    1035 android.updateMessages(roomId);
    1036 socket.emit('joinRoom', roomId, roomName, function() {
    1037 });
    1038 } else {
    • Lee Daehyun @lee-dh commented Feb 24, 2021
      Developer

      elseの中に実装するものがないので使わないことだったれ削除してください

      Edited Feb 24, 2021
      elseの中に実装するものがないので使わないことだったれ削除してください
    • Lee Munkyeong @lee-mk

      changed this line in version 4 of the diff

      Feb 24, 2021

      changed this line in version 4 of the diff

      changed this line in [version 4 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/3/diffs?diff_id=5262&start_sha=67e11f79258e9b15ed09cbdb2709fb6601221d43#592e19e9bf87556e2256309d4bf2f8b1b96262f7_1038_1052)
      Toggle commit list
    Please register or sign in to reply
  • Lee Daehyun
    @lee-dh started a discussion on an old version of the diff Feb 24, 2021
    Resolved by Lee Daehyun Feb 24, 2021
    public/js/libs/collapsible.js 0 → 100644
    1 var coll = document.getElementsByClassName("collapsible");
    2 var i;
    3
    4 for (i = 0; i < coll.length; i++) {
    5 coll[i].addEventListener("click", function() {
    6 this.classList.toggle("collapsible-active");
    • Lee Daehyun @lee-dh commented Feb 24, 2021
      Developer

      インデントがスペースだど思います

      Edited Feb 24, 2021
      インデントがスペースだど思います
    • Lee Munkyeong @lee-mk

      changed this line in version 4 of the diff

      Feb 24, 2021

      changed this line in version 4 of the diff

      changed this line in [version 4 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/3/diffs?diff_id=5262&start_sha=67e11f79258e9b15ed09cbdb2709fb6601221d43#a69ef19c960d4c3ee539569f5acb54c9d3f07239_6_5)
      Toggle commit list
    Please register or sign in to reply
  • Lee Daehyun @lee-dh

    assigned to @lee-mk

    Feb 24, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Munkyeong @lee-mk

    added 1 commit

    • 0b9baea9 - コードレビュー対応

    Compare with previous version

    Feb 24, 2021

    added 1 commit

    • 0b9baea9 - コードレビュー対応

    Compare with previous version

    added 1 commit * 0b9baea9 - コードレビュー対応 [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/3/diffs?diff_id=5262&start_sha=67e11f79258e9b15ed09cbdb2709fb6601221d43)
    Toggle commit list
  • Lee Munkyeong @lee-mk

    added 1 commit

    • e4c5bf51 - UI修正

    Compare with previous version

    Feb 24, 2021

    added 1 commit

    • e4c5bf51 - UI修正

    Compare with previous version

    added 1 commit * e4c5bf51 - UI修正 [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/3/diffs?diff_id=5264&start_sha=0b9baea9aac150d7ad7b2d76b0613bcb8f83b965)
    Toggle commit list
  • Lee Munkyeong @lee-mk

    added 1 commit

    • 990c3063 - インデント修正

    Compare with previous version

    Feb 24, 2021

    added 1 commit

    • 990c3063 - インデント修正

    Compare with previous version

    added 1 commit * 990c3063 - インデント修正 [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/3/diffs?diff_id=5267&start_sha=e4c5bf514e25c78f60eef49ef5a6a7a3d8e2b815)
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @lee-dh

    Feb 24, 2021

    assigned to @lee-dh

    assigned to @lee-dh
    Toggle commit list
  • Lee Daehyun @lee-dh

    resolved all discussions

    Feb 24, 2021

    resolved all discussions

    resolved all discussions
    Toggle commit list
  • Lee Daehyun @lee-dh

    changed the description

    Feb 24, 2021

    changed the description

    changed the description
    Toggle commit list
  • Lee Daehyun @lee-dh

    marked the task @lee-dh as completed

    Feb 24, 2021

    marked the task @lee-dh as completed

    marked the task **@lee-dh** as completed
    Toggle commit list
  • Lee Daehyun @lee-dh

    assigned to @lee-mk

    Feb 24, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @kang-dh

    Feb 24, 2021

    assigned to @kang-dh

    assigned to @kang-dh
    Toggle commit list
  • Lee Munkyeong @lee-mk

    added 6 commits

    • 990c3063...65204d49 - 5 commits from branch release_sp3
    • e86aa19e - Merge branch 'release_sp3' into 'devlop_contactUI'

    Compare with previous version

    Feb 25, 2021

    added 6 commits

    • 990c3063...65204d49 - 5 commits from branch release_sp3
    • e86aa19e - Merge branch 'release_sp3' into 'devlop_contactUI'

    Compare with previous version

    added 6 commits * 990c3063...65204d49 - 5 commits from branch `release_sp3` * e86aa19e - Merge branch &#x27;release_sp3&#x27; into &#x27;devlop_contactUI&#x27; [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/3/diffs?diff_id=5270&start_sha=990c3063beddf91985bd84c0ffad35ca39b7fb32)
    Toggle commit list
  • Kang Donghun
    @kang-dh started a discussion on the diff Feb 25, 2021
    Resolved by Lee Munkyeong Feb 25, 2021
    public/js/libs/collapsible.js 0 → 100644
    1 var coll = document.getElementsByClassName("collapsible");
    2 var i;
    3
    4 for (i = 0; i < coll.length; i++) {
    5 coll[i].addEventListener("click", function() {
    6 this.classList.toggle("collapsible-active");
    7 var content = this.nextElementSibling;
    8 if (content.style.display === "block") {
    9 content.style.display = "none";
    • Kang Donghun @kang-dh commented Feb 25, 2021
      Developer

      インデントを合わせてください。

      Edited Feb 25, 2021
      インデントを合わせてください。
    Please register or sign in to reply
  • Kang Donghun @kang-dh

    marked the task @kang-dh as completed

    Feb 25, 2021

    marked the task @kang-dh as completed

    marked the task **@kang-dh** as completed
    Toggle commit list
  • Kang Donghun @kang-dh

    assigned to @lee-mk

    Feb 25, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @kim-p

    Feb 25, 2021

    assigned to @kim-p

    assigned to @kim-p
    Toggle commit list
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Feb 25, 2021
    Resolved by Lee Munkyeong Feb 25, 2021
    public/index.html
    149 141 </div>
    150 142
    151 143 <div class="tab-content" id="pills-tabContent">
    144
    152 145 <div class="tab-pane fade show active" id="pills-chatlist" role="tabpanel" aria-labelledby="pills-chatlist-tab">
    153 146 <div class="search-group">
    154 147 <div class="input-group search-bar-fixed">
    155 148 <input style="font-family:Arial, FontAwesome !important;" id="room-search" type="text" class="write_msg form-control" name="message" placeholder="&#xF002;" autocomplete="off">
    156 149 </div>
    157 150 </div>
    151 <div class="text-center">
    152 <button type="button" class="btn btn-primary chat-list-type-btn" id="dmBtn">Ok</button>
    • Kim Peace @kim-p commented Feb 25, 2021
      Master

      [nits] "button" classの間にスペースが2つ入ってます。

      Edited Feb 25, 2021
      [nits] `"button" class`の間にスペースが2つ入ってます。
    • Lee Munkyeong @lee-mk

      changed this line in version 8 of the diff

      Feb 25, 2021

      changed this line in version 8 of the diff

      changed this line in [version 8 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/3/diffs?diff_id=5290&start_sha=e86aa19e16768a345956ca9b159badf853715d7e#f43ecdf8d666ee908aacce037b4cd72159e4741b_152_152)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Feb 25, 2021
    Resolved by Lee Munkyeong Feb 25, 2021
    public/js/chat-ui.js
    642 });
    643 // TODO 次のコミットに参考事項
    644 // チャットルーム開設画面で参加ユーザー削除用チェックロジックが残っているので
    645 // 影響テスト後、削除予定。 kang-dh
    646 let obj = $(jQuery.parseHTML(html)).on('click',function(){
    647 $(this).find('.userCheckBox').toggleClass('active');
    648 });
    649
    650 $('#select_user_list').append(obj);
    651 });
    652
    653 let roomListTitle = getLocalizedString("createRoomTitle")
    654 $('.titleRoomName').text(roomListTitle)
    655
    656 // Rotate
    657 if(CHAT_UI.isLandscapeMode()){
    • Kim Peace @kim-p commented Feb 25, 2021
      Master

      [nits] ifの後ろにはスペースを空けて下さい。{の前にもスペースを空けて下さい。

      Edited Feb 25, 2021
      [nits] `if`の後ろにはスペースを空けて下さい。`{`の前にもスペースを空けて下さい。
    • Lee Munkyeong @lee-mk

      changed this line in version 8 of the diff

      Feb 25, 2021

      changed this line in version 8 of the diff

      changed this line in [version 8 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/3/diffs?diff_id=5290&start_sha=e86aa19e16768a345956ca9b159badf853715d7e#592e19e9bf87556e2256309d4bf2f8b1b96262f7_657_656)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace @kim-p

    marked the task @kim-p as completed

    Feb 25, 2021

    marked the task @kim-p as completed

    marked the task **@kim-p** as completed
    Toggle commit list
  • Kim Peace @kim-p

    assigned to @lee-mk

    Feb 25, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @miura-t

    Feb 25, 2021

    assigned to @miura-t

    assigned to @miura-t
    Toggle commit list
  • Takatoshi Miura
    @miura-t started a discussion on an old version of the diff Feb 25, 2021
    Resolved by Lee Munkyeong Feb 25, 2021
    public/js/chat.js
    267 267 CHAT.leaveRoom = function() {
    268 268 socket.emit('leaveRoom', function() {
    269 269 });
    270 }
    271
    272 CHAT.requestMyinfo = function() {
    273 jQuery.ajax({
    274 async: true,
    275 url: CMS_SERVER_URL + "/chatapi/user?sid=" + CHAT.globalLoginParameter.sid + "&cmd=" + userAPICmd.MYINFO,
    276 type: "get",
    277 processData: false,
    278 contentType: false
    279 }).done(function(res) {
    • Takatoshi Miura @miura-t commented Feb 25, 2021
      Developer

      インデントを合わせてください。

      Edited Feb 25, 2021
      インデントを合わせてください。
    • Lee Munkyeong @lee-mk

      changed this line in version 8 of the diff

      Feb 25, 2021

      changed this line in version 8 of the diff

      changed this line in [version 8 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/3/diffs?diff_id=5290&start_sha=e86aa19e16768a345956ca9b159badf853715d7e#2423f9836931bf9097f000721576347d5e2d7407_279_279)
      Toggle commit list
    Please register or sign in to reply
  • Takatoshi Miura @miura-t

    assigned to @lee-mk

    Feb 25, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Jung Kwangkyu
    @jung-k started a discussion on the diff Feb 25, 2021
    Last updated by Lee Munkyeong Feb 25, 2021
    public/index.html
    326 357 </li>
    327 358 </ul>
    328 359 </div>
    360 <nav class="navbar navbar-expand navbar-dark fixed-bottom flex-md-nowrap p-2 bg-footer talign-center border footer-nav" id="bottomNav">
    361 <div class="col-4">
    • Jung Kwangkyu @jung-k commented Feb 25, 2021
      Owner

      col+番号になっていますが、番号の意味はありますか。

      col+番号になっていますが、番号の意味はありますか。
    • Lee Munkyeong @lee-mk commented Feb 25, 2021
      Developer

      bootstrapで提供されているクラスですが、4は横の割合1/3を意味します。 6は半分、8は2/3になります。

      Edited Feb 25, 2021
      bootstrapで提供されているクラスですが、4は横の割合1/3を意味します。 6は半分、8は2/3になります。
    Please register or sign in to reply
  • Takatoshi Miura @miura-t

    marked the task @miura-t as completed

    Feb 25, 2021

    marked the task @miura-t as completed

    marked the task **@miura-t** as completed
    Toggle commit list
  • Jung Kwangkyu
    @jung-k started a discussion on an old version of the diff Feb 25, 2021
    Last updated by Lee Munkyeong Feb 25, 2021
    public/js/chat-websocket.js
    5 if (isOnline == 'true') {
    3 function getGlobalParam(chatServerUrl, cmsServerUrl, platform, isMobile, isOnline) {
    4 CHAT_SERVER_URL = chatServerUrl;
    5 CMS_SERVER_URL = cmsServerUrl;
    6 PLATFORM = platform;
    7 IS_MOBILE = isMobile;
    8 IS_ONLINE = isOnline;
    9 connectSocket();
    10 };
    11
    12 android.getGlobalParameter();
    13
    14 function connectSocket() {
    15 CHAT_UI.dismissLoadingIndicator();
    16 if (IS_ONLINE == 'true') {
    17 console.log('isOnline');
    • Jung Kwangkyu @jung-k commented Feb 25, 2021
      Owner

      こちらはデーバグ用ですか?

      こちらはデーバグ用ですか?
    • Lee Munkyeong @lee-mk commented Feb 25, 2021
      Developer

      はい、デーバグ用のコードなので削除します。

      Edited Feb 25, 2021
      はい、デーバグ用のコードなので削除します。
    • Lee Munkyeong @lee-mk

      changed this line in version 8 of the diff

      Feb 25, 2021

      changed this line in version 8 of the diff

      changed this line in [version 8 of the diff](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/3/diffs?diff_id=5290&start_sha=e86aa19e16768a345956ca9b159badf853715d7e#545eb949e18804dc3e5b6b017bbed7343a9b232d_17_17)
      Toggle commit list
    Please register or sign in to reply
  • Lee Munkyeong @lee-mk

    added 2 commits

    • 156a417a - コードレビュー対応
    • f2274453 - Merge branch 'devlop_contactUI' of…

    Compare with previous version

    Feb 25, 2021

    added 2 commits

    • 156a417a - コードレビュー対応
    • f2274453 - Merge branch 'devlop_contactUI' of…

    Compare with previous version

    added 2 commits * 156a417a - コードレビュー対応 * f2274453 - Merge branch &#x27;devlop_contactUI&#x27; of… [Compare with previous version](https://gitlab.agentec.jp/abookCommunication/chat_webview/merge_requests/3/diffs?diff_id=5290&start_sha=e86aa19e16768a345956ca9b159badf853715d7e)
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @jung-k

    Feb 25, 2021

    assigned to @jung-k

    assigned to @jung-k
    Toggle commit list
  • Jung Kwangkyu @jung-k

    marked the task @jung-k as completed

    Mar 02, 2021

    marked the task @jung-k as completed

    marked the task **@jung-k** as completed
    Toggle commit list
  • Jung Kwangkyu @jung-k

    assigned to @lee-mk

    Mar 02, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Munkyeong @lee-mk

    merged

    Mar 02, 2021

    merged

    merged
    Toggle commit list
  • Lee Munkyeong @lee-mk

    mentioned in commit 7cc4d958

    Mar 02, 2021

    mentioned in commit 7cc4d958

    mentioned in commit 7cc4d9586ea05d5300230f65b9899916a1097dc0
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Lee Munkyeong
Assignee
Lee Munkyeong @lee-mk
Assign to
None
Milestone
None
Assign milestone
Time tracking
6
6 participants
Reference: abookCommunication/chat_webview!3
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.