Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !104

Merged
Opened Apr 12, 2021 by Lee Munkyeong@lee-mk 2 of 2 tasks completed2/2 tasks
  • Report abuse
Report abuse

Features/abcomm sp6 archive

  • @kim-p
  • @lee-dh
Edited Apr 12, 2021 by Kim Peace
  • Discussion 4
  • Commits 5
  • Changes 13
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Lee Munkyeong @lee-mk

    added 1 commit

    • 17f23320 - コード整理

    Compare with previous version

    Apr 12, 2021

    added 1 commit

    • 17f23320 - コード整理

    Compare with previous version

    added 1 commit * 17f23320 - コード整理 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/104/diffs?diff_id=5836&start_sha=f701f3701885194084fb1be657ba7e12c313225d)
    Toggle commit list
  • Lee Daehyun @lee-dh

    assigned to @lee-mk

    Apr 12, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Daehyun @lee-dh

    marked the task @lee-dh as completed

    Apr 12, 2021

    marked the task @lee-dh as completed

    marked the task **@lee-dh** as completed
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @kim-p

    Apr 12, 2021

    assigned to @kim-p

    assigned to @kim-p
    Toggle commit list
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Apr 12, 2021
    Last updated by Lee Munkyeong Apr 12, 2021
    ABVJE_BL/src/jp/agentec/abook/abv/bl/acms/client/parameters/GetArchivesDetailParameters.java 0 → 100644
    1 package jp.agentec.abook.abv.bl.acms.client.parameters;
    2
    3 import jp.agentec.adf.net.http.HttpParameterObject;
    4
    5 /**
    6 * ACMSのAPIに渡す共通的なパラメータを格納します。ACMSのAPIのパラメータ用クラスを作成するときはこのクラスを継承してください。<br>
    7 * ただし、このクラスはログイン状態の確認用として使われる {@link GetArchivesDetailParameters#sid} を持っているため、ログイン用のパラメータ {@link MobileLoginParameters} は、このクラスを継承する必要はありません。
    8 * @author lee-mk
    9 * @version 1.0.0
    10 */
    11 public class GetArchivesDetailParameters extends HttpParameterObject {
    • Kim Peace @kim-p commented Apr 12, 2021
      Master

      [nits] GetArchivesDetailParameters -> ArchivesDetailRequestParameters

      Edited Apr 12, 2021 by Kim Peace
      [nits] `GetArchivesDetailParameters` -> `ArchivesDetailRequestParameters`
    • Lee Munkyeong @lee-mk

      changed this line in version 3 of the diff

      Apr 12, 2021

      changed this line in version 3 of the diff

      changed this line in [version 3 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/104/diffs?diff_id=5850&start_sha=17f23320b8d24cc50a9b2f0cf645923a0eba8972#1c6527612dff784a23213f820d098f45ab175002_11_0)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Apr 12, 2021
    Last updated by Lee Munkyeong Apr 12, 2021
    ABVJE_BL/src/jp/agentec/abook/abv/bl/acms/client/parameters/GetArchivesParameters.java 0 → 100644
    1 package jp.agentec.abook.abv.bl.acms.client.parameters;
    2
    3 import jp.agentec.adf.net.http.HttpParameterObject;
    4
    5 /**
    6 * ACMSのAPIに渡す共通的なパラメータを格納します。ACMSのAPIのパラメータ用クラスを作成するときはこのクラスを継承してください。<br>
    7 * ただし、このクラスはログイン状態の確認用として使われる {@link GetArchivesParameters#sid} を持っているため、ログイン用のパラメータ {@link MobileLoginParameters} は、このクラスを継承する必要はありません。
    8 * @author Taejin Hong
    9 * @version 1.0.0
    10 */
    11 public class GetArchivesParameters extends HttpParameterObject {
    • Kim Peace @kim-p commented Apr 12, 2021
      Master

      [nits] GetArchivesParameters -> ArchivesRequestParameters

      Edited Apr 12, 2021 by Kim Peace
      [nits] `GetArchivesParameters` -> `ArchivesRequestParameters`
    • Lee Munkyeong @lee-mk

      changed this line in version 3 of the diff

      Apr 12, 2021

      changed this line in version 3 of the diff

      changed this line in [version 3 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/104/diffs?diff_id=5850&start_sha=17f23320b8d24cc50a9b2f0cf645923a0eba8972#8abc5663d2c9f33955f47dceffa34d36eedade07_11_0)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Apr 12, 2021
    Last updated by Lee Munkyeong Apr 12, 2021
    ABVJE_BL/src/jp/agentec/abook/abv/bl/acms/client/parameters/GetArchivesParameters.java 0 → 100644
    1 package jp.agentec.abook.abv.bl.acms.client.parameters;
    2
    3 import jp.agentec.adf.net.http.HttpParameterObject;
    4
    5 /**
    6 * ACMSのAPIに渡す共通的なパラメータを格納します。ACMSのAPIのパラメータ用クラスを作成するときはこのクラスを継承してください。<br>
    7 * ただし、このクラスはログイン状態の確認用として使われる {@link GetArchivesParameters#sid} を持っているため、ログイン用のパラメータ {@link MobileLoginParameters} は、このクラスを継承する必要はありません。
    8 * @author Taejin Hong
    • Kim Peace @kim-p commented Apr 12, 2021
      Master

      [nits] authorを変更してください。

      [nits] authorを変更してください。
    • Lee Munkyeong @lee-mk

      changed this line in version 3 of the diff

      Apr 12, 2021

      changed this line in version 3 of the diff

      changed this line in [version 3 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/104/diffs?diff_id=5850&start_sha=17f23320b8d24cc50a9b2f0cf645923a0eba8972#8abc5663d2c9f33955f47dceffa34d36eedade07_8_0)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Apr 12, 2021
    Last updated by Lee Munkyeong Apr 12, 2021
    ABVJE_BL/src/jp/agentec/abook/abv/bl/dto/ArchiveDto.java
    4 4
    5 5 public Integer archiveId;
    6 6 public String archiveName;
    7 public String archiveDate;
    7 8 public Integer archiveType;
    8 public String archiveUrl;
    9 public Integer collaborationId;
    10 public Integer shopMemberId;
    11 public String archiveSavePath;
    9 public Integer roomId;
    10 public Integer saveuserId;
    • Kim Peace @kim-p commented Apr 12, 2021
      Master

      [nits] saveuserId -> saveUserId

      [nits] `saveuserId` -> `saveUserId`
    • Lee Munkyeong @lee-mk

      changed this line in version 3 of the diff

      Apr 12, 2021

      changed this line in version 3 of the diff

      changed this line in [version 3 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/104/diffs?diff_id=5850&start_sha=17f23320b8d24cc50a9b2f0cf645923a0eba8972#39a340635facfd5bc7e1c861b637c579dba78346_10_10)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace @kim-p

    marked the task @kim-p as completed

    Apr 12, 2021

    marked the task @kim-p as completed

    marked the task **@kim-p** as completed
    Toggle commit list
  • Kim Peace @kim-p

    assigned to @lee-mk

    Apr 12, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Munkyeong @lee-mk

    added 1 commit

    • 049c73aa - コードレビュー対応。

    Compare with previous version

    Apr 12, 2021

    added 1 commit

    • 049c73aa - コードレビュー対応。

    Compare with previous version

    added 1 commit * 049c73aa - コードレビュー対応。 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/104/diffs?diff_id=5850&start_sha=17f23320b8d24cc50a9b2f0cf645923a0eba8972)
    Toggle commit list
  • Lee Munkyeong @lee-mk

    merged

    Apr 12, 2021

    merged

    merged
    Toggle commit list
  • Lee Munkyeong @lee-mk

    mentioned in commit 43e99294

    Apr 12, 2021

    mentioned in commit 43e99294

    mentioned in commit 43e99294575367c5739f837861bba41102b17ea4
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Lee Munkyeong
Assignee
Lee Munkyeong @lee-mk
Assign to
None
Milestone
None
Assign milestone
Time tracking
3
3 participants
Reference: abook_android/abook_check!104
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.