Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !114

Merged
Opened Apr 16, 2021 by Lee Munkyeong@lee-mk 3 of 3 tasks completed3/3 tasks
  • Report abuse
Report abuse

ルーム開設画面からルーム開設する場合既存のルームがあればアラート表示

  • @kim-p
  • @kang-dh
  • @lee-dh
Edited Apr 16, 2021 by Lee Daehyun
  • Discussion 1
  • Commits 2
  • Changes 5
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kang Donghun @kang-dh

    assigned to @lee-mk

    Apr 16, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Munkyeong @lee-mk

    changed the description

    Apr 16, 2021

    changed the description

    changed the description
    Toggle commit list
  • Lee Munkyeong @lee-mk

    marked the task @kang-dh as completed

    Apr 16, 2021

    marked the task @kang-dh as completed

    marked the task **@kang-dh** as completed
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @lee-dh

    Apr 16, 2021

    assigned to @lee-dh

    assigned to @lee-dh
    Toggle commit list
  • Kim Peace
    @kim-p started a discussion on the diff Apr 16, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/activity/ChatWebviewActivity.java
    819 819 }
    820 820
    821 821 @JavascriptInterface
    822 public void createChatRoom(String roomType, String userIdList, String encodedRoomName) throws NetworkDisconnectedException, AcmsException {
    822 public void createChatRoom(String roomType, String userIdList, String encodedRoomName, String screenFlg) throws NetworkDisconnectedException, AcmsException {
    823 823 CreatedRoomJSON resultJson = AcmsClient.getInstance(ABVEnvironment.getInstance().networkAdapter).createRoom(sid, roomType, userIdList, encodedRoomName, loginId);
    824 if ( ABookCommConstants.FLAG.SCREEN_FLG.MAKE_ROOM.equals(Integer.parseInt(screenFlg))) {
    • Kim Peace @kim-p commented Apr 16, 2021
      Master

      [nits]

      // not preferred
      if ( ABookCommConstants
      // preferred
      if (ABookCommConstants
      [nits] ```java // not preferred if ( ABookCommConstants // preferred if (ABookCommConstants ```
    Please register or sign in to reply
  • Kim Peace @kim-p

    marked the task @kim-p as completed

    Apr 16, 2021

    marked the task @kim-p as completed

    marked the task **@kim-p** as completed
    Toggle commit list
  • Lee Daehyun @lee-dh

    marked the task @lee-dh as completed

    Apr 16, 2021

    marked the task @lee-dh as completed

    marked the task **@lee-dh** as completed
    Toggle commit list
  • Lee Daehyun @lee-dh

    assigned to @lee-mk

    Apr 16, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Munkyeong @lee-mk

    merged

    Apr 16, 2021

    merged

    merged
    Toggle commit list
  • Lee Munkyeong @lee-mk

    mentioned in commit 623c61f2

    Apr 16, 2021

    mentioned in commit 623c61f2

    mentioned in commit 623c61f25627a874e3beba6db903dba0ff8a4c76
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Lee Munkyeong
Assignee
Lee Munkyeong @lee-mk
Assign to
None
Milestone
None
Assign milestone
Time tracking
4
4 participants
Reference: abook_android/abook_check!114
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.