Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !130

Merged
Opened Apr 26, 2021 by Kang Donghun@kang-dh 2 of 2 tasks completed2/2 tasks
  • Report abuse
Report abuse

協業記録参加者リスト表示

Reviewer

LGTMの場合、チェックをしてください。

  • @kim-p
  • @lee-mk
Edited Apr 26, 2021 by Kim Peace
  • Discussion 1
  • Commits 3
  • Changes 11
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kang Donghun @kang-dh

    added 1 commit

    • 632e4814 - コード整理

    Compare with previous version

    Apr 26, 2021

    added 1 commit

    • 632e4814 - コード整理

    Compare with previous version

    added 1 commit * 632e4814 - コード整理 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/130/diffs?diff_id=6115&start_sha=7246a130bc96207b5eea4bb96773a49320272815)
    Toggle commit list
  • Lee Munkyeong @lee-mk

    marked the task @lee-mk as completed

    Apr 26, 2021

    marked the task @lee-mk as completed

    marked the task **@lee-mk** as completed
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @kang-dh

    Apr 26, 2021

    assigned to @kang-dh

    assigned to @kang-dh
    Toggle commit list
  • Kang Donghun @kang-dh

    assigned to @lee-mk

    Apr 26, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @kim-p

    Apr 26, 2021

    assigned to @kim-p

    assigned to @kim-p
    Toggle commit list
  • Kim Peace
    @kim-p started a discussion on the diff Apr 26, 2021
    Resolved by Kang Donghun Apr 26, 2021
    ABVJE_BL/src/jp/agentec/abook/abv/bl/data/dao/ShopMemberDao.java
    157 sql.append(" FROM ");
    158 sql.append(" m_shop_member AS sm ");
    159 sql.append(" WHERE ");
    160 sql.append(" sm.login_id IN (");
    161
    162 ArrayList<String> whereSqlList = new ArrayList<String>();
    163 for (String loginId : loginIdList) {
    164 if (StringUtil.isNullOrEmpty(loginId)){
    165 continue;
    166 }
    167 String whereSql = "'"+loginId+"' ";
    168 whereSqlList.add(whereSql);
    169 }
    170 if (CollectionUtil.isNotEmpty(whereSqlList)) {
    171 sql.append(StringUtil.join(" , ", whereSqlList) + ")");
    172 }
    • Kim Peace @kim-p commented Apr 26, 2021
      Master

      [nits] add else here

      [nits] add else here
    Please register or sign in to reply
  • Kim Peace @kim-p

    marked the task @kim-p as completed

    Apr 26, 2021

    marked the task @kim-p as completed

    marked the task **@kim-p** as completed
    Toggle commit list
  • Kim Peace @kim-p

    assigned to @kang-dh

    Apr 26, 2021

    assigned to @kang-dh

    assigned to @kang-dh
    Toggle commit list
  • Kang Donghun @kang-dh

    added 1 commit

    • 71c61196 - SQL文 nullcheck追加

    Compare with previous version

    Apr 26, 2021

    added 1 commit

    • 71c61196 - SQL文 nullcheck追加

    Compare with previous version

    added 1 commit * 71c61196 - SQL文 nullcheck追加 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/130/diffs?diff_id=6122&start_sha=632e48146f945afc82732799fa3391626a75274b)
    Toggle commit list
  • Kang Donghun @kang-dh

    resolved all discussions

    Apr 26, 2021

    resolved all discussions

    resolved all discussions
    Toggle commit list
  • Kang Donghun @kang-dh

    merged

    Apr 26, 2021

    merged

    merged
    Toggle commit list
  • Kang Donghun @kang-dh

    mentioned in commit 5543fb53

    Apr 26, 2021

    mentioned in commit 5543fb53

    mentioned in commit 5543fb5331d9e0035bbbdab0acfdb0df23860f62
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Kang Donghun
Assignee
Kang Donghun @kang-dh
Assign to
None
Milestone
None
Assign milestone
Time tracking
3
3 participants
Reference: abook_android/abook_check!130
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.