Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !139

Merged
Opened May 06, 2021 by Kang Donghun@kang-dh 2 of 2 tasks completed2/2 tasks
  • Report abuse
Report abuse

協業中ユーザー招待機能実装

Reviewer

LGTMの場合、チェックをしてください。

  • @kim-p
  • @lee-mk
Edited May 06, 2021 by Kim Peace
  • Discussion 3
  • Commits 2
  • Changes 6
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kang Donghun @kang-dh

    changed the description

    May 06, 2021

    changed the description

    changed the description
    Toggle commit list
  • Kang Donghun @kang-dh

    assigned to @lee-mk

    May 06, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Munkyeong @lee-mk

    marked the task @lee-mk as completed

    May 06, 2021

    marked the task @lee-mk as completed

    marked the task **@lee-mk** as completed
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @kim-p

    May 06, 2021

    assigned to @kim-p

    assigned to @kim-p
    Toggle commit list
  • Kim Peace
    @kim-p started a discussion on an old version of the diff May 06, 2021
    Resolved by Kang Donghun May 07, 2021
    ABVJE_Res_Default_Android/res/values-ja/strings.xml
    1479 1479 <string name="msg_error_chat_name_has_invalid_character">特殊文字 ;/?:@&amp;=+$,-_.!~*\'()#\\\"` はルーム名に含めることができません。</string>
    1480 1480 <string name="msg_error_chat_room_sc_forbidden">認証に失敗しました。再度ログインが必要です。</string>
    1481 1481 <string name="msg_error_already_exist_same_room">同じルームが既に存在します。</string>
    1482 <string name="msg_confirm_send_host_change">ホスト権限を伝えてもらえますか?</string>
    • Kim Peace @kim-p commented May 06, 2021
      Master

      [nits] ホスト権限を伝えてもらえますか?

      -> ホスト権限をリクエストしますか?

      Edited May 06, 2021 by Kim Peace
      [nits] `ホスト権限を伝えてもらえますか?` -> `ホスト権限をリクエストしますか?`
    • Kang Donghun @kang-dh commented May 06, 2021
      Developer

      ホスト権限をリクエストしますか?

      ->ホスト権限をもらう時、ホストになる方の画面に出力されるメッセージなので、リクエストと意味が少し違うと思いますが、そのままでいいと思いますか?

      Edited May 06, 2021 by Kang Donghun
      `ホスト権限をリクエストしますか?` ->ホスト権限をもらう時、ホストになる方の画面に出力されるメッセージなので、リクエストと意味が少し違うと思いますが、そのままでいいと思いますか?
    • Kim Peace @kim-p commented May 07, 2021
      Master

      [nits] ホスト権限を渡しますか?

      [nits] `ホスト権限を渡しますか?`
    • Kang Donghun @kang-dh

      changed this line in version 2 of the diff

      May 07, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/139/diffs?diff_id=6163&start_sha=381ee4e71f55b353e669671069a886341f1b8305#e12cf7b3b29efc037dfeae561d8f045d22db9423_1482_1482)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace @kim-p

    marked the task @kim-p as completed

    May 06, 2021

    marked the task @kim-p as completed

    marked the task **@kim-p** as completed
    Toggle commit list
  • Kim Peace @kim-p

    assigned to @kang-dh

    May 06, 2021

    assigned to @kang-dh

    assigned to @kang-dh
    Toggle commit list
  • Kang Donghun @kang-dh

    assigned to @kim-p

    May 06, 2021

    assigned to @kim-p

    assigned to @kim-p
    Toggle commit list
  • Kang Donghun @kang-dh

    resolved all discussions

    May 07, 2021

    resolved all discussions

    resolved all discussions
    Toggle commit list
  • Kang Donghun @kang-dh

    added 1 commit

    • 367b0ea6 - レビューされた部分のコード修正

    Compare with previous version

    May 07, 2021

    added 1 commit

    • 367b0ea6 - レビューされた部分のコード修正

    Compare with previous version

    added 1 commit * 367b0ea6 - レビューされた部分のコード修正 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/139/diffs?diff_id=6163&start_sha=381ee4e71f55b353e669671069a886341f1b8305)
    Toggle commit list
  • Kang Donghun @kang-dh

    assigned to @kang-dh

    May 07, 2021

    assigned to @kang-dh

    assigned to @kang-dh
    Toggle commit list
  • Kang Donghun @kang-dh

    merged

    May 07, 2021

    merged

    merged
    Toggle commit list
  • Kang Donghun @kang-dh

    mentioned in commit 18b8c3c0

    May 07, 2021

    mentioned in commit 18b8c3c0

    mentioned in commit 18b8c3c04473df4e6d0d3fbad34d4e6ec00d2093
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Kang Donghun
Assignee
Kang Donghun @kang-dh
Assign to
None
Milestone
None
Assign milestone
Time tracking
3
3 participants
Reference: abook_android/abook_check!139
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.