Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !140

Merged
Opened May 07, 2021 by Kang Donghun@kang-dh 2 of 2 tasks completed2/2 tasks
  • Report abuse
Report abuse

[ネームカード]の[音声通話]を押下すると、該当ユーザと[音声通話]を開始する

[User]が[ネームカード]の[音声通話]を押下すると、該当ユーザと[音声通話]を開始する

Reviewer

LGTMの場合、チェックをしてください。

  • @kim-p
  • @lee-mk
Edited May 07, 2021 by Kim Peace
  • Discussion 1
  • Commits 2
  • Changes 1
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kang Donghun @kang-dh

    changed the description

    May 07, 2021

    changed the description

    changed the description
    Toggle commit list
  • Lee Munkyeong @lee-mk

    marked the task @lee-mk as completed

    May 07, 2021

    marked the task @lee-mk as completed

    marked the task **@lee-mk** as completed
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @kim-p

    May 07, 2021

    assigned to @kim-p

    assigned to @kim-p
    Toggle commit list
  • Kim Peace
    @kim-p started a discussion on an old version of the diff May 07, 2021
    Resolved by Kang Donghun May 07, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/activity/ChatWebviewActivity.java
    935 });
    930 if (isVoice) {
    931 roomId = chatRoomId.longValue();
    932 roomName = chatRoomName;
    933 mChatWebView.post(new Runnable() {
    934 @Override
    935 public void run() {
    936 mChatWebView.loadUrl(String.format("javascript:CHAT_UI.startCollaboration('%s');", ABookCommConstants.FLAG.COLLABORATION_TYPE.AUDIO));
    937 }
    938 });
    939 } else {
    940 mChatWebView.post(new Runnable() {
    941 @Override
    942 public void run() {
    943 mChatWebView.loadUrl(String.format("javascript:CHAT_UI.joinRoom('%s', '%s');", chatRoomId, chatRoomName));
    944 }
    • Kim Peace @kim-p commented May 07, 2021
      Master

      [nits] indent?

      [nits] indent?
    • Kang Donghun @kang-dh

      changed this line in version 2 of the diff

      May 07, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/140/diffs?diff_id=6164&start_sha=5d018bb5dc4a9315632f8428df72dbf26fa4ad74#13bb3577d9f8893bdbdac5e5e2d0bdfd8d98dc92_944_944)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace @kim-p

    marked the task @kim-p as completed

    May 07, 2021

    marked the task @kim-p as completed

    marked the task **@kim-p** as completed
    Toggle commit list
  • Kim Peace @kim-p

    assigned to @kang-dh

    May 07, 2021

    assigned to @kang-dh

    assigned to @kang-dh
    Toggle commit list
  • Kang Donghun @kang-dh

    added 1 commit

    • ff881d25 - インデント修正

    Compare with previous version

    May 07, 2021

    added 1 commit

    • ff881d25 - インデント修正

    Compare with previous version

    added 1 commit * ff881d25 - インデント修正 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/140/diffs?diff_id=6164&start_sha=5d018bb5dc4a9315632f8428df72dbf26fa4ad74)
    Toggle commit list
  • Kang Donghun @kang-dh

    resolved all discussions

    May 07, 2021

    resolved all discussions

    resolved all discussions
    Toggle commit list
  • Kang Donghun @kang-dh

    mentioned in commit bc84c3d7

    May 07, 2021

    mentioned in commit bc84c3d7

    mentioned in commit bc84c3d789b09b6d3feb9803117f04e63ca39041
    Toggle commit list
  • Kang Donghun @kang-dh

    merged

    May 07, 2021

    merged

    merged
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Kang Donghun
Assignee
Kang Donghun @kang-dh
Assign to
None
Milestone
None
Assign milestone
Time tracking
3
3 participants
Reference: abook_android/abook_check!140
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.