Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !141

Merged
Opened May 07, 2021 by Kang Donghun@kang-dh 2 of 2 tasks completed2/2 tasks
  • Report abuse
Report abuse

協業中ユーザー招待機能追加実装

Reviewer

LGTMの場合、チェックをしてください。

  • @kim-p
  • @lee-mk
Edited May 11, 2021 by Kim Peace
  • Discussion 2
  • Commits 4
  • Changes 12
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Lee Munkyeong @lee-mk

    marked the task @lee-mk as completed

    May 10, 2021

    marked the task @lee-mk as completed

    marked the task **@lee-mk** as completed
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @kang-dh

    May 10, 2021

    assigned to @kang-dh

    assigned to @kang-dh
    Toggle commit list
  • Kang Donghun @kang-dh

    added 1 commit

    • 4d107e23 - ルームタイプによって協業中にユーザー招待ボタンを非表示にするように修正

    Compare with previous version

    May 10, 2021

    added 1 commit

    • 4d107e23 - ルームタイプによって協業中にユーザー招待ボタンを非表示にするように修正

    Compare with previous version

    added 1 commit * 4d107e23 - ルームタイプによって協業中にユーザー招待ボタンを非表示にするように修正 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/141/diffs?diff_id=6176&start_sha=7df31a7366031e2785690652dc05328d3a1176e9)
    Toggle commit list
  • Kang Donghun @kang-dh

    assigned to @kim-p

    May 10, 2021

    assigned to @kim-p

    assigned to @kim-p
    Toggle commit list
  • Kim Peace
    @kim-p started a discussion on an old version of the diff May 11, 2021
    Last updated by Kang Donghun May 11, 2021
    ABVJE_BL/src/jp/agentec/abook/abv/bl/acms/client/parameters/InviteCollaborationParameters.java 0 → 100644
    1 package jp.agentec.abook.abv.bl.acms.client.parameters;
    2
    3 import jp.agentec.adf.net.http.HttpParameterObject;
    4
    5 public class InviteCollaborationParameters extends HttpParameterObject {
    • Kim Peace @kim-p commented May 11, 2021
      Master

      [nits] InviteCollaborationParameters extendsの間にスペースが2つ入っています。

      [nits] `InviteCollaborationParameters extends`の間にスペースが2つ入っています。
    • Kang Donghun @kang-dh

      changed this line in version 3 of the diff

      May 11, 2021

      changed this line in version 3 of the diff

      changed this line in [version 3 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/141/diffs?diff_id=6181&start_sha=4d107e23a7f5b8e9ca01e28822eaa4d6a9cabbb4#219bc70a3bb4cb1daa67f7843066911eb5569027_5_5)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff May 11, 2021
    Last updated by Kang Donghun May 11, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/helper/ActivityHandlingHelper.java
    1917 intent.putExtra("sid", sid);
    1918 String loginId = ABVDataCache.getInstance().getMemberInfo().loginId;
    1919 String shopName = ABVDataCache.getInstance().getUrlPath();
    1920 intent.putExtra("loginId", loginId);
    1921 intent.putExtra("collaborationType", collaborationType);
    1922 intent.putExtra("shopName", shopName);
    1923 intent.putExtra("roomId", roomId);
    1924 intent.putExtra("roomName", roomName);
    1925
    1926 intent.setClassName(mContext.getPackageName(), className);
    1927
    1928 Activity activity2 = null;
    1929 if (!currentActivityStack.isEmpty()) {
    1930 int size = currentActivityStack.size();
    1931
    1932 for(int i = size-1; i >= 0; i--) {
    • Kim Peace @kim-p commented May 11, 2021
      Master

      [nits] forと(の間にスペースを開けてください。

      [nits] `for`と`(`の間にスペースを開けてください。
    • Kang Donghun @kang-dh

      changed this line in version 3 of the diff

      May 11, 2021

      changed this line in version 3 of the diff

      changed this line in [version 3 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/141/diffs?diff_id=6181&start_sha=4d107e23a7f5b8e9ca01e28822eaa4d6a9cabbb4#9f691da92e673d9c91da4da742f20d398837c0be_1932_1932)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace @kim-p

    marked the task @kim-p as completed

    May 11, 2021

    marked the task @kim-p as completed

    marked the task **@kim-p** as completed
    Toggle commit list
  • Kim Peace @kim-p

    assigned to @kang-dh

    May 11, 2021

    assigned to @kang-dh

    assigned to @kang-dh
    Toggle commit list
  • Kang Donghun @kang-dh

    added 1 commit

    • 5f764931 - レビューされた部分のコード修正

    Compare with previous version

    May 11, 2021

    added 1 commit

    • 5f764931 - レビューされた部分のコード修正

    Compare with previous version

    added 1 commit * 5f764931 - レビューされた部分のコード修正 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/141/diffs?diff_id=6181&start_sha=4d107e23a7f5b8e9ca01e28822eaa4d6a9cabbb4)
    Toggle commit list
  • Kang Donghun @kang-dh

    merged

    May 11, 2021

    merged

    merged
    Toggle commit list
  • Kang Donghun @kang-dh

    mentioned in commit 5c18e2a3

    May 11, 2021

    mentioned in commit 5c18e2a3

    mentioned in commit 5c18e2a3b04f28bf0defa613ac202ba1546a30da
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Kang Donghun
Assignee
Kang Donghun @kang-dh
Assign to
None
Milestone
None
Assign milestone
Time tracking
3
3 participants
Reference: abook_android/abook_check!141
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.