Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !165

Merged
Opened May 27, 2021 by Lee Munkyeong@lee-mk 1 of 1 task completed1/1 task
  • Report abuse
Report abuse

Communication/feature/develop encode video

  • @kim-p
Edited May 27, 2021 by Kim Peace
  • Discussion 1
  • Commits 4
  • Changes 6
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kim Peace
    @kim-p started a discussion on an old version of the diff May 27, 2021
    Resolved by Lee Munkyeong May 28, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/activity/ChatWebViewActivity.java
    842 return null;
    843 }
    844 String filePath = file.getAbsolutePath();
    845 Cursor cursor = context.getContentResolver().query(
    846 MediaStore.Images.Media.EXTERNAL_CONTENT_URI,
    847 new String[] {BaseColumns._ID},
    848 MediaStore.MediaColumns.DATA + "=? ",
    849 new String[] { filePath }, null);
    850
    851 if (cursor != null && cursor.moveToFirst()) {
    852 int id = cursor.getInt(cursor
    853 .getColumnIndex(BaseColumns._ID));
    854 Uri baseUri = Uri.parse("content://media/external/video/media");
    855 return Uri.withAppendedPath(baseUri, "" + id);
    856 } else {
    857 if (file.exists()) {
    • Kim Peace @kim-p commented May 27, 2021
      Master

      [nits]

      // preferred to
          if (!file.exists()) { return; }
          ContentValues values = new ContentValues();
          values.put(MediaStore.MediaColumns.DATA, filePath);
          return context.getContentResolver().insert(
              MediaStore.Video.Media.EXTERNAL_CONTENT_URI,
              values
          );
      
      Edited May 28, 2021
      [nits] ```java // preferred to if (!file.exists()) { return; } ContentValues values = new ContentValues(); values.put(MediaStore.MediaColumns.DATA, filePath); return context.getContentResolver().insert( MediaStore.Video.Media.EXTERNAL_CONTENT_URI, values ); ```
    • Lee Munkyeong @lee-mk

      changed this line in version 2 of the diff

      May 27, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/165/diffs?diff_id=6335&start_sha=dc6b696789ea3b812f516836f99cfc577dcc1e2e#fe0b9dc37e3328752dbfa30f48f2116c6b0cb620_857_857)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace @kim-p

    assigned to @lee-mk

    May 27, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Kim Peace @kim-p

    marked the task @kim-p as completed

    May 27, 2021

    marked the task @kim-p as completed

    marked the task **@kim-p** as completed
    Toggle commit list
  • Lee Munkyeong @lee-mk

    added 1 commit

    • a8183c7d - コードレビュー対応及び動画エンコード失敗の処理追加。

    Compare with previous version

    May 27, 2021

    added 1 commit

    • a8183c7d - コードレビュー対応及び動画エンコード失敗の処理追加。

    Compare with previous version

    added 1 commit * a8183c7d - コードレビュー対応及び動画エンコード失敗の処理追加。 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/165/diffs?diff_id=6335&start_sha=dc6b696789ea3b812f516836f99cfc577dcc1e2e)
    Toggle commit list
  • Lee Munkyeong @lee-mk

    resolved all discussions

    May 28, 2021

    resolved all discussions

    resolved all discussions
    Toggle commit list
  • Lee Munkyeong @lee-mk

    mentioned in commit 9b011401

    May 28, 2021

    mentioned in commit 9b011401

    mentioned in commit 9b01140108ae786c5911cfb313295bdea989ca9b
    Toggle commit list
  • Lee Munkyeong @lee-mk

    merged

    May 28, 2021

    merged

    merged
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Lee Munkyeong
Assignee
Lee Munkyeong @lee-mk
Assign to
None
Milestone
None
Assign milestone
Time tracking
2
2 participants
Reference: abook_android/abook_check!165
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.