Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !195

Merged
Opened Aug 04, 2021 by onuma@onuma 2 of 2 tasks completed2/2 tasks
  • Report abuse
Report abuse

遠隔支援(会議室)接続中には、プッシュメッセージを受信してもチャットに行かないように修正。

LGTMの場合、チェックをしてください。

  • @kim-p
  • @kim_j
Edited Aug 05, 2021 by Kim Jinsung
  • Discussion 2
  • Commits 4
  • Changes 5
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • onuma @onuma

    added 1 commit

    • 99eceb75 - 文言が間違っていたのを修正した。

    Compare with previous version

    Aug 04, 2021

    added 1 commit

    • 99eceb75 - 文言が間違っていたのを修正した。

    Compare with previous version

    added 1 commit * 99eceb75 - 文言が間違っていたのを修正した。 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/195/diffs?diff_id=6817&start_sha=ac47e259af34cf77591980d38e9d5e51841548e0)
    Toggle commit list
  • Kim Peace @kim-p

    marked the task @kim-p as completed

    Aug 04, 2021

    marked the task @kim-p as completed

    marked the task **@kim-p** as completed
    Toggle commit list
  • Kim Peace @kim-p

    assigned to @kim_j

    Aug 04, 2021

    assigned to @kim_j

    assigned to @kim_j
    Toggle commit list
  • Kim Jinsung
    @kim_j started a discussion on commit ac47e259 Aug 05, 2021
    Last updated by onuma Aug 05, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/common/activity/ShowPushMessageDailogActivity.java
    147 }
    148 }
    149
    150 /**
    151 * チャットルームへ遷移するための処理
    152 * @param extras
    153 */
    154 private void moveChatRoom(Bundle extras) {
    155 Long roomId = extras.getLong(AppDefType.ChatPushMessageKey.roomId, 0);
    156 String roomName = extras.getString(AppDefType.ChatPushMessageKey.roomName);
    157 String pushSendLoginId = extras.getString(AppDefType.ChatPushMessageKey.pushSendLoginId);
    158 long pushSendDate = extras.getLong(AppDefType.ChatPushMessageKey.pushSendDate);
    159 String collaborationType = extras.getString(AppDefType.ChatPushMessageKey.collaborationType);
    160 String roomType = extras.getString(AppDefType.ChatPushMessageKey.roomType);
    161 if (roomId > 0 && !StringUtil.isNullOrEmpty(roomName)) {
    162 List<PushMessageDto> pushMessageDtoList = AbstractLogic.getLogic(PushMessageLogic.class).getAllPushMessageList();
    • Kim Jinsung @kim_j commented Aug 05, 2021
      Developer

      pushMessageDtoList この変数を使っている箇所はログ出力しかないですが、、いらないのではないでしょうか? ここからFor文までは、、不要な処理だと思います。

      `pushMessageDtoList` この変数を使っている箇所はログ出力しかないですが、、いらないのではないでしょうか? ここからFor文までは、、不要な処理だと思います。
    • onuma @onuma commented Aug 05, 2021
      Master

      ログ出力も含めて削除します。pushSendLoginIdも未使用なので削除します。

      ログ出力も含めて削除します。pushSendLoginIdも未使用なので削除します。
    Please register or sign in to reply
  • Kim Jinsung @kim_j

    assigned to @onuma

    Aug 05, 2021

    assigned to @onuma

    assigned to @onuma
    Toggle commit list
  • onuma @onuma

    added 1 commit

    • 1880833b - 未使用の変数を削除した。

    Compare with previous version

    Aug 05, 2021

    added 1 commit

    • 1880833b - 未使用の変数を削除した。

    Compare with previous version

    added 1 commit * 1880833b - 未使用の変数を削除した。 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/195/diffs?diff_id=6820&start_sha=99eceb756fe2bdfff56c26693dc4d4fd646e99b2)
    Toggle commit list
  • onuma @onuma

    assigned to @kim_j

    Aug 05, 2021

    assigned to @kim_j

    assigned to @kim_j
    Toggle commit list
  • Kim Jinsung @kim_j

    marked the task @kim_j as completed

    Aug 05, 2021

    marked the task @kim_j as completed

    marked the task **@kim_j** as completed
    Toggle commit list
  • onuma @onuma

    merged

    Aug 05, 2021

    merged

    merged
    Toggle commit list
  • onuma @onuma

    mentioned in commit f916844c

    Aug 05, 2021

    mentioned in commit f916844c

    mentioned in commit f916844c85d2f948bedfc0618aefddd083d2e3a9
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Kim Jinsung
Assignee
Kim Jinsung @kim_j
Assign to
None
Milestone
None
Assign milestone
Time tracking
3
3 participants
Reference: abook_android/abook_check!195
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.