Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !199

Merged
Opened Aug 10, 2021 by onuma@onuma 2 of 2 tasks completed2/2 tasks
  • Report abuse
Report abuse

#43368 AndroidとiOSで画面遷移を同じにした。

LGTMの場合、チェックをしてください。

  • @kim-p
  • @kim_j
Edited Aug 18, 2021 by Kim Peace
  • Discussion 9
  • Commits 3
  • Changes 16
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kim Jinsung
    @kim_j started a discussion on commit f4c426c5 Aug 10, 2021
    Last updated by onuma Aug 10, 2021
    ABVJE_BL/src/jp/agentec/abook/abv/bl/acms/client/json/ChatPushDataJSON.java
    48 48 }
    49 49 PushMessageDto pushMessageDto = new PushMessageDto();
    50 50 String tempDate = DateTimeUtil.toString(DateTimeUtil.toDate(pushMessagetJsonArray.getJSONObject(k).getString(PushSendDate), DateTimeFormat.yyyyMMddHHmmss_hyphen), DateTimeFormat.yyyyMMddHHmmssSSS_none);
    51 Logger.d("messageId","messageId : " + pushMessagetJsonArray.getJSONObject(k).getString(PushSendDate));
    52 Logger.d("oerationId","oerationId : " + pushMessagetJsonArray.getJSONObject(k).getString(PushSendDate)+1);
    53 Logger.d("date","date : " + tempDate);
    51 //Logger.d("messageId","messageId : " + pushMessagetJsonArray.getJSONObject(k).getString(PushSendDate));
    52 //Logger.d("oerationId","oerationId : " + pushMessagetJsonArray.getJSONObject(k).getString(PushSendDate)+1);
    53 //Logger.d("date","date : " + tempDate);
    • Kim Jinsung @kim_j commented Aug 10, 2021
      Developer

      不要なロジックは削除お願いします。

      不要なロジックは削除お願いします。
    • onuma @onuma commented Aug 10, 2021
      Master

      了解しました。

      了解しました。
    Please register or sign in to reply
  • Kim Jinsung
    @kim_j started a discussion on commit f4c426c5 Aug 10, 2021
    Last updated by onuma Aug 10, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/cl/push/ABVFcmListenerService.java
    170 pushMsgDialog.putExtra(AppDefType.PushMessageKey.message, textMessage);
    171 pushMsgDialog.putExtra(AppDefType.PushMessageKey.data, data);
    172 pushMsgDialog.putExtra(AppDefType.PushMessageKey.operationId, operationID);
    173 pushMsgDialog.putExtra(AppDefType.ChatPushMessageKey.roomId, roomID);
    174 pushMsgDialog.putExtra(AppDefType.ChatPushMessageKey.roomName, roomName);
    175 pushMsgDialog.putExtra(AppDefType.ChatPushMessageKey.pushSendLoginId, pushSendLoginId);
    176 pushMsgDialog.putExtra(AppDefType.ChatPushMessageKey.pushSendDate, pushSendDate);
    177 startActivity(pushMsgDialog);
    197 // プッシュメッセージは、受信した時のActivityで処理をわける(後処理が違うので)
    198 String fromClassName = currentActivity.getClass().getName();
    199 if (currentActivity.getClass().equals(HTMLWebViewActivity.class)){
    200 ((HTMLWebViewActivity)currentActivity).showChatRoomPopupMessage(textMessage, data, operationID, roomID, roomName, roomType, pushSendLoginId, pushSendDate, collaborationType);
    201 } else if (currentActivity.getClass().equals(ContentViewActivity.class)){
    202 ((ContentViewActivity)currentActivity).showChatRoomPopupMessage(textMessage, data, operationID, roomID, roomName, roomType, pushSendLoginId, pushSendDate, collaborationType);
    203 } else if (currentActivity.getClass().equals(OperationRelatedContentActivity.class)){
    204 ((ContentViewActivity)currentActivity).showChatRoomPopupMessage(textMessage, data, operationID, roomID, roomName, roomType, pushSendLoginId, pushSendDate, collaborationType);
    • Kim Jinsung @kim_j commented Aug 10, 2021
      Developer

      キャスト(ContentViewActivity)これで正しいでしょうか? 「OperationRelatedContentActivity」ではないでしょうか?

      キャスト`(ContentViewActivity)`これで正しいでしょうか? 「`OperationRelatedContentActivity`」ではないでしょうか?
    • onuma @onuma commented Aug 10, 2021
      Master

      修正します。

      修正します。
    Please register or sign in to reply
  • Kim Jinsung
    @kim_j started a discussion on commit f4c426c5 Aug 10, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/viewer/activity/HTMLWebViewActivity.java
    720 732 return;
    721 733 }
    722 734 mUploadMessage.onReceiveValue(result);
    723 } else if (requestCode == ABOOK_CHECK_SELECT_SCENE) {
    735 } else if (requestCode == ABookCommConstants.ABOOK_CHECK_SELECT_SCENE) {
    724 736 if (intent != null && result != null) {
    725 737 confirmEntrySceneDialog(result[0]);
    726 738 }
    727 739 }
    728 740 mUploadMessage = null;
    729 741 }
    742
    743 /**
    744 * プッシュメッセージ受信後のダイアログを表示処理。
    745 */
    746 public void showChatRoomPopupMessage(
    • Kim Jinsung @kim_j commented Aug 10, 2021
      Developer

      これって共通化できないのでしょうか? 親クラスとかで、、

      これって共通化できないのでしょうか? 親クラスとかで、、
    Please register or sign in to reply
  • onuma @onuma commented Aug 10, 2021
    Master

    共通化します。

    Edited Aug 10, 2021 by onuma
    共通化します。
  • Kim Peace
    @kim-p started a discussion on the diff Aug 10, 2021
    Last updated by Kim Peace Aug 18, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/helper/ActivityHandlingHelper.java
    1695 nextActivity = className;
    1696 }
    1697
    1698 intent.setClassName(mContext.getPackageName(), nextActivity);
    1699 intent.setFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP);
    1700 getCurrentActivity().startActivity(intent);
    1701 }
    1702
    1703 /**
    1704 * プシュメッセージからチャットに入る(協業)
    1705 */
    1706 public void startChatWebViewActivityWithCollaboration(String fromClassName, Long roomId, String roomName, String collaborationType, String roomType) {
    1707 String className = ChatWebViewActivity.class.getName();
    1708 boolean isNormalSize = (mContext.getResources().getConfiguration().screenLayout & Configuration.SCREENLAYOUT_SIZE_MASK) == Configuration.SCREENLAYOUT_SIZE_NORMAL;
    1709 Intent intent = new Intent();
    1710 intent.putExtra("chatWebviewUrl",ABVEnvironment.getInstance().acmsAddress + ABVDataCache.getInstance().getUrlPath() + "/chatapi/chat/");
    • Kim Peace @kim-p commented Aug 10, 2021
      Master

      ,の後はスペースを開けてください。

      `,`の後はスペースを開けてください。
    • Kim Peace @kim-p commented Aug 18, 2021
      Master

      こちら修正あれてなないです。

      こちら修正あれてなないです。
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Aug 10, 2021
    Last updated by onuma Aug 18, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/viewer/activity/ContentViewActivity.java
    5551 String roomName,
    5552 String roomType,
    5553 String pushSendLoginId,
    5554 long pushSendDate,
    5555 String collaborationType
    5556 ) {
    5557 String fromClassName = getClass().getName();
    5558 Intent pushMsgDialog = new Intent(ContentViewActivity.this, ShowPushMessageDailogActivity.class);
    5559 pushMsgDialog.putExtra(AppDefType.PushMessageKey.message, textMessage);
    5560 pushMsgDialog.putExtra(AppDefType.PushMessageKey.data, data);
    5561 pushMsgDialog.putExtra(AppDefType.PushMessageKey.operationId, operationID);
    5562 pushMsgDialog.putExtra(AppDefType.ChatPushMessageKey.roomId, roomID);
    5563 pushMsgDialog.putExtra(AppDefType.ChatPushMessageKey.roomName, roomName);
    5564 pushMsgDialog.putExtra(AppDefType.ChatPushMessageKey.pushSendLoginId, pushSendLoginId);
    5565 pushMsgDialog.putExtra(AppDefType.ChatPushMessageKey.pushSendDate, pushSendDate);
    5566 pushMsgDialog.putExtra(AppDefType.ChatPushMessageKey.fromClassName ,fromClassName);
    • Kim Peace @kim-p commented Aug 10, 2021
      Master

      [nits] ,の前はスペースを削除、後はスペースを開けてください

      [nits] `,`の前はスペースを削除、後はスペースを開けてください
    • onuma @onuma

      changed this line in version 3 of the diff

      Aug 18, 2021

      changed this line in version 3 of the diff

      changed this line in [version 3 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/199/diffs?diff_id=6870&start_sha=b113f1a251cb42d8ff6b158b8c5919777416bda7#87e2c2ac1989281cb2693628f4bdad2d95b507c9_5566_5543)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace @kim-p

    assigned to @onuma

    Aug 10, 2021

    assigned to @onuma

    assigned to @onuma
    Toggle commit list
  • onuma @onuma

    added 2 commits

    • 9f2a44fb - 1 commit from branch communication/develop
    • b113f1a2 - Merge branch 'communication/develop' into communication/develop_onuma

    Compare with previous version

    Aug 18, 2021

    added 2 commits

    • 9f2a44fb - 1 commit from branch communication/develop
    • b113f1a2 - Merge branch 'communication/develop' into communication/develop_onuma

    Compare with previous version

    added 2 commits * 9f2a44fb - 1 commit from branch `communication/develop` * b113f1a2 - Merge branch 'communication/develop' into communication/develop_onuma [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/199/diffs?diff_id=6866&start_sha=f4c426c58b3e8c9a1805a42c29639c4f101f9be6)
    Toggle commit list
  • onuma @onuma

    added 1 commit

    • 608d6491 - showChatRoomPopupMessage関数を共通化した。

    Compare with previous version

    Aug 18, 2021

    added 1 commit

    • 608d6491 - showChatRoomPopupMessage関数を共通化した。

    Compare with previous version

    added 1 commit * 608d6491 - showChatRoomPopupMessage関数を共通化した。 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/199/diffs?diff_id=6870&start_sha=b113f1a251cb42d8ff6b158b8c5919777416bda7)
    Toggle commit list
  • Kim Jinsung @kim_j

    marked the task @kim_j as completed

    Aug 18, 2021

    marked the task @kim_j as completed

    marked the task **@kim_j** as completed
    Toggle commit list
  • Kim Jinsung @kim_j

    assigned to @kim-p

    Aug 18, 2021

    assigned to @kim-p

    assigned to @kim-p
    Toggle commit list
  • Kim Peace @kim-p

    assigned to @onuma

    Aug 18, 2021

    assigned to @onuma

    assigned to @onuma
    Toggle commit list
  • Kim Peace @kim-p

    marked the task @kim-p as completed

    Aug 18, 2021

    marked the task @kim-p as completed

    marked the task **@kim-p** as completed
    Toggle commit list
  • onuma @onuma

    merged

    Aug 18, 2021

    merged

    merged
    Toggle commit list
  • onuma @onuma

    mentioned in commit 9c9c14d1

    Aug 18, 2021

    mentioned in commit 9c9c14d1

    mentioned in commit 9c9c14d1d9889e6aed17640b972e0a2a819ca1f1
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
onuma
Assignee
onuma @onuma
Assign to
None
Milestone
None
Assign milestone
Time tracking
3
3 participants
Reference: abook_android/abook_check!199
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.