Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !202

Merged
Opened Aug 19, 2021 by onuma@onuma 2 of 2 tasks completed2/2 tasks
  • Report abuse
Report abuse

バックグラウンドでプッシュメッセージ受信時の動作をiOSと同じにした。

LGTMの場合、チェックをしてください。

  • @kim-p
  • @kim_j
Edited Aug 20, 2021 by Kim Jinsung
  • Discussion 3
  • Commits 2
  • Changes 7
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Aug 20, 2021
    Last updated by onuma Aug 20, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/cl/push/ABVFcmListenerService.java
    76 80 String roomName = "";
    77 81 String pushSendLoginId = "";
    78 82 long pushSendDate = 0;
    83 String textMessage = "";
    84 String strRoomType = "";
    • Kim Peace @kim-p commented Aug 20, 2021
      Master

      [nits] スペースが2個入っています。

      [nits] スペースが2個入っています。
    • onuma @onuma

      changed this line in version 2 of the diff

      Aug 20, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/202/diffs?diff_id=6900&start_sha=8624f482a74155f6e60e8ba9a01943c4206a2cb7#35c43bdcbed56fa047ba60c2069e60fffdcbf6c4_84_84)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Aug 20, 2021
    Last updated by onuma Aug 20, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/helper/ActivityHandlingHelper.java
    1641 1641 String loginId = ABVDataCache.getInstance().getMemberInfo().loginId;
    1642 1642 String shopName = ABVDataCache.getInstance().getUrlPath();
    1643 1643 intent.putExtra("loginId", loginId);
    1644 intent.putExtra("shopName", shopName);
    1645 if(dto != null)
    1646 {
    1647 intent.putExtra("roomId",dto.roomId);
    1648 intent.putExtra("roomName", dto.roomName);
    1644 intent.putExtra(AppDefType.ChatPushMessageKey.shopName, shopName);
    1645 if(dto != null) {
    • Kim Peace @kim-p commented Aug 20, 2021
      Master

      if の後はスペースを開けてください。

      if の後はスペースを開けてください。
    • onuma @onuma

      changed this line in version 2 of the diff

      Aug 20, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/202/diffs?diff_id=6900&start_sha=8624f482a74155f6e60e8ba9a01943c4206a2cb7#9f691da92e673d9c91da4da742f20d398837c0be_1645_1645)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace @kim-p

    assigned to @kim_j

    Aug 20, 2021

    assigned to @kim_j

    assigned to @kim_j
    Toggle commit list
  • Kim Peace @kim-p

    marked the task @kim-p as completed

    Aug 20, 2021

    marked the task @kim-p as completed

    marked the task **@kim-p** as completed
    Toggle commit list
  • Kim Jinsung
    @kim_j started a discussion on commit 8624f482 Aug 20, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/helper/ActivityHandlingHelper.java
    1641 1641 String loginId = ABVDataCache.getInstance().getMemberInfo().loginId;
    1642 1642 String shopName = ABVDataCache.getInstance().getUrlPath();
    1643 1643 intent.putExtra("loginId", loginId);
    • Kim Jinsung @kim_j commented Aug 20, 2021
      Developer

      loginIdもキーにしましょう。

      loginIdもキーにしましょう。
    Please register or sign in to reply
  • onuma @onuma

    added 1 commit

    • 8f8d1e29 - AppDefTypeに、loginId を追加した。

    Compare with previous version

    Aug 20, 2021

    added 1 commit

    • 8f8d1e29 - AppDefTypeに、loginId を追加した。

    Compare with previous version

    added 1 commit * 8f8d1e29 - AppDefTypeに、loginId を追加した。 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/202/diffs?diff_id=6900&start_sha=8624f482a74155f6e60e8ba9a01943c4206a2cb7)
    Toggle commit list
  • Kim Jinsung @kim_j

    marked the task @kim_j as completed

    Aug 20, 2021

    marked the task @kim_j as completed

    marked the task **@kim_j** as completed
    Toggle commit list
  • Kim Jinsung @kim_j

    assigned to @onuma

    Aug 20, 2021

    assigned to @onuma

    assigned to @onuma
    Toggle commit list
  • onuma @onuma

    merged

    Aug 20, 2021

    merged

    merged
    Toggle commit list
  • onuma @onuma

    mentioned in commit adb49f48

    Aug 20, 2021

    mentioned in commit adb49f48

    mentioned in commit adb49f4828c32e6b46843cc58a6815488d228195
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
onuma
Assignee
onuma @onuma
Assign to
None
Milestone
None
Assign milestone
Time tracking
3
3 participants
Reference: abook_android/abook_check!202
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.