Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !222

Merged
Opened Sep 10, 2021 by Kim Jinsung@kim_j 2 of 2 tasks completed2/2 tasks
  • Report abuse
Report abuse

Bug #44365【ABook Communication Android】文書協業接続時、動画や音声再生すると通話音声が聞こえなくなる

Reviewer

LGTMの場合、チェックをしてください。

  • @kim-p
  • @onuma
Edited Sep 12, 2021 by Kim Peace
  • Discussion 2
  • Commits 3
  • Changes 5
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • onuma @onuma

    marked the task @onuma as completed

    Sep 11, 2021

    marked the task @onuma as completed

    marked the task **@onuma** as completed
    Toggle commit list
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Sep 12, 2021
    Last updated by Kim Jinsung Sep 12, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/viewer/activity/ContentViewActivity.java
    5540 5580 operationTaskLayout.setIconStatus(taskKey,false);
    5541 5581 }
    5542 5582
    5583 /**
    5584 * 文書協業接続中の値を返して、接続中にはエラーダイアログ表示
    5585 * @return YES:接続中、NO:非接続
    5586 * */
    5587 public boolean checkConnectedCollaboration() {
    • Kim Peace @kim-p commented Sep 12, 2021
      Master

      [suggestion] checkConnectedCollaboration -> isCollaborationConnected

      [suggestion] `checkConnectedCollaboration` -> `isCollaborationConnected`
    • Kim Jinsung @kim_j

      changed this line in version 2 of the diff

      Sep 12, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/222/diffs?diff_id=7168&start_sha=135ecff880b9f1f94c41b05dd534eab47b1ece42#87e2c2ac1989281cb2693628f4bdad2d95b507c9_5587_5587)
      Toggle commit list
    • Kim Jinsung @kim_j commented Sep 12, 2021
      Developer

      修正しました。

      修正しました。
    Please register or sign in to reply
  • Kim Peace @kim-p

    assigned to @kim_j

    Sep 12, 2021

    assigned to @kim_j

    assigned to @kim_j
    Toggle commit list
  • Kim Peace @kim-p

    marked the task @kim-p as completed

    Sep 12, 2021

    marked the task @kim-p as completed

    marked the task **@kim-p** as completed
    Toggle commit list
  • Kim Jinsung @kim_j

    added 1 commit

    • 551c127d - ソースコードレビュー指摘反映

    Compare with previous version

    Sep 12, 2021

    added 1 commit

    • 551c127d - ソースコードレビュー指摘反映

    Compare with previous version

    added 1 commit * 551c127d - ソースコードレビュー指摘反映 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/222/diffs?diff_id=7168&start_sha=135ecff880b9f1f94c41b05dd534eab47b1ece42)
    Toggle commit list
  • Kim Jinsung @kim_j

    added 1 commit

    • da86f3ab - ソースコード指摘事項反映

    Compare with previous version

    Sep 12, 2021

    added 1 commit

    • da86f3ab - ソースコード指摘事項反映

    Compare with previous version

    added 1 commit * da86f3ab - ソースコード指摘事項反映 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/222/diffs?diff_id=7169&start_sha=551c127df444ffe75326ba5d5d2fef9da5d34db7)
    Toggle commit list
  • Kim Jinsung @kim_j

    merged

    Sep 12, 2021

    merged

    merged
    Toggle commit list
  • Kim Jinsung @kim_j

    mentioned in commit e3de199f

    Sep 12, 2021

    mentioned in commit e3de199f

    mentioned in commit e3de199f0e6d4029191bee3ffe0658285e2c6341
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Kim Jinsung
Assignee
Kim Jinsung @kim_j
Assign to
None
Milestone
None
Assign milestone
Time tracking
3
3 participants
Reference: abook_android/abook_check!222
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.