Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !231

Merged
Opened Sep 13, 2021 by Kim Jinsung@kim_j 2 of 2 tasks completed2/2 tasks
  • Report abuse
Report abuse

Bug #44478【ABook Communication Android】プッシュメッセージ一覧からルーム接続及び協業接続できない。

色々問題点を改善したので確認お願いします。

Reviewer

LGTMの場合、チェックをしてください。

  • @kim-p
  • @onuma
Edited Sep 13, 2021 by onuma
  • Discussion 3
  • Commits 9
  • Changes 9
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kim Peace @kim-p

    marked the task @kim-p as completed

    Sep 13, 2021

    marked the task @kim-p as completed

    marked the task **@kim-p** as completed
    Toggle commit list
  • Kim Peace @kim-p

    assigned to @onuma

    Sep 13, 2021

    assigned to @onuma

    assigned to @onuma
    Toggle commit list
  • onuma
    @onuma started a discussion on an old version of the diff Sep 13, 2021
    Last updated by Kim Jinsung Sep 13, 2021
    ABVJE_BL/src/jp/agentec/abook/abv/bl/logic/OperationLogic.java
    292 292 OperationListJSON json = AcmsClient.getInstance(cache.getUrlPath(), networkAdapter).getOperationList(param);
    293 293 List<OperationDto> serverOperations = json.operationList;
    294 294
    295 //サーバーからチャットプシュデータを取得
    296 if (ABVDataCache.getInstance().serviceOption.isChat()) {
    297 ChatPushDataJSON chatPushJson = AcmsClient.getInstance(cache.getUrlPath(), networkAdapter).getChatPushList(param);
    298 for ( PushMessageDto dto : chatPushJson.pushMessageList) {
    • onuma @onuma commented Sep 13, 2021
      Master

      for ( の後ろの空白を削除してください。

      Edited Sep 13, 2021 by onuma
      for ( の後ろの空白を削除してください。
    • Kim Jinsung @kim_j

      changed this line in version 2 of the diff

      Sep 13, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/231/diffs?diff_id=7180&start_sha=46342f26012a71b2d406e2256a4cf40c1904f1e7#4d20e687e86836a9c38879fd22d0d97543063529_298_298)
      Toggle commit list
    Please register or sign in to reply
  • onuma
    @onuma started a discussion on an old version of the diff Sep 13, 2021
    Last updated by Kim Jinsung Sep 13, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/common/activity/ABVAuthenticatedActivity.java
    971 973 if(dto.roomName != null && dto.roomId != 0)
    972 974 {
    • onuma @onuma commented Sep 13, 2021
      Master

      if(dto.roomName != null && dto.roomId != 0) { 「{」位置を調整してください。

      if(dto.roomName != null && dto.roomId != 0) { 「{」位置を調整してください。
    • Kim Jinsung @kim_j

      changed this line in version 2 of the diff

      Sep 13, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/231/diffs?diff_id=7180&start_sha=46342f26012a71b2d406e2256a4cf40c1904f1e7#e59744bb2eed89bb0481731e7fd3e60b44c4c163_974_973)
      Toggle commit list
    Please register or sign in to reply
  • onuma @onuma

    assigned to @kim_j

    Sep 13, 2021

    assigned to @kim_j

    assigned to @kim_j
    Toggle commit list
  • Kim Jinsung @kim_j

    added 1 commit

    • 1c36fc61 - ソースコード指摘事項反映

    Compare with previous version

    Sep 13, 2021

    added 1 commit

    • 1c36fc61 - ソースコード指摘事項反映

    Compare with previous version

    added 1 commit * 1c36fc61 - ソースコード指摘事項反映 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/231/diffs?diff_id=7180&start_sha=46342f26012a71b2d406e2256a4cf40c1904f1e7)
    Toggle commit list
  • Kim Jinsung @kim_j

    assigned to @onuma

    Sep 13, 2021

    assigned to @onuma

    assigned to @onuma
    Toggle commit list
  • onuma
    @onuma started a discussion on the diff Sep 13, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/common/activity/ABVAuthenticatedActivity.java
    968 970 @Override
    969 971 public void onDetailView(final PushMessageDto dto) {
    970 972
    971 if(dto.roomName != null && dto.roomId != 0)
    972 {
    973 if(dto.roomName != null && dto.roomId != 0) {
    • onuma @onuma commented Sep 13, 2021
      Master

      ) { の間のスペースが多いです。

      ) { の間のスペースが多いです。
    Please register or sign in to reply
  • onuma @onuma

    assigned to @kim_j

    Sep 13, 2021

    assigned to @kim_j

    assigned to @kim_j
    Toggle commit list
  • onuma @onuma

    marked the task @onuma as completed

    Sep 13, 2021

    marked the task @onuma as completed

    marked the task **@onuma** as completed
    Toggle commit list
  • Kim Jinsung @kim_j

    merged

    Sep 13, 2021

    merged

    merged
    Toggle commit list
  • Kim Jinsung @kim_j

    mentioned in commit 569c140c

    Sep 13, 2021

    mentioned in commit 569c140c

    mentioned in commit 569c140cd36ea56d9480947f0fbbbd08caf94180
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Kim Jinsung
Assignee
Kim Jinsung @kim_j
Assign to
None
Milestone
None
Assign milestone
Time tracking
3
3 participants
Reference: abook_android/abook_check!231
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.