Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !258

Merged
Opened Jan 25, 2023 by Kazuyuki Hida@hida-k 
  • Report abuse
Report abuse

Contract/sato/1.0.300 51462

CMSとのAPI変更に対応するための修正です。 インターフェース仕様は、 https://docs.google.com/spreadsheets/d/138sDbHZj9p_qrsvzD1VXLTP7uzcsYfex/edit#gid=1493683248 をご覧ください。

  • Discussion 14
  • Commits 5
  • Changes 9
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Jan 25, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/acms/client/json/OperationListJSON.java
    60 60 public static final String OperationGroupMasterIdList = "operationGroupMasterIdList";
    61 61 public static final String QuickReport = "quickReport";
    62 62
    63 public static final String statusNotStartedCount = "statusNotStartedCount"; //「未実施」数
    64 public static final String statusWorkingCount = "statusWorkingCount"; //「作業中」数
    65 public static final String statusCompletedCount = "statusCompletedCount"; // 「作業完了」数
    66
    • Kazuyuki Hida @hida-k commented Jan 25, 2023
      Developer

      レスポンスにフィールドが追加された分です。

      レスポンスにフィールドが追加された分です。
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Jan 25, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/acms/client/json/OperationListJSON.java
    90 94 dto.enableReportEdit = operationJson.has(EnableReportEdit) ? operationJson.getInt(EnableReportEdit) : 0; // 作業編集区分
    91 95 dto.enableAddReport = operationJson.has(EnableAddReport) ? operationJson.getInt(EnableAddReport) : 0; // 作業追加区分
    92 96 dto.quickReport = operationJson.has(QuickReport) ? operationJson.getInt(QuickReport) : 0;
    97 dto.statusNotStartedCount = operationJson.has(statusNotStartedCount) ? operationJson.getInt(statusNotStartedCount) : 1; //「未実施」数
    98 dto.statusWorkingCount = operationJson.has(statusWorkingCount) ? operationJson.getInt(statusWorkingCount) : 2; //「未実施」数 //「作業中」数
    99 dto.statusCompletedCount = operationJson.has(statusCompletedCount) ? operationJson.getInt(statusCompletedCount) : 3; //「未実施」数 // 「作業完了」数
    93 100
    • Kazuyuki Hida @hida-k commented Jan 25, 2023
      Developer

      レスポンスにフィールドが追加された分です。

      レスポンスにフィールドが追加された分です。
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Jan 25, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/data/DBConnector.java
    19 19 public class DBConnector {
    20 20 private static volatile DBConnector dbConnector = null;
    21 21 public static final String DatabaseName = "ABVJE";
    22 public static final int DatabaseVersion = DatabaseVersions.Ver1_0_3;
    22 public static final int DatabaseVersion = DatabaseVersions.Ver1_0_5;
    23 23
    • Kazuyuki Hida @hida-k commented Jan 25, 2023
      Developer

      DBの修正行いました。

      DBの修正行いました。
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Jan 25, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/data/DatabaseVersions.java
    5 5 public static final int Ver1_0_0 = 1;
    6 6 public static final int Ver1_0_2 = 11; // SATO HACCP 1.0.2
    7 7 public static final int Ver1_0_3 = 21; // @From カテゴリ選択機能追加
    8 public static final int Ver1_0_4 = 31; // @From 作業の進捗状況を追加
    9 public static final int Ver1_0_5 = 41; // @From 作業のロック、差し戻し対応
    10 public static final int Ver1_0_6 = 51; // @From 作業のロック情報を追加
    8 11 }
    • Kazuyuki Hida @hida-k commented Jan 25, 2023
      Developer

      最後に1_0_4に変更分をまとめる予定です。

      最後に1_0_4に変更分をまとめる予定です。
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Jan 25, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/data/dao/TaskReportDao.java
    246 sql.append("AND datetime(report_start_date)=datetime(?);");
    247 }
    248
    249 args.add(reportStatus);
    250 args.add(reportLockUserId);
    251 args.add(reportLockUserName);
    252 args.add(reportLockTime);
    253 args.add(taskKey);
    254 if (reportStartDate != null) {
    255 args.add(reportStartDate);
    256 }
    257
    258 return update(sql.toString(), args.toArray()) > 0;
    259 }
    260
    261 /**
    • Kazuyuki Hida @hida-k commented Jan 25, 2023
      Developer

      報告書ロック機能のためのupdate処理です。

      報告書ロック機能のためのupdate処理です。
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on an old version of the diff Jan 25, 2023
    Last updated by Kazuyuki Hida Jan 25, 2023
    gradle.properties
    37 37 # abvEnvironments.xml
    38 38
    39 39 #cms server
    40 acms_address=https://check.abookcloud.com/acms
    41 download_server_address=https://check.abookcloud.com/acms
    40 #acms_address=https://check.abookcloud.com/acms
    41 #download_server_address=https://check.abookcloud.com/acms
    42 acms_address=https://abook188-1.abook.bz/acms
    43 download_server_address=https://abook188-1.abook.bz/acms
    • Kazuyuki Hida @hida-k commented Jan 25, 2023
      Developer

      サーバーを開発用サーバーに向けました。 マージ先のcontract/sato/1.0.300_devで支障があるようであれば、重ねて修正します(もとに戻します)

      サーバーを開発用サーバーに向けました。 マージ先のcontract/sato/1.0.300_devで支障があるようであれば、重ねて修正します(もとに戻します)
    • Kazuyuki Hida @hida-k

      changed this line in version 2 of the diff

      Jan 25, 2023

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/258/diffs?diff_id=10690&start_sha=c7c962b64c3ea69f917e62e88d070239e280bf31#2afbb999f001938c88fa43fc2ef52abf0f8213e4_43_40)
      Toggle commit list
    Please register or sign in to reply
  • Yujin Seo
    @seo started a discussion on an old version of the diff Jan 25, 2023
    Last updated by Kazuyuki Hida Jan 25, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/acms/client/json/OperationListJSON.java
    90 94 dto.enableReportEdit = operationJson.has(EnableReportEdit) ? operationJson.getInt(EnableReportEdit) : 0; // 作業編集区分
    91 95 dto.enableAddReport = operationJson.has(EnableAddReport) ? operationJson.getInt(EnableAddReport) : 0; // 作業追加区分
    92 96 dto.quickReport = operationJson.has(QuickReport) ? operationJson.getInt(QuickReport) : 0;
    97 dto.statusNotStartedCount = operationJson.has(statusNotStartedCount) ? operationJson.getInt(statusNotStartedCount) : 1; //「未実施」数
    98 dto.statusWorkingCount = operationJson.has(statusWorkingCount) ? operationJson.getInt(statusWorkingCount) : 2; //「未実施」数 //「作業中」数
    99 dto.statusCompletedCount = operationJson.has(statusCompletedCount) ? operationJson.getInt(statusCompletedCount) : 3; //「未実施」数 // 「作業完了」数
    • Yujin Seo @seo commented Jan 25, 2023
      Developer

      : 1 : 2 : 3 ですが。すべて0では?

      : 1 : 2 : 3 ですが。すべて0では?
    • Kazuyuki Hida @hida-k commented Jan 25, 2023
      Developer

      確かにそうですね。

      確かにそうですね。
    • Kazuyuki Hida @hida-k

      changed this line in version 2 of the diff

      Jan 25, 2023

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/258/diffs?diff_id=10690&start_sha=c7c962b64c3ea69f917e62e88d070239e280bf31#8d8c51791f6c1bd665a7b81bc7f0f82448442872_99_97)
      Toggle commit list
    Please register or sign in to reply
  • Yujin Seo
    @seo started a discussion on an old version of the diff Jan 25, 2023
    Last updated by Kazuyuki Hida Jan 25, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/data/dao/TaskReportDao.java
    228 public boolean updateReportLock(
    229 String taskKey,
    230 Date reportStartDate,
    231 int reportStatus,
    232 String reportLockUserId,
    233 String reportLockUserName,
    234 Date reportLockTime
    235 ) {
    236 StringBuilder sql = new StringBuilder();
    237 List<Object> args = new ArrayList<Object>();
    238
    239 sql.append("UPDATE t_task_report SET ");
    240 sql.append(" report_status=?, ");
    241 sql.append(" report_lock_user_id=?, ");
    242 sql.append(" report_lock_user_name=?, ");
    243 sql.append(" report_lock_time=?, ");
    • Yujin Seo @seo commented Jan 25, 2023
      Developer

      report_lock_time=?, ,でSQLエラーになると思います。

      `report_lock_time=?,` ,でSQLエラーになると思います。
    • Kazuyuki Hida @hida-k commented Jan 25, 2023
      Developer

      のちのブランチで直したのかもしれませんが、これから修正します。

      のちのブランチで直したのかもしれませんが、これから修正します。
    • Kazuyuki Hida @hida-k

      changed this line in version 2 of the diff

      Jan 25, 2023

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/258/diffs?diff_id=10690&start_sha=c7c962b64c3ea69f917e62e88d070239e280bf31#64ce84c70d3799bb3e2931ac81f6aa18616da4a1_243_243)
      Toggle commit list
    Please register or sign in to reply
  • Yujin Seo
    @seo started a discussion on an old version of the diff Jan 25, 2023
    Last updated by Kazuyuki Hida Jan 25, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/dto/TaskReportDto.java
    26 26 public String attachedFileName;
    27 27 public boolean localSavedFlg; // 一時保存用
    28 28
    29 public String reportLockUserId = "報告ユーザID"; // 報告ロックユーザId
    30 public String reportLockUserName = "報告ユーザ名"; // 報告ロックユーザ名
    31 public Date reportLockTime = new Date(); // 報告ロック日時
    32 public String sendBackUserId = "差戻ユーザID"; // 差し戻しユーザId 差し戻された場合のみ
    33 public String sendBackUserName = "差戻ユーザ名"; // 差し戻しユーザ名 差し戻された場合のみ
    34 public String sendBackComment = "確認コメント"; // 確認コメント 差し戻された場合のみ
    35 public String taskStatus = "状況:0"; // 状況 0:未実施、1:作業中、999:作業完了
    • Yujin Seo @seo commented Jan 25, 2023
      Developer

      = "報告ユーザID" ・・・ "状況:0" 要らないと思います。

      `= "報告ユーザID"` ・・・ `"状況:0"` 要らないと思います。
    • Kazuyuki Hida @hida-k commented Jan 25, 2023
      Developer

      これは、APIができる前の初期値で、のちのブランチで修正していますが、改めて修正します。

      これは、APIができる前の初期値で、のちのブランチで修正していますが、改めて修正します。
    • Kazuyuki Hida @hida-k

      changed this line in version 2 of the diff

      Jan 25, 2023

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/258/diffs?diff_id=10690&start_sha=c7c962b64c3ea69f917e62e88d070239e280bf31#16065cd6aaee80e67a9a62e4dd01a9b85e2093bf_35_29)
      Toggle commit list
    Please register or sign in to reply
  • Yujin Seo
    @seo started a discussion on an old version of the diff Jan 25, 2023
    Last updated by Kazuyuki Hida Jan 25, 2023
    gradle.properties
    37 37 # abvEnvironments.xml
    38 38
    39 39 #cms server
    40 acms_address=https://check.abookcloud.com/acms
    41 download_server_address=https://check.abookcloud.com/acms
    40 #acms_address=https://check.abookcloud.com/acms
    41 #download_server_address=https://check.abookcloud.com/acms
    42 acms_address=https://abook188-1.abook.bz/acms
    43 download_server_address=https://abook188-1.abook.bz/acms
    • Yujin Seo @seo commented Jan 25, 2023
      Developer

      Jenkinsビルドで上書きされるので変更しても大丈夫ですが。 開発・テスト用変更内容はコミットから外してください。

      Jenkinsビルドで上書きされるので変更しても大丈夫ですが。 開発・テスト用変更内容はコミットから外してください。
    • Kazuyuki Hida @hida-k commented Jan 25, 2023
      Developer

      了解しました。

      了解しました。
    • Kazuyuki Hida @hida-k

      changed this line in version 2 of the diff

      Jan 25, 2023

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/258/diffs?diff_id=10690&start_sha=c7c962b64c3ea69f917e62e88d070239e280bf31#2afbb999f001938c88fa43fc2ef52abf0f8213e4_43_40)
      Toggle commit list
    Please register or sign in to reply
  • Kazuyuki Hida @hida-k

    added 1 commit

    • 93022493 - レビューでの指摘事項を修正。

    Compare with previous version

    Jan 25, 2023

    added 1 commit

    • 93022493 - レビューでの指摘事項を修正。

    Compare with previous version

    added 1 commit * 93022493 - レビューでの指摘事項を修正。 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/258/diffs?diff_id=10690&start_sha=c7c962b64c3ea69f917e62e88d070239e280bf31)
    Toggle commit list
  • Kazuyuki Hida @hida-k

    merged

    Jan 26, 2023

    merged

    merged
    Toggle commit list
  • Kazuyuki Hida @hida-k

    mentioned in commit 76978cd6

    Jan 26, 2023

    mentioned in commit 76978cd6

    mentioned in commit 76978cd6995fdcb46875587f7e39a412c710dc61
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Kazuyuki Hida
Assignee
Kazuyuki Hida @hida-k
Assign to
None
Milestone
None
Assign milestone
Time tracking
2
2 participants
Reference: abook_android/abook_check!258
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.