Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !262

Merged
Opened Jan 27, 2023 by Kazuyuki Hida@hida-k 
  • Report abuse
Report abuse

報告書の排他制御

複数の端末で、同一の報告書を記入することを避けるため、排他制御を行う部分の実装です。

Edited Jan 27, 2023 by Kazuyuki Hida
  • Discussion 24
  • Commits 8
  • Changes 13
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Jan 27, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/acms/client/AcmsClient.java
    719 723 return json;
    720 724 }
    721 725
    726 public LockReportJSON sendLockReport(LockReportParameters param) throws NetworkDisconnectedException, AcmsException {
    727 HttpResponse response = send(AcmsApis.ApiLockReport, param);
    728 String json = response.httpResponseBody;
    729 return new LockReportJSON(json);
    730 }
    731
    732 public UnlockReportJSON sendUnlockReport(UnlockReportParameters param) throws NetworkDisconnectedException, AcmsException {
    733 HttpResponse response = send(AcmsApis.ApiUnlockReport, param);
    734 String json = response.httpResponseBody;
    735 return new UnlockReportJSON(json);
    736 }
    737
    • Kazuyuki Hida @hida-k commented Jan 27, 2023
      Developer

      ロック要求とロック解除のCMSに対するAPI呼び出しを実装しています。

      ロック要求とロック解除のCMSに対するAPI呼び出しを実装しています。
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Jan 27, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/acms/client/AcmsClient.java
    922 938 AcmsApis.ApiUrlNewAppStoreLogin,
    923 939 AcmsApis.ApiUrlAppStoreNewLogin,
    924 940 AcmsApis.ApiGetPushMessages,
    925 AcmsApis.ApiSendPushMessage
    941 AcmsApis.ApiSendPushMessage,
    942 AcmsApis.ApiLockReport,
    943 AcmsApis.ApiUnlockReport
    • Kazuyuki Hida @hida-k commented Jan 27, 2023
      Developer

      API呼び出しにPOSTメソッドを使うものを識別するための配列に、ロックとアンロックを追加しています。

      API呼び出しにPOSTメソッドを使うものを識別するための配列に、ロックとアンロックを追加しています。
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Jan 27, 2023
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/common/activity/ABVContentViewActivity.java
    1084 mTaskKey,
    1085 dateOrNull(abookCheckParam.get("reportStartDate")),
    1086 r.getExtParam().getReportStatus(),
    1087 r.getExtParam().getReportLockUserId(),
    1088 r.getExtParam().getReportLockUserName(),
    1089 r.getExtParam().getReportLockTime()
    1090 );
    1091 // JSコールバック
    1092 afterABookCheckApi(
    1093 mCmd,
    1094 mTaskKey,
    1095 r.getResult(),
    1096 r.getMessage(),
    1097 r.getExtParam().json()
    1098 );
    1099 } else if (mCmd.equals(ABookKeys.CMD_UNLOCK_REPORT)) {
    • Kazuyuki Hida @hida-k commented Jan 27, 2023
      Developer

      API呼び出しとWebViewのJavaScriptへのコールバックを実装しています。 ここについては、最新版では簡潔に見えるように整理されてます。

      API呼び出しとWebViewのJavaScriptへのコールバックを実装しています。 ここについては、最新版では簡潔に見えるように整理されてます。
    Please register or sign in to reply
  • Kazuyuki Hida @hida-k

    unmarked as a Work In Progress

    Jan 27, 2023

    unmarked as a Work In Progress

    unmarked as a **Work In Progress**
    Toggle commit list
  • Kazuyuki Hida @hida-k

    assigned to @seo

    Jan 27, 2023

    assigned to @seo

    assigned to @seo
    Toggle commit list
  • Yujin Seo
    @seo started a discussion on an old version of the diff Jan 27, 2023
    Resolved by Yujin Seo Jan 27, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/acms/client/json/UnlockReportJSON.java 0 → 100644
    24
    25 public int getHttpStatus() {
    26 return httpStatus;
    27 }
    28
    29 public Date getPresentTime() {
    30 return presentTime;
    31 }
    32
    33 public Date getPresentTimeUTC() {
    34 return presentTimeUTC;
    35 }
    36
    37 public int getReportStatus() {return reportStatus; }
    38
    39 private int intOrDef(JSONObject json, String key, int def) {
    • Yujin Seo @seo commented Jan 27, 2023
      Developer

      メソッド名に動詞がありません。 ex) getIntOrDef そしてLockReportJsonと同じメソッドなので AcmsCommon→JSONAcmsJSONParserに追加するか 若しくは共通のクラスを作って継承するのはどうでしょうか?

      Edited Jan 27, 2023
      メソッド名に動詞がありません。 ex) getIntOrDef そしてLockReportJsonと同じメソッドなので AcmsCommon→JSONAcmsJSONParserに追加するか 若しくは共通のクラスを作って継承するのはどうでしょうか?
    • Kazuyuki Hida @hida-k commented Jan 27, 2023
      Developer

      これは、可読性のためだけに作ったメソッド(システムの機能や仕様に影響しない)なので、スコープを最小限に狭めたいために、privateでコピペして使っていました。 同様のメソッドが、JSONAcmsJSONParserで実装されていて、すでに使われているので、それに合わせます。

      Edited Jan 27, 2023
      これは、可読性のためだけに作ったメソッド(システムの機能や仕様に影響しない)なので、スコープを最小限に狭めたいために、privateでコピペして使っていました。 同様のメソッドが、JSONAcmsJSONParserで実装されていて、すでに使われているので、それに合わせます。
    • Kazuyuki Hida @hida-k commented Jan 27, 2023
      Developer

      ただ、最近の認識では、機能の継承は悪手とされているので、すでにJSONAcmsJSONParserを継承しているもの以外では、privateメソッドを選択した方がよい場合もあり得ます。

      Edited Jan 27, 2023
      ただ、最近の認識では、機能の継承は悪手とされているので、すでにJSONAcmsJSONParserを継承しているもの以外では、privateメソッドを選択した方がよい場合もあり得ます。
    • Kazuyuki Hida @hida-k

      changed this line in version 2 of the diff

      Jan 27, 2023

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/262/diffs?diff_id=10710&start_sha=ff4f0eeee1a49fad61bb36abe246d5a215fc21a9#653c2e4475005350fcbfd1aec7117a5d1ddb0ae6_39_42)
      Toggle commit list
    Please register or sign in to reply
  • Yujin Seo
    @seo started a discussion on an old version of the diff Jan 27, 2023
    Resolved by Yujin Seo Jan 27, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/acms/client/json/UnlockReportJSON.java 0 → 100644
    32
    33 public Date getPresentTimeUTC() {
    34 return presentTimeUTC;
    35 }
    36
    37 public int getReportStatus() {return reportStatus; }
    38
    39 private int intOrDef(JSONObject json, String key, int def) {
    40 if (json.has(key)) {
    41 return json.getInt(key);
    42 } else {
    43 return def;
    44 }
    45 }
    46
    47 private Date dateOrNull(JSONObject json, String key) {
    • Yujin Seo @seo commented Jan 27, 2023
      Developer

      メソッド名に動詞がありません。 ex) getDateOrNull そしてLockReportJsonと同じメソッドなので AcmsCommon→JSONAcmsJSONParserに追加するか 若しくは共通のクラスを作って継承するのはどうでしょうか?

      Edited Jan 27, 2023
      メソッド名に動詞がありません。 ex) getDateOrNull そしてLockReportJsonと同じメソッドなので AcmsCommon→JSONAcmsJSONParserに追加するか 若しくは共通のクラスを作って継承するのはどうでしょうか?
    • Kazuyuki Hida @hida-k commented Jan 27, 2023
      Developer

      同上

      Edited Jan 27, 2023
      同上
    • Kazuyuki Hida @hida-k

      changed this line in version 2 of the diff

      Jan 27, 2023

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/262/diffs?diff_id=10710&start_sha=ff4f0eeee1a49fad61bb36abe246d5a215fc21a9#653c2e4475005350fcbfd1aec7117a5d1ddb0ae6_47_42)
      Toggle commit list
    Please register or sign in to reply
  • Yujin Seo
    @seo started a discussion on an old version of the diff Jan 27, 2023
    Resolved by Yujin Seo Jan 27, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/logic/LockReportLogic.java 0 → 100644
    9 import jp.agentec.abook.abv.bl.acms.client.json.LockReportJSON;
    10 import jp.agentec.abook.abv.bl.acms.client.parameters.LockReportParameters;
    11 import jp.agentec.abook.abv.bl.dto.MemberInfoDto;
    12 import jp.agentec.adf.util.DateTimeFormat;
    13 import jp.agentec.adf.util.DateTimeUtil;
    14
    15 import static java.net.HttpURLConnection.HTTP_OK;
    16
    17 public class LockReportLogic extends AbstractLogic {
    18
    19 public static LockReportLogic newInstance() {
    20 return new LockReportLogic();
    21 }
    22
    23 public Result lock(Map<String, String> param) {
    24 Long taskReportId = longOrNull(param.get("taskReportId"));
    • Yujin Seo @seo commented Jan 27, 2023
      Developer

      ABookKeys.TASK_REPORT_IDを使ってください。

      Edited Jan 27, 2023
      ABookKeys.TASK_REPORT_IDを使ってください。
    • Kazuyuki Hida @hida-k commented Jan 27, 2023
      Developer

      了解しました。

      Edited Jan 27, 2023
      了解しました。
    • Kazuyuki Hida @hida-k

      changed this line in version 2 of the diff

      Jan 27, 2023

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/262/diffs?diff_id=10710&start_sha=ff4f0eeee1a49fad61bb36abe246d5a215fc21a9#f763a359385b08e55d6453436ce8055b26ceacb1_24_31)
      Toggle commit list
    Please register or sign in to reply
  • Yujin Seo
    @seo started a discussion on an old version of the diff Jan 27, 2023
    Resolved by Yujin Seo Jan 27, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/logic/LockReportLogic.java 0 → 100644
    10 import jp.agentec.abook.abv.bl.acms.client.parameters.LockReportParameters;
    11 import jp.agentec.abook.abv.bl.dto.MemberInfoDto;
    12 import jp.agentec.adf.util.DateTimeFormat;
    13 import jp.agentec.adf.util.DateTimeUtil;
    14
    15 import static java.net.HttpURLConnection.HTTP_OK;
    16
    17 public class LockReportLogic extends AbstractLogic {
    18
    19 public static LockReportLogic newInstance() {
    20 return new LockReportLogic();
    21 }
    22
    23 public Result lock(Map<String, String> param) {
    24 Long taskReportId = longOrNull(param.get("taskReportId"));
    25 Date reportStartDate = dateOrNull(param.get("reportStartDate"));
    • Yujin Seo @seo commented Jan 27, 2023
      Developer

      ABookKeys.REPORT_START_DATEを使ってください。

      Edited Jan 27, 2023
      ABookKeys.REPORT_START_DATEを使ってください。
    • Kazuyuki Hida @hida-k commented Jan 27, 2023
      Developer

      了解しました。

      Edited Jan 27, 2023
      了解しました。
    • Kazuyuki Hida @hida-k

      changed this line in version 2 of the diff

      Jan 27, 2023

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/262/diffs?diff_id=10710&start_sha=ff4f0eeee1a49fad61bb36abe246d5a215fc21a9#f763a359385b08e55d6453436ce8055b26ceacb1_25_31)
      Toggle commit list
    Please register or sign in to reply
  • Yujin Seo
    @seo started a discussion on an old version of the diff Jan 27, 2023
    Resolved by Yujin Seo Jan 27, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/logic/LockReportLogic.java 0 → 100644
    13 import jp.agentec.adf.util.DateTimeUtil;
    14
    15 import static java.net.HttpURLConnection.HTTP_OK;
    16
    17 public class LockReportLogic extends AbstractLogic {
    18
    19 public static LockReportLogic newInstance() {
    20 return new LockReportLogic();
    21 }
    22
    23 public Result lock(Map<String, String> param) {
    24 Long taskReportId = longOrNull(param.get("taskReportId"));
    25 Date reportStartDate = dateOrNull(param.get("reportStartDate"));
    26
    27 return sendLockReport(
    28 param.get("taskKey"),
    • Yujin Seo @seo commented Jan 27, 2023
      Developer

      ABookKeys.TASK_KEYを使ってください。 作業関連キーは大体ABookKeysやOperationDataJSONにあります。 新キーはABookKeysやOperationDataJSONに追加してください。

      Edited Jan 27, 2023
      ABookKeys.TASK_KEYを使ってください。 作業関連キーは大体ABookKeysやOperationDataJSONにあります。 新キーはABookKeysやOperationDataJSONに追加してください。
    • Kazuyuki Hida @hida-k commented Jan 27, 2023
      Developer

      了解しました。

      Edited Jan 27, 2023
      了解しました。
    • Kazuyuki Hida @hida-k

      changed this line in version 2 of the diff

      Jan 27, 2023

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/262/diffs?diff_id=10710&start_sha=ff4f0eeee1a49fad61bb36abe246d5a215fc21a9#f763a359385b08e55d6453436ce8055b26ceacb1_28_35)
      Toggle commit list
    Please register or sign in to reply
  • Yujin Seo
    @seo started a discussion on an old version of the diff Jan 27, 2023
    Resolved by Yujin Seo Jan 27, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/logic/LockReportLogic.java 0 → 100644
    184 public Date getReportLockTime() {
    185 return reportLockTime;
    186 }
    187
    188 public String json() {
    189 JSONObject extParam = new JSONObject();
    190 extParam.put("reportStatus", String.valueOf(reportStatus));
    191 extParam.put("reportLockUserId", reportLockUserId);
    192 extParam.put("reportLockUserName", reportLockUserName);
    193 extParam.put("reportLockTime", DateTimeUtil.formatDate(reportLockTime, DateTimeFormat.yyyyMMddHHmmssSSS_hyphen));
    194
    195 if (taskReportId != null && taskReportId != 0) {
    196 extParam.put("taskReportId", taskReportId);
    197 }
    198 if (reportStartDate != null) {
    199 extParam.put("reportStartDate", DateTimeUtil.formatDate(reportStartDate, DateTimeFormat.yyyyMMddHHmmssSSS_hyphen));
    • Yujin Seo @seo commented Jan 27, 2023
      Developer

      reportStatusからreportStartDateも上と同じく ABookKeysやOperationDataJSONを参考してください。

      Edited Jan 27, 2023
      `reportStatus`から`reportStartDate`も上と同じく ABookKeysやOperationDataJSONを参考してください。
    • Kazuyuki Hida @hida-k commented Jan 27, 2023
      Developer

      了解しました。

      Edited Jan 27, 2023
      了解しました。
    • Kazuyuki Hida @hida-k

      changed this line in version 2 of the diff

      Jan 27, 2023

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/262/diffs?diff_id=10710&start_sha=ff4f0eeee1a49fad61bb36abe246d5a215fc21a9#f763a359385b08e55d6453436ce8055b26ceacb1_199_207)
      Toggle commit list
    Please register or sign in to reply
  • Yujin Seo
    @seo started a discussion on an old version of the diff Jan 27, 2023
    Resolved by Yujin Seo Jan 27, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/logic/UnlockReportLogic.java 0 → 100644
    14 import jp.agentec.adf.util.DateTimeUtil;
    15
    16 import static java.net.HttpURLConnection.HTTP_OK;
    17
    18 public class UnlockReportLogic extends AbstractLogic {
    19
    20 public static UnlockReportLogic newInstance() {
    21 return new UnlockReportLogic();
    22 }
    23
    24 public Result unlock(Map<String, String> param) {
    25 Long taskReportId = longOrNull(param.get("taskReportId"));
    26 Date reportStartDate = dateOrNull(param.get("reportStartDate"));
    27
    28 return sendUnlockReport(
    29 param.get("taskKey"),
    • Yujin Seo @seo commented Jan 27, 2023
      Developer

      taskReportIdからtaskKeyも上と同じく ABookKeysやOperationDataJSONを参考してください。

      Edited Jan 27, 2023
      `taskReportId`から`taskKey`も上と同じく ABookKeysやOperationDataJSONを参考してください。
    • Kazuyuki Hida @hida-k commented Jan 27, 2023
      Developer

      了解しました。

      Edited Jan 27, 2023
      了解しました。
    • Kazuyuki Hida @hida-k

      changed this line in version 2 of the diff

      Jan 27, 2023

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/262/diffs?diff_id=10710&start_sha=ff4f0eeee1a49fad61bb36abe246d5a215fc21a9#4305e21e3c65b65febdcdc1d2685bebae0adeac5_29_33)
      Toggle commit list
    Please register or sign in to reply
  • Yujin Seo
    @seo started a discussion on an old version of the diff Jan 27, 2023
    Resolved by Yujin Seo Jan 27, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/logic/UnlockReportLogic.java 0 → 100644
    131 this.taskReportId = taskReportId;
    132 this.reportStartDate = reportStartDate;
    133 }
    134
    135 public int getReportStatus() {
    136 return reportStatus;
    137 }
    138
    139 public String json() {
    140 JSONObject extParam = new JSONObject();
    141 extParam.put("reportStatus", String.valueOf(reportStatus));
    142 if (taskReportId != null && taskReportId != 0) {
    143 extParam.put("taskReportId", taskReportId);
    144 }
    145 if (reportStartDate != null) {
    146 extParam.put("reportStartDate", DateTimeUtil.formatDate(reportStartDate, DateTimeFormat.yyyyMMddHHmmssSSS_hyphen));
    • Yujin Seo @seo commented Jan 27, 2023
      Developer

      reportStatusからreportStartDateも上と同じく ABookKeysやOperationDataJSONを参考してください。

      Edited Jan 27, 2023
      `reportStatus`から`reportStartDate`も上と同じく ABookKeysやOperationDataJSONを参考してください。
    • Kazuyuki Hida @hida-k commented Jan 27, 2023
      Developer

      了解しました。

      Edited Jan 27, 2023
      了解しました。
    • Kazuyuki Hida @hida-k

      changed this line in version 2 of the diff

      Jan 27, 2023

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/262/diffs?diff_id=10710&start_sha=ff4f0eeee1a49fad61bb36abe246d5a215fc21a9#4305e21e3c65b65febdcdc1d2685bebae0adeac5_146_151)
      Toggle commit list
    Please register or sign in to reply
  • Yujin Seo
    @seo started a discussion on an old version of the diff Jan 27, 2023
    Resolved by Yujin Seo Jan 27, 2023
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/common/activity/ABVContentViewActivity.java
    1070 1076 // ビーコンデータを受信して目的のデバイスIDの信号から値を取得する
    1071 1077 // 1:中心温度計 2:置くだけセンサー 3:バーコード
    1072 1078 getDeviceInfo(abookCheckParam);
    1073
    1079 } else if (mCmd.equals(ABookKeys.CMD_LOCK_REPORT)) {
    1080 LockReportLogic.Result r = LockReportLogic.newInstance().lock(abookCheckParam);
    1081 // ローカルDBに反映
    1082 TaskReportDao dao = AbstractDao.getDao(TaskReportDao.class);
    1083 dao.updateReportLock(
    1084 mTaskKey,
    1085 dateOrNull(abookCheckParam.get("reportStartDate")),
    • Yujin Seo @seo commented Jan 27, 2023
      Developer

      ABookKeysやOperationDataJSONを参考してください。

      Edited Jan 27, 2023
      ABookKeysやOperationDataJSONを参考してください。
    • Kazuyuki Hida @hida-k commented Jan 27, 2023
      Developer

      了解しました。

      Edited Jan 27, 2023
      了解しました。
    • Kazuyuki Hida @hida-k

      changed this line in version 2 of the diff

      Jan 27, 2023

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/262/diffs?diff_id=10710&start_sha=ff4f0eeee1a49fad61bb36abe246d5a215fc21a9#db2d892a0f815036e6d7af1ba76b645cba2086eb_1085_1087)
      Toggle commit list
    Please register or sign in to reply
  • Yujin Seo
    @seo started a discussion on an old version of the diff Jan 27, 2023
    Resolved by Yujin Seo Jan 27, 2023
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/common/activity/ABVContentViewActivity.java
    1090 );
    1091 // JSコールバック
    1092 afterABookCheckApi(
    1093 mCmd,
    1094 mTaskKey,
    1095 r.getResult(),
    1096 r.getMessage(),
    1097 r.getExtParam().json()
    1098 );
    1099 } else if (mCmd.equals(ABookKeys.CMD_UNLOCK_REPORT)) {
    1100 UnlockReportLogic.Result r = UnlockReportLogic.newInstance().unlock(abookCheckParam);
    1101 // ローカルDBに反映
    1102 TaskReportDao dao = AbstractDao.getDao(TaskReportDao.class);
    1103 dao.updateReportLock(
    1104 mTaskKey,
    1105 dateOrNull(abookCheckParam.get("reportStartDate")),
    • Yujin Seo @seo commented Jan 27, 2023
      Developer

      ABookKeysやOperationDataJSONを参考してください。

      Edited Jan 27, 2023
      ABookKeysやOperationDataJSONを参考してください。
    • Kazuyuki Hida @hida-k commented Jan 27, 2023
      Developer

      了解しました。

      Edited Jan 27, 2023
      了解しました。
    • Kazuyuki Hida @hida-k

      changed this line in version 2 of the diff

      Jan 27, 2023

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/262/diffs?diff_id=10710&start_sha=ff4f0eeee1a49fad61bb36abe246d5a215fc21a9#db2d892a0f815036e6d7af1ba76b645cba2086eb_1105_1107)
      Toggle commit list
    Please register or sign in to reply
  • Kazuyuki Hida @hida-k

    added 2 commits

    • 9638c11e - JSONから値を取り出すユーティリティを集約した
    • 3b6a2e99 - 文字列リテラルを文字列定数に置き換えた

    Compare with previous version

    Jan 27, 2023

    added 2 commits

    • 9638c11e - JSONから値を取り出すユーティリティを集約した
    • 3b6a2e99 - 文字列リテラルを文字列定数に置き換えた

    Compare with previous version

    added 2 commits * 9638c11e - JSONから値を取り出すユーティリティを集約した * 3b6a2e99 - 文字列リテラルを文字列定数に置き換えた [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/262/diffs?diff_id=10710&start_sha=ff4f0eeee1a49fad61bb36abe246d5a215fc21a9)
    Toggle commit list
  • Kazuyuki Hida @hida-k

    added 1 commit

    • 01da32ae - コメントの消し忘れ

    Compare with previous version

    Jan 27, 2023

    added 1 commit

    • 01da32ae - コメントの消し忘れ

    Compare with previous version

    added 1 commit * 01da32ae - コメントの消し忘れ [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/262/diffs?diff_id=10711&start_sha=3b6a2e99bfbad1e4317516a667da4321297ab2ff)
    Toggle commit list
  • Yujin Seo @seo

    assigned to @hida-k

    Jan 27, 2023

    assigned to @hida-k

    assigned to @hida-k
    Toggle commit list
  • Kazuyuki Hida @hida-k

    merged

    Jan 27, 2023

    merged

    merged
    Toggle commit list
  • Kazuyuki Hida @hida-k

    mentioned in commit f381ab70

    Jan 27, 2023

    mentioned in commit f381ab70

    mentioned in commit f381ab7094dc88c5e32e1318fdd848e342297014
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Kazuyuki Hida
Assignee
Kazuyuki Hida @hida-k
Assign to
None
Milestone
None
Assign milestone
Time tracking
2
2 participants
Reference: abook_android/abook_check!262
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.