Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !275

Merged
Opened Feb 07, 2023 by Kazuyuki Hida@hida-k 
  • Report abuse
Report abuse

ロックに使うreportStartDateのタイムゾーンの指定が間違っていたのを修正。

そのため、ロック関係の機能が果たさていないほか、場合によっては、存在しないデータを検索することで404になっていた。

Edited Feb 07, 2023 by Kazuyuki Hida
  • Discussion 3
  • Commits 1
  • Changes 3
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Feb 07, 2023
    Resolved by Yujin Seo Feb 07, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/acms/client/parameters/LockReportParameters.java
    29 29 this.sid = sid;
    30 30 this.taskKey = taskKey;
    31 31 this.taskReportId = taskReportId;
    32 this.reportStartDate = DateTimeUtil.toString(reportStartDate, DateTimeFormat.yyyyMMddHHmmssSSS_hyphen);
    32 this.reportStartDate = DateTimeUtil.toStringInTimeZone(reportStartDate, DateTimeFormat.yyyyMMddHHmmss_hyphen, "UTC");
    • Kazuyuki Hida @hida-k commented Feb 07, 2023
      Developer

      toStringは、デフォルトのタイムゾーンを使っていたが、UTCを使うようにした

      Edited Feb 07, 2023
      toStringは、デフォルトのタイムゾーンを使っていたが、UTCを使うようにした
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Feb 07, 2023
    Resolved by Yujin Seo Feb 07, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/acms/client/parameters/UnlockReportParameters.java
    24 24
    25 25 this.taskKey = taskKey;
    26 26 this.taskReportId = taskReportId;
    27 this.reportStartDate = DateTimeUtil.toString(reportStartDate, DateTimeFormat.yyyyMMddHHmmssSSS_hyphen);
    27 this.reportStartDate = DateTimeUtil.toStringInTimeZone(reportStartDate, DateTimeFormat.yyyyMMddHHmmssSSS_hyphen, "UTC");
    • Kazuyuki Hida @hida-k commented Feb 07, 2023
      Developer

      上と同じ

      Edited Feb 07, 2023
      上と同じ
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Feb 07, 2023
    Resolved by Yujin Seo Feb 07, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/logic/LockReportLogic.java
    20 20 import static jp.agentec.abook.abv.bl.acms.client.json.OperationDataJSON.ReportStartDate;
    21 21 import static jp.agentec.abook.abv.bl.acms.client.json.OperationDataJSON.ReportStatus;
    22 22 import static jp.agentec.abook.abv.bl.acms.client.json.OperationDataJSON.TaskReportId;
    23 import static jp.agentec.abook.abv.bl.common.constant.ABookKeys.TASK_KEY;
    • Kazuyuki Hida @hida-k commented Feb 07, 2023
      Developer

      使われていない定数だったので、削除した。

      Edited Feb 07, 2023
      使われていない定数だったので、削除した。
    Please register or sign in to reply
  • Kazuyuki Hida @hida-k

    assigned to @seo

    Feb 07, 2023

    assigned to @seo

    assigned to @seo
    Toggle commit list
  • Kazuyuki Hida @hida-k

    unmarked as a Work In Progress

    Feb 07, 2023

    unmarked as a Work In Progress

    unmarked as a **Work In Progress**
    Toggle commit list
  • Yujin Seo @seo

    resolved all discussions

    Feb 07, 2023

    resolved all discussions

    resolved all discussions
    Toggle commit list
  • Yujin Seo @seo

    mentioned in commit fa2b2b86

    Feb 07, 2023

    mentioned in commit fa2b2b86

    mentioned in commit fa2b2b86238178e8890908d0b61fe112c52842ed
    Toggle commit list
  • Yujin Seo @seo

    merged

    Feb 07, 2023

    merged

    merged
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Yujin Seo
Assignee
Yujin Seo @seo
Assign to
None
Milestone
None
Assign milestone
Time tracking
2
2 participants
Reference: abook_android/abook_check!275
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.