Skip to content

A
abook_check
Opened by  

ロック要求時は404でもエラーにならないようにした。

新規に作成した報告書を一時保存したとき、ロックの取得に失敗して一覧から開くことができない問題を修正した。

Edited by Kazuyuki Hida
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kazuyuki Hida
    @hida-k started a discussion on the diff
    Resolved by Yujin Seo
    ABVJE_BL/src/jp/agentec/abook/abv/bl/acms/client/AcmsClient.java
    739 739 }
    740 740
    741 741 public LockReportJSON sendLockReport(LockReportParameters param) throws NetworkDisconnectedException, AcmsException {
    742 HttpResponse response = send(AcmsApis.ApiLockReport, param);
    742 HttpResponse response = send(AcmsApis.ApiLockReport, param, true);
    743 743 String json = response.httpResponseBody;
    • Kazuyuki Hida @hida-k commented
      Developer

      かなり階層が深いところで、ステータスコードの判定を行っているため、404を無視するフラグを渡していくようにした。

      Edited
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff
    Resolved by Yujin Seo
    ABVJE_BL/src/jp/agentec/abook/abv/bl/acms/client/AcmsClient.java
    798 798 * @since 1.0.0
    799 799 */
    800 800 private HttpResponse send(String methodName, HttpParameterObject param) throws NetworkDisconnectedException, AcmsException {
    801 return send(methodName, param, false);
    802 }
    803
    804 private HttpResponse send(String methodName, HttpParameterObject param, boolean ignore404) throws NetworkDisconnectedException, AcmsException {
    801 805 Logger.d(TAG, "call api : %s", methodName);
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff
    Resolved by Yujin Seo
    ABVJE_BL/src/jp/agentec/abook/abv/bl/acms/client/AcmsClient.java
    854 862 if (httpTaskThread.response.httpResponseCode == 401 && httpTaskThread.response.httpResponseBody == null) { // 401の場合bodyが取れない場合があるのでvalidationはしない
    855 863 throw new AcmsException(ABVExceptionCode.S_E_ACMS_0401, null);
    856 864 }
    857 if (httpTaskThread.response.httpResponseCode != 304) { // 変更なし
    865 boolean isNot304 = httpTaskThread.response.httpResponseCode != 304; // 変更なし
    866 boolean is404 = httpTaskThread.response.httpResponseCode == 404 && !ignore404;
    867 if (isNot304 && is404) {
    858 868 validateHttpResponse(httpTaskThread.response, methodName);
    859 869 }
    860 870
    • Kazuyuki Hida @hida-k commented
      Developer

      判定に入る条件として、ignore404がtrueなら404でもスキップするようにした。

      Edited
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff
    Resolved by Yujin Seo
    ABVJE_BL/src/jp/agentec/abook/abv/bl/logic/LockReportLogic.java
    98 98 result.result = reportJSON.httpStatus == HTTP_OK || reportJSON.httpStatus == HTTP_NOT_FOUND ? 0 : 1;
    99 99 result.message = "";
    100 100 result.extParam = new ExtParam(
    101 reportJSON.getReportStatus(),
    101 reportJSON.httpStatus == HTTP_OK ? reportJSON.getReportStatus() : 0,
    102 102 reportJSON.getReportLockUserId(),
    • Kazuyuki Hida @hida-k commented
      Developer

      JSに渡すステータスもエラーなしにした。

      Edited
    Please register or sign in to reply
  • Kazuyuki Hida @hida-k

    assigned to @seo

    assigned to @seo

    Toggle commit list
  • Kazuyuki Hida @hida-k

    unmarked as a Work In Progress

    unmarked as a Work In Progress

    Toggle commit list
  • Yujin Seo @seo

    resolved all discussions

    resolved all discussions

    Toggle commit list
  • Yujin Seo @seo

    merged

    merged

    Toggle commit list
  • Yujin Seo @seo

    mentioned in commit 3d173046

    mentioned in commit 3d173046

    Toggle commit list
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment