Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !286

Merged
Opened Feb 17, 2023 by Kazuyuki Hida@hida-k 
  • Report abuse
Report abuse

報告で差戻が反映されない不具合を修正

定期点検の差戻は表示や動作に反映されていたが、報告では一切機能していなかった不具合を修正。 (サーバからの情報が途中で破棄されていた)

Edited Feb 17, 2023 by Kazuyuki Hida
  • Discussion 7
  • Commits 2
  • Changes 7
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Feb 17, 2023
    Resolved by Yujin Seo Feb 17, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/data/dao/ReportStatusDao.java
    79 79 return sql;
    80 80 }
    81 81
    82 public List<ReportStatusDto> getUntouchedReport() {
    82 public List<ReportStatusDto> getNotStartedReport() {
    83 83 StringBuilder sql = reportStatusSql();
    • Kazuyuki Hida @hida-k commented Feb 17, 2023
      Developer

      命名法の揺れを訂正

      Edited Feb 17, 2023
      命名法の揺れを訂正
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Feb 17, 2023
    Resolved by Yujin Seo Feb 17, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/dto/TaskReportDto.java
    85
    86 public static class SendBackInfo {
    87 public final String sendBackUserId;
    88 public final String sendBackUserName;
    89 public final String sendBackComment;
    90
    91 public SendBackInfo(
    92 String sendBackUserId,
    93 String sendBackUserName,
    94 String sendBackComment
    95 ) {
    96 this.sendBackUserId = sendBackUserId;
    97 this.sendBackUserName = sendBackComment;
    98 this.sendBackComment = sendBackComment;
    99 }
    100 }
    • Kazuyuki Hida @hida-k commented Feb 17, 2023
      Developer

      情報を伝達するのに、引数が多すぎになってしまうので、役割によって、グループに分けた。

      Edited Feb 17, 2023
      情報を伝達するのに、引数が多すぎになってしまうので、役割によって、グループに分けた。
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Feb 17, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/logic/OperationLogic.java
    370 public void updateTaskReport(String taskKey, long operationId, long contentId, int taskReportLevel, int enableReport, JSONObject taskReportJson, String localAttachedFileName, boolean attachedChangeFlag, boolean dataSendFlg, boolean localSavedFlg) throws IOException {
    370 public void updateTaskReport(
    371 String taskKey,
    372 long operationId,
    373 long contentId,
    374 int taskReportLevel,
    375 int enableReport,
    376 JSONObject taskReportJson,
    377 String localAttachedFileName,
    378 boolean attachedChangeFlag,
    379 boolean dataSendFlg,
    380 boolean localSavedFlg,
    381 TaskReportDto.SendBackInfo sendBackInfo,
    382 TaskReportDto.LockInfo lockInfo,
    383 int taskStatus
    384 ) throws IOException {
    • Kazuyuki Hida @hida-k commented Feb 17, 2023
      Developer

      末尾に3つ引数を増やした。

      末尾に3つ引数を増やした。
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Feb 17, 2023
    Resolved by Yujin Seo Feb 17, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/logic/OperationLogic.java
    398 412 taskReportDto.localAttachedFileName = localAttachedFileName;
    399 413 }
    400 414
    415 if (sendBackInfo != null) {
    416 taskReportDto.sendBackUserId = sendBackInfo.sendBackUserId;
    417 taskReportDto.sendBackUserName = sendBackInfo.sendBackUserName;
    418 taskReportDto.sendBackComment = sendBackInfo.sendBackComment;
    419 }
    420 if (lockInfo != null) {
    421 taskReportDto.reportLockUserId = lockInfo.reportLockUserId;
    422 taskReportDto.reportLockUserName = lockInfo.reportLockUserName;
    423 taskReportDto.reportLockTime = lockInfo.reportLockTime;
    424 }
    425 taskReportDto.taskStatus = taskStatus;
    426
    • Kazuyuki Hida @hida-k commented Feb 17, 2023
      Developer

      taskReportDtoにロック情報、差し戻し情報、ステータスを転記した

      Edited Feb 17, 2023
      taskReportDtoにロック情報、差し戻し情報、ステータスを転記した
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Feb 17, 2023
    Resolved by Yujin Seo Feb 17, 2023
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/activity/OperationListActivity.java
    1059 mOperationLogic.updateTaskReport(
    1060 serverTaskDto.taskKey,
    1061 operationId,
    1062 operationContentDto.contentId,
    1063 serverTaskReportDto.taskReportLevel,
    1064 serverTaskReportDto.enableReport,
    1065 taskReportJson,
    1066 attachedFileName,
    1067 false,
    1068 false,
    1069 localTaskReportDto.localSavedFlg,
    1070 serverTaskReportDto.getSendBackInfo(),
    1071 serverTaskReportDto.getLockInfo(),
    1072 serverTaskReportDto.taskStatus
    1073 );
    1062 1074 }
    • Kazuyuki Hida @hida-k commented Feb 17, 2023
      Developer

      引数を3つ増やした。 ついでに、見やすいように縦に並べた。

      Edited Feb 17, 2023
      引数を3つ増やした。 ついでに、見やすいように縦に並べた。
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Feb 17, 2023
    Resolved by Yujin Seo Feb 17, 2023
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/helper/ABookCheckWebViewHelper.java
    373 mOperationLogic.updateTaskReport(taskReportDto.taskKey, operationId, contentId, taskReportLevel, Constant.EnableEditReport.YES, taskReportJson, null, attachedChangeFlag, localSavedFlg ? false : true, localSavedFlg);
    373 mOperationLogic.updateTaskReport(
    374 taskReportDto.taskKey,
    375 operationId,
    376 contentId,
    377 taskReportLevel,
    378 Constant.EnableEditReport.YES,
    379 taskReportJson,
    380 null,
    381 attachedChangeFlag,
    382 localSavedFlg ? false : true,
    383 localSavedFlg,
    384 taskReportDto.getSendBackInfo(),
    385 taskReportDto.getLockInfo(),
    386 taskReportDto.taskStatus
    387 );
    • Kazuyuki Hida @hida-k commented Feb 17, 2023
      Developer

      引数を3つ増やした。 ついでに、見やすいように縦に並べた。

      Edited Feb 17, 2023
      引数を3つ増やした。 ついでに、見やすいように縦に並べた。
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Feb 17, 2023
    Resolved by Yujin Seo Feb 17, 2023
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/helper/ABookCheckWebViewHelper.java
    387 );
    374 388 } else {
    375 389 // 登録
    376 mOperationLogic.insertTaskReport(taskKey, operationId, contentId, taskReportLevel, Constant.EnableEditReport.YES, taskReportJson, null, attachedChangeFlag, localSavedFlg ? false : true, localSavedFlg);
    390 mOperationLogic.insertTaskReport(
    391 taskKey,
    392 operationId,
    393 contentId,
    394 taskReportLevel,
    395 Constant.EnableEditReport.YES,
    396 taskReportJson,
    397 null,
    398 attachedChangeFlag,
    399 localSavedFlg ? false : true,
    400 localSavedFlg
    401 );
    • Kazuyuki Hida @hida-k commented Feb 17, 2023
      Developer

      見やすいように縦に並べた。

      Edited Feb 17, 2023
      見やすいように縦に並べた。
    Please register or sign in to reply
  • Kazuyuki Hida @hida-k

    assigned to @seo

    Feb 17, 2023

    assigned to @seo

    assigned to @seo
    Toggle commit list
  • Kazuyuki Hida @hida-k

    unmarked as a Work In Progress

    Feb 17, 2023

    unmarked as a Work In Progress

    unmarked as a **Work In Progress**
    Toggle commit list
  • Yujin Seo @seo

    merged

    Feb 17, 2023

    merged

    merged
    Toggle commit list
  • Yujin Seo @seo

    mentioned in commit 7e9d731c

    Feb 17, 2023

    mentioned in commit 7e9d731c

    mentioned in commit 7e9d731c6705430046267f6c789e1abb1ba4c333
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Yujin Seo
Assignee
Yujin Seo @seo
Assign to
None
Milestone
None
Assign milestone
Time tracking
2
2 participants
Reference: abook_android/abook_check!286
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.