Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !288

Merged
Opened Feb 20, 2023 by Kazuyuki Hida@hida-k 
  • Report abuse
Report abuse

他の端末で登録された報告が未実施扱いになっている不具合を修正

他の端末で追加したデータのレコードをinsertする際、taskStatusが渡されていなかった

Edited Feb 20, 2023 by Kazuyuki Hida
  • Discussion 4
  • Commits 2
  • Changes 3
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Feb 20, 2023
    Resolved by Yujin Seo Feb 20, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/logic/OperationLogic.java
    296 296 * @throws IOException
    297 297 */
    298 public void insertTaskReport(String taskKey, long operationId, long contentId, int reportLevel, int enableReport, JSONObject taskReportJson, String localAttachedFileName, boolean attachedChangeFlag, boolean dataSendFlg, boolean localSavedFlg) throws IOException {
    298 public void insertTaskReport(
    299 String taskKey,
    300 long operationId,
    301 long contentId,
    302 int reportLevel,
    303 int enableReport,
    304 JSONObject taskReportJson,
    305 String localAttachedFileName,
    306 boolean attachedChangeFlag,
    307 boolean dataSendFlg,
    308 boolean localSavedFlg,
    309 int taskStatus
    310 ) throws IOException {
    • Kazuyuki Hida @hida-k commented Feb 20, 2023
      Developer

      見やすいように成形しなおした。

      Edited Feb 20, 2023
      見やすいように成形しなおした。
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Feb 20, 2023
    Resolved by Yujin Seo Feb 20, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/logic/OperationLogic.java
    325 337 if (localAttachedFileName != null) {
    326 338 taskReportDto.localAttachedFileName = localAttachedFileName;
    327 339 }
    340 taskReportDto.taskStatus = taskStatus;
    328 341
    • Kazuyuki Hida @hida-k commented Feb 20, 2023
      Developer

      taskStatusが受け渡されていなかったのを修正

      Edited Feb 20, 2023
      taskStatusが受け渡されていなかったのを修正
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Feb 20, 2023
    Resolved by Yujin Seo Feb 20, 2023
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/activity/OperationListActivity.java
    1053 mOperationLogic.insertTaskReport(serverTaskDto.taskKey, operationId, operationContentDto.contentId,
    1054 serverTaskReportDto.taskReportLevel, serverTaskReportDto.enableReport,
    1055 taskReportJson, attachedFileName, false, false, false);
    1053 mOperationLogic.insertTaskReport(
    1054 serverTaskDto.taskKey,
    1055 operationId,
    1056 operationContentDto.contentId,
    1057 serverTaskReportDto.taskReportLevel,
    1058 serverTaskReportDto.enableReport,
    1059 taskReportJson,
    1060 attachedFileName,
    1061 false,
    1062 false,
    1063 false,
    1064 serverTaskDto.taskStatus);
    1056 1065 } else {
    • Kazuyuki Hida @hida-k commented Feb 20, 2023
      Developer

      他の端末で追加したデータのレコードをinsertする際、taskStatusが渡されていなかった

      Edited Feb 20, 2023
      他の端末で追加したデータのレコードをinsertする際、taskStatusが渡されていなかった
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Feb 20, 2023
    Resolved by Yujin Seo Feb 20, 2023
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/helper/ABookCheckWebViewHelper.java
    397 397 null,
    398 398 attachedChangeFlag,
    399 399 localSavedFlg ? false : true,
    400 localSavedFlg
    400 localSavedFlg,
    401 0
    401 402 );
    • Kazuyuki Hida @hida-k commented Feb 20, 2023
      Developer

      最初にinsertされるときにはtaskStatusが定まっていないので、0を入れておくことにした(のちの処理で阿多が変更される)。

      Edited Feb 20, 2023
      最初にinsertされるときにはtaskStatusが定まっていないので、0を入れておくことにした(のちの処理で阿多が変更される)。
    Please register or sign in to reply
  • Kazuyuki Hida @hida-k

    assigned to @seo

    Feb 20, 2023

    assigned to @seo

    assigned to @seo
    Toggle commit list
  • Kazuyuki Hida @hida-k

    unmarked as a Work In Progress

    Feb 20, 2023

    unmarked as a Work In Progress

    unmarked as a **Work In Progress**
    Toggle commit list
  • Yujin Seo @seo

    resolved all discussions

    Feb 20, 2023

    resolved all discussions

    resolved all discussions
    Toggle commit list
  • Yujin Seo @seo

    merged

    Feb 20, 2023

    merged

    merged
    Toggle commit list
  • Yujin Seo @seo

    mentioned in commit f937c21e

    Feb 20, 2023

    mentioned in commit f937c21e

    mentioned in commit f937c21ed71ece9acad75634a77cd81710fdc60d
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Yujin Seo
Assignee
Yujin Seo @seo
Assign to
None
Milestone
None
Assign milestone
Time tracking
2
2 participants
Reference: abook_android/abook_check!288
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.