Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !302

Merged
Opened Mar 07, 2023 by Kazuyuki Hida@hida-k 
  • Report abuse
Report abuse

Bug #52353 【インターテクノロジー】AbooKCheck 強制終了

詳細は、https://redmine.agentec.jp/issues/52353 を参照してください。

顧客からいただいたログからNullPointerExceptionが発生していることが分かったので、 NullPointerExceptionの発生源にnullチェックを入れました。

他のアプリがフォアグラウンドにきたら、ログの読み込みを停止するという判別に使っている関数なので、nullが現れた場合はfalseを返すようにしました。

×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b features/1.4.411_52353_nullpo origin/features/1.4.411_52353_nullpo

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout features/1.4.412
git merge --no-ff features/1.4.411_52353_nullpo

Step 4. Push the result of the merge to GitLab

git push origin features/1.4.412

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 1
  • Commits 1
  • Changes 1
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Mar 07, 2023
    Resolved by Daichi Sato Mar 10, 2023
    ABVJE_UI_Android/src/jp/agentec/abook/abv/cl/environment/DeviceInfo.java
    85 if (list != null && list.size() > 0) {
    86 ComponentName cn = list.get(0).topActivity;
    87 if (cn != null) {
    88 String name = cn.getPackageName();
    89 if (name != null) {
    90 return name.contains(context.getPackageName());
    91 } else {
    92 Logger.d(TAG, "packageName is null");
    93 }
    94 } else {
    95 Logger.d(TAG, "ComponentName is null");
    96 }
    97 } else {
    98 Logger.d(TAG, "getRunningTasks is empty");
    99 }
    100 return false;
    • Kazuyuki Hida @hida-k commented Mar 07, 2023
      Developer

      nullチェックを挿入

      nullがある場合は、他のアプリがフォアグラウンドになっていると想定して、falseを返すようにしました。

      Edited Mar 10, 2023
      nullチェックを挿入 nullがある場合は、他のアプリがフォアグラウンドになっていると想定して、falseを返すようにしました。
    Please register or sign in to reply
  • Kazuyuki Hida @hida-k

    assigned to @seo

    Mar 07, 2023

    assigned to @seo

    assigned to @seo
    Toggle commit list
  • Yujin Seo @seo

    resolved all discussions

    Mar 07, 2023

    resolved all discussions

    resolved all discussions
    Toggle commit list
  • Yujin Seo @seo

    merged

    Mar 07, 2023

    merged

    merged
    Toggle commit list
  • Yujin Seo @seo

    mentioned in commit 946ba55e

    Mar 07, 2023

    mentioned in commit 946ba55e

    mentioned in commit 946ba55e9cc337ea53941915de81d4eb0c0cb8bf
    Toggle commit list
  • Daichi Sato @sato-d

    resolved all discussions

    Mar 10, 2023

    resolved all discussions

    resolved all discussions
    Toggle commit list
  • Kazuyuki Hida @hida-k

    mentioned in merge request !307 (merged)

    Mar 17, 2023

    mentioned in merge request !307 (merged)

    mentioned in merge request !307
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Yujin Seo
Assignee
Yujin Seo @seo
Assign to
None
Milestone
None
Assign milestone
Time tracking
3
3 participants
Reference: abook_android/abook_check!302
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.