Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !306

Merged
Opened Mar 16, 2023 by Kazuyuki Hida@hida-k 
  • Report abuse
Report abuse

一時保存の作業を再度開いたときに、DBの内容をロックが成功した状態にしてしまっていたのを修正。

【@Formフジフーズ CMS 1.3.0】一時保存後にロックが残っている https://redmine.agentec.jp/issues/52488

↑ これを修正。

原因は、一時保存されていた報告にロックをかけようとしたとき、CMSから404が返ってくるが、それを成功とみなすという仕様だったので、ロックをかけてしまっていた。

Edited Mar 16, 2023 by Kazuyuki Hida
×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feature/contract/sato/1.0.300_52488_lock origin/feature/contract/sato/1.0.300_52488_lock

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout contract/sato/1.0.300
git merge --no-ff feature/contract/sato/1.0.300_52488_lock

Step 4. Push the result of the merge to GitLab

git push origin contract/sato/1.0.300

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 2
  • Commits 2
  • Changes 1
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Mar 16, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/logic/LockReportLogic.java
    114 null,
    115 taskReportId,
    116 reportStartDate
    117 );
    118 } else {
    119 result.result = 1;
    120 result.message = "";
    121 result.extParam = new ExtParam(
    122 0,
    123 null,
    124 null,
    125 null,
    126 taskReportId,
    127 reportStartDate
    128 );
    129 }
    • Kazuyuki Hida @hida-k commented Mar 16, 2023
      Developer

      OKの時とNOT_FOUNDの時とその他の時で、処理を分けました。 NOT_FOUNDの時は、結果(result)は成功(0)でも、ロック情報がDBに入らないようにしています。

      OKの時とNOT_FOUNDの時とその他の時で、処理を分けました。 NOT_FOUNDの時は、結果(result)は成功(0)でも、ロック情報がDBに入らないようにしています。
    Please register or sign in to reply
  • Kazuyuki Hida @hida-k

    added 1 commit

    • 247309b2 - CMSサーバのホストを開発環境用に戻した。

    Compare with previous version

    Mar 16, 2023

    added 1 commit

    • 247309b2 - CMSサーバのホストを開発環境用に戻した。

    Compare with previous version

    added 1 commit * 247309b2 - CMSサーバのホストを開発環境用に戻した。 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/306/diffs?diff_id=11121&start_sha=870267ce55f8b0501b566f485fcf2899cd898dd8)
    Toggle commit list
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Mar 16, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/logic/LockReportLogic.java
    72 ExtParam extParam
    73 73 ) {
    74 MemberInfoDto member = cache.getMemberInfo();
    75 74 TaskReportDao dao = AbstractDao.getDao(TaskReportDao.class);
    76 75 dao.updateReportLock(
    77 76 taskKey,
    78 77 taskReportId,
    79 78 reportStartDate,
    80 reportStatus,
    81 member.loginId,
    82 member.memberName,
    83 new Date()
    79 extParam.reportStatus,
    80 extParam.reportLockUserId,
    81 extParam.reportLockUserName,
    82 extParam.reportLockTime
    • Kazuyuki Hida @hida-k commented Mar 16, 2023
      Developer

      DBに格納する値をextParamからとるようにしました。

      DBに格納する値をextParamからとるようにしました。
    Please register or sign in to reply
  • Kazuyuki Hida @hida-k

    assigned to @seo

    Mar 16, 2023

    assigned to @seo

    assigned to @seo
    Toggle commit list
  • Kazuyuki Hida @hida-k

    changed the description

    Mar 16, 2023

    changed the description

    changed the description
    Toggle commit list
  • Yujin Seo @seo

    mentioned in commit c3c89a45

    Mar 16, 2023

    mentioned in commit c3c89a45

    mentioned in commit c3c89a4544511a89624944a39e36c975aa401a32
    Toggle commit list
  • Yujin Seo @seo

    merged

    Mar 16, 2023

    merged

    merged
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Yujin Seo
Assignee
Yujin Seo @seo
Assign to
None
Milestone
None
Assign milestone
Time tracking
2
2 participants
Reference: abook_android/abook_check!306
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.