Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !311

Merged
Opened Apr 04, 2023 by Kazuyuki Hida@hida-k 
  • Report abuse
Report abuse

Java8依存のコードを代替コードに変更

具体的には、

  • BASE64
  • Map#getOrDefault
  • Discussion 7
  • Commits 3
  • Changes 4
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Apr 04, 2023
    Resolved by Yujin Seo Apr 04, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/common/util/Base64.java 0 → 100644
    1 // Portions copyright 2002, Google, Inc.
    2 //
    3 // Licensed under the Apache License, Version 2.0 (the "License");
    4 // you may not use this file except in compliance with the License.
    5 // You may obtain a copy of the License at
    6 //
    7 // http://www.apache.org/licenses/LICENSE-2.0
    8 //
    9 // Unless required by applicable law or agreed to in writing, software
    10 // distributed under the License is distributed on an "AS IS" BASIS,
    11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    12 // See the License for the specific language governing permissions and
    13 // limitations under the License.
    14
    • Kazuyuki Hida @hida-k commented Apr 04, 2023
      Developer

      Googleが配布している課金処理サンプルで使われているものをコピーしました。

      Edited Apr 04, 2023
      Googleが配布している課金処理サンプルで使われているものをコピーしました。
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Apr 04, 2023
    Resolved by Yujin Seo Apr 04, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/common/util/Base64DecoderException.java 0 → 100644
    1 // Copyright 2002, Google, Inc.
    2 //
    3 // Licensed under the Apache License, Version 2.0 (the "License");
    4 // you may not use this file except in compliance with the License.
    5 // You may obtain a copy of the License at
    6 //
    7 // http://www.apache.org/licenses/LICENSE-2.0
    8 //
    9 // Unless required by applicable law or agreed to in writing, software
    10 // distributed under the License is distributed on an "AS IS" BASIS,
    11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    12 // See the License for the specific language governing permissions and
    13 // limitations under the License.
    14
    • Kazuyuki Hida @hida-k commented Apr 04, 2023
      Developer

      Googleが配布している課金処理サンプルで使われているものをコピーしました。

      Edited Apr 04, 2023
      Googleが配布している課金処理サンプルで使われているものをコピーしました。
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Apr 04, 2023
    Resolved by Yujin Seo Apr 04, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/data/dao/TaskReportDao.java
    616 616 if (plain == null) {
    617 617 return null;
    618 618 }
    619 return Base64.getEncoder().encodeToString(plain.getBytes());
    619 return jp.agentec.abook.abv.bl.common.util.Base64.encode(plain.getBytes());
    • Kazuyuki Hida @hida-k commented Apr 04, 2023
      Developer

      java.util.Base64を置き換えました

      Edited Apr 04, 2023
      java.util.Base64を置き換えました
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Apr 04, 2023
    Resolved by Yujin Seo Apr 04, 2023
    ABVJE_BL/src/jp/agentec/abook/abv/bl/data/dao/TaskReportDao.java
    618 618 }
    619 return Base64.getEncoder().encodeToString(plain.getBytes());
    619 return jp.agentec.abook.abv.bl.common.util.Base64.encode(plain.getBytes());
    620 620 }
    621 621
    622 622 public static String decode(String encoded) {
    623 623 if (encoded == null) {
    624 624 return null;
    625 625 }
    626 return new String(Base64.getDecoder().decode(encoded));
    626 try {
    627 return new String(jp.agentec.abook.abv.bl.common.util.Base64.decode(encoded));
    628 } catch (Base64DecoderException e) {
    629 Logger.e(TAG, e);
    630 return null;
    631 }
    • Kazuyuki Hida @hida-k commented Apr 04, 2023
      Developer

      java.util.Base64を置き換えました

      Edited Apr 04, 2023
      java.util.Base64を置き換えました
    Please register or sign in to reply
  • Kazuyuki Hida
    @hida-k started a discussion on the diff Apr 04, 2023
    Resolved by Yujin Seo Apr 04, 2023
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/helper/ABookCheckWebViewHelper.java
    632
    633 private String getOrZero(Map<String, String> param, String key) {
    634 if (param.containsKey(key)) {
    635 return param.get(key);
    636 } else {
    637 return "0";
    638 }
    639 }
    640
    641 private String getOrNull(Map<String, String> param, String key) {
    642 if (param.containsKey(key)) {
    643 return param.get(key);
    644 } else {
    645 return null;
    646 }
    647 }
    • Kazuyuki Hida @hida-k commented Apr 04, 2023
      Developer

      .getOrDefaultが使えないので、大体処理を使用しました。

      Edited Apr 04, 2023
      `.getOrDefault`が使えないので、大体処理を使用しました。
    Please register or sign in to reply
  • Kazuyuki Hida @hida-k

    assigned to @seo

    Apr 04, 2023

    assigned to @seo

    assigned to @seo
    Toggle commit list
  • Yujin Seo @seo

    resolved all discussions

    Apr 04, 2023

    resolved all discussions

    resolved all discussions
    Toggle commit list
  • Yujin Seo
    @seo started a discussion on an old version of the diff Apr 04, 2023
    Last updated by Kazuyuki Hida Apr 04, 2023
    gradle.properties
    39 39 #cms server
    40 40 #acms_address=https://check.abookcloud.com/acms
    41 41 #download_server_address=https://check.abookcloud.com/acms
    42 acms_address=https://abook188-1.abook.bz/acms
    43 download_server_address=https://abook188-1.abook.bz/acms
    42 #acms_address=https://abook188-1.abook.bz/acms
    43 #download_server_address=https://abook188-1.abook.bz/acms
    44 44 #acms_address=http://10.0.2.2:8080/acms
    45 45 #download_server_address=http://10.0.2.2:8080/acms
    46 acms_address=https://atform.sato.co.jp//acms
    47 download_server_address=https://atform.sato.co.jp//acms
    • Yujin Seo @seo commented Apr 04, 2023
      Developer

      ダブルスラッシュ(//)が複数見えます。 修正お願いします。

      ダブルスラッシュ(//)が複数見えます。 修正お願いします。
    • Kazuyuki Hida @hida-k

      changed this line in version 2 of the diff

      Apr 04, 2023

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/311/diffs?diff_id=11224&start_sha=81ccb2041c26377974cda8d5faabdbc550ed2c94#2afbb999f001938c88fa43fc2ef52abf0f8213e4_47_46)
      Toggle commit list
    Please register or sign in to reply
  • Yujin Seo
    @seo started a discussion on an old version of the diff Apr 04, 2023
    Last updated by Kazuyuki Hida Apr 04, 2023
    gradle.properties
    41 41 #download_server_address=https://check.abookcloud.com/acms
    42 acms_address=https://abook188-1.abook.bz/acms
    43 download_server_address=https://abook188-1.abook.bz/acms
    42 #acms_address=https://abook188-1.abook.bz/acms
    43 #download_server_address=https://abook188-1.abook.bz/acms
    44 44 #acms_address=http://10.0.2.2:8080/acms
    45 45 #download_server_address=http://10.0.2.2:8080/acms
    46 acms_address=https://atform.sato.co.jp//acms
    47 download_server_address=https://atform.sato.co.jp//acms
    48
    46 49
    47 50 #syncview server
    48 websocket_server_http_url=https://abook188-1.abook.bz/v1
    49 websocket_server_ws_url=wss://abook188-1.abook.bz/v1
    51 websocket_server_http_url=https://atform.sato.co.jp//v1
    52 websocket_server_ws_url=wss://atform.sato.co.jp//v1
    • Yujin Seo @seo commented Apr 04, 2023
      Developer

      ダブルスラッシュ(//)が複数見えます。 修正お願いします。

      ダブルスラッシュ(//)が複数見えます。 修正お願いします。
    • Kazuyuki Hida @hida-k

      changed this line in version 2 of the diff

      Apr 04, 2023

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/311/diffs?diff_id=11224&start_sha=81ccb2041c26377974cda8d5faabdbc550ed2c94#2afbb999f001938c88fa43fc2ef52abf0f8213e4_52_49)
      Toggle commit list
    Please register or sign in to reply
  • Kazuyuki Hida @hida-k

    added 1 commit

    • b9adac3e - サーバURLを元に戻した。

    Compare with previous version

    Apr 04, 2023

    added 1 commit

    • b9adac3e - サーバURLを元に戻した。

    Compare with previous version

    added 1 commit * b9adac3e - サーバURLを元に戻した。 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/311/diffs?diff_id=11224&start_sha=81ccb2041c26377974cda8d5faabdbc550ed2c94)
    Toggle commit list
  • Kazuyuki Hida @hida-k

    added 1 commit

    • f32439b4 - サーバURLを元に戻した。

    Compare with previous version

    Apr 04, 2023

    added 1 commit

    • f32439b4 - サーバURLを元に戻した。

    Compare with previous version

    added 1 commit * f32439b4 - サーバURLを元に戻した。 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/311/diffs?diff_id=11225&start_sha=b9adac3eaaf5a8b507dac7c39062120589f23635)
    Toggle commit list
  • Yujin Seo @seo

    merged

    Apr 04, 2023

    merged

    merged
    Toggle commit list
  • Yujin Seo @seo

    mentioned in commit ab8a8a47

    Apr 04, 2023

    mentioned in commit ab8a8a47

    mentioned in commit ab8a8a47baccdcd0b16b9f958ea3fd27e6dcebb3
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Yujin Seo
Assignee
Yujin Seo @seo
Assign to
None
Milestone
None
Assign milestone
Time tracking
2
2 participants
Reference: abook_android/abook_check!311
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.