Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !77

Closed
Opened Dec 10, 2020 by Lee Munkyeong@lee-mk 
  • Report abuse
Report abuse

add placeholder on state not connected network

#29

Edited Dec 10, 2020 by Lee Munkyeong
  • Discussion 3
  • Commits 2
  • Changes 168
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Lee Munkyeong @lee-mk

    changed the description

    Dec 10, 2020

    changed the description

    changed the description
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @kim-p

    Dec 10, 2020

    assigned to @kim-p

    assigned to @kim-p
    Toggle commit list
  • Lee Munkyeong @lee-mk

    added 1 commit

    • 2a9820a8 - Modifying error page design

    Compare with previous version

    Dec 10, 2020

    added 1 commit

    • 2a9820a8 - Modifying error page design

    Compare with previous version

    added 1 commit * 2a9820a8 - Modifying error page design [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/77/diffs?diff_id=4509&start_sha=5d03c9e5afa63d0a2bc7e3e723a25678e505dcbf)
    Toggle commit list
  • Kim Peace
    @kim-p started a discussion on the diff Dec 11, 2020
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/activity/ChatWebviewActivity.java
    75 75 @Override
    76 76 protected void onCreate(Bundle savedInstanceState) {
    77 77 super.onCreate(savedInstanceState);
    78
    79 78 if (isNormalSize()) {
    80 79 setPortraitIfNormal();
    81 80 }
    82
    83 81 setContentView(R.layout.chat_webview);
    84 82 Intent intent = getIntent();
    85 chatWebviewUrl = intent.getStringExtra("chatWebviewUrl");
    83 //ネットワークがない場合専用のページを表示。
    84 if(ABVEnvironment.getInstance().networkAdapter.isNetworkConnected()){
    • Kim Peace @kim-p commented Dec 11, 2020
      Master

      [nits] ifと(の間、 )と{の間にはスペースを開けてください。

      // notpreferred
      if(condition){
          // ...
      }
      // preferred
      if (condition) {
          // ...
      }
      [nits] ifと(の間、 )と{の間にはスペースを開けてください。 ```java // notpreferred if(condition){ // ... } // preferred if (condition) { // ... } ```
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on the diff Dec 11, 2020
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/activity/ChatWebviewActivity.java
    75 75 @Override
    76 76 protected void onCreate(Bundle savedInstanceState) {
    77 77 super.onCreate(savedInstanceState);
    78
    79 78 if (isNormalSize()) {
    80 79 setPortraitIfNormal();
    81 80 }
    82
    83 81 setContentView(R.layout.chat_webview);
    84 82 Intent intent = getIntent();
    85 chatWebviewUrl = intent.getStringExtra("chatWebviewUrl");
    83 //ネットワークがない場合専用のページを表示。
    84 if(ABVEnvironment.getInstance().networkAdapter.isNetworkConnected()){
    85 chatWebviewUrl = intent.getStringExtra("chatWebviewUrl");
    86 }else{
    • Kim Peace @kim-p commented Dec 11, 2020
      Master

      [nits]

      // not preferred
      }else{
      // preferred
      } else {
      [nits] ```java // not preferred }else{ // preferred } else { ```
    Please register or sign in to reply
  • Kim Peace @kim-p commented Dec 14, 2020
    Master

    Please seperate this mr by its feature.

    Please seperate this mr by its feature.
  • Kim Peace @kim-p

    assigned to @lee-mk

    Dec 14, 2020

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Munkyeong @lee-mk

    closed

    Dec 14, 2020

    closed

    closed
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Lee Munkyeong
Assignee
Lee Munkyeong @lee-mk
Assign to
None
Milestone
None
Assign milestone
Time tracking
2
2 participants
Reference: abook_android/abook_check!77