Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !79

Merged
Opened Dec 11, 2020 by Lee Munkyeong@lee-mk 
  • Report abuse
Report abuse

Features/#29 2/add src file

  • Discussion 3
  • Commits 3
  • Changes 4
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Dec 14, 2020
    Resolved by Lee Munkyeong Dec 16, 2020
    ABVJE_Launcher_Android/assets/chat/public/js/chat-error.js 0 → 100644
    1 jQuery('#homeButton').on('click', function() {
    2 if (CHAT_UTIL.isIOS()) {
    3 //TODO IOS処理追加必要。
    4 } else if (CHAT_UTIL.isAndroid()) {
    5 android.goHome();
    6 }
    7 });
    8
    9 jQuery('#reloadButton').on('click', function() {
    10 if (CHAT_UTIL.isIOS()) {
    • Kim Peace @kim-p commented Dec 14, 2020
      Master

      [nits] indent?

      [nits] indent?
    • Lee Munkyeong @lee-mk

      changed this line in version 2 of the diff

      Dec 16, 2020

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/79/diffs?diff_id=4528&start_sha=1b254b6e4195b2ed3fdf6fad615e0bc3b23cdcf1#0658f91cd3ca442e4d478b45602bd855391d48ac_10_10)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Dec 14, 2020
    Resolved by Lee Munkyeong Dec 16, 2020
    ABVJE_Launcher_Android/assets/chat/public/js/chat-error.js 0 → 100644
    1 jQuery('#homeButton').on('click', function() {
    2 if (CHAT_UTIL.isIOS()) {
    • Kim Peace @kim-p commented Dec 14, 2020
      Master

      [nits] indent?

      [nits] indent?
    • Lee Munkyeong @lee-mk

      changed this line in version 2 of the diff

      Dec 16, 2020

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/79/diffs?diff_id=4528&start_sha=1b254b6e4195b2ed3fdf6fad615e0bc3b23cdcf1#0658f91cd3ca442e4d478b45602bd855391d48ac_2_2)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace @kim-p commented Dec 14, 2020
    Master

    looks good but 2 indent nits, then you can be merge I thnk

    looks good but 2 indent nits, then you can be merge I thnk
  • Kim Peace @kim-p

    assigned to @lee-mk

    Dec 14, 2020

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Munkyeong @lee-mk

    added 1 commit

    • 72a92316 - fix indent

    Compare with previous version

    Dec 16, 2020

    added 1 commit

    • 72a92316 - fix indent

    Compare with previous version

    added 1 commit * 72a92316 - fix indent [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/79/diffs?diff_id=4528&start_sha=1b254b6e4195b2ed3fdf6fad615e0bc3b23cdcf1)
    Toggle commit list
  • Lee Munkyeong @lee-mk

    resolved all discussions

    Dec 16, 2020

    resolved all discussions

    resolved all discussions
    Toggle commit list
  • Lee Munkyeong @lee-mk

    mentioned in commit ce86c42e

    Dec 16, 2020

    mentioned in commit ce86c42e

    mentioned in commit ce86c42e9e9e164b1c5547f7b55b193ee3cfd0a7
    Toggle commit list
  • Lee Munkyeong @lee-mk

    merged

    Dec 16, 2020

    merged

    merged
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Lee Munkyeong
Assignee
Lee Munkyeong @lee-mk
Assign to
None
Milestone
None
Assign milestone
Time tracking
2
2 participants
Reference: abook_android/abook_check!79
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.