Features/1.2.360 develop abcomm 265 offline対応
- Kim peace
- Kang donghun
- Lee daehyun
- Jung kwangkyu
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
marked the task Lee daehyun as completed
Toggle commit list -
-
resolved all discussions
Toggle commit list -
-
marked the task Kang donghun as completed
Toggle commit list -
27 private static final String ShopMemberId = "shopMemberId"; 28 private static final String MessageType = "messageType"; 29 private static final String UnreadCount = "unreadCount"; 30 private static final String AttendUsers = "attendUsers"; 31 32 public ArrayList<ChatRoomDto> roomList; 33 34 public RoomListJSON(String jsonString) throws AcmsException { 35 super(jsonString); 36 } 37 38 @Override 39 protected void parse(JSONObject json) throws JSONValidationException { 40 41 // ルーム一覧情報を取得 42 if (json.has(Body)) { -
Master
[nits]
// not preferred if (...) { ... if (...) { ... } } // preferred if (...) { return; } ... if (...) { return; } ... -
-
-
3 import java.util.Date; 4 5 public class ChatMessageDto extends AbstractDto { 6 public Integer chatMessageId; 7 public Integer chatRoomId; 8 public Integer shopMemberId; 9 public String message; 10 public Integer messageType; 11 public String imageName; 12 public String downloadFileName; 13 public String savePath; 14 public String insertDate; 15 16 @Override 17 public Object[] getInsertValues() { 18 Object[] test = new Object[]{chatMessageId, chatRoomId, shopMemberId, message, messageType, imageName, downloadFileName, savePath, insertDate}; -
Master
[nits]
testをもう使わないなら、削除お願いします。 -
-
-
14 public String insertDate; 15 16 @Override 17 public Object[] getInsertValues() { 18 Object[] test = new Object[]{chatMessageId, chatRoomId, shopMemberId, message, messageType, imageName, downloadFileName, savePath, insertDate}; 19 return new Object[]{chatMessageId, chatRoomId, shopMemberId, message, messageType, imageName, downloadFileName, savePath, insertDate}; 20 } 21 22 @Override 23 public Object[] getUpdateValues() { 24 return new Object[]{chatRoomId, shopMemberId, message, messageType, imageName, downloadFileName, savePath, insertDate, chatMessageId}; 25 } 26 27 @Override 28 public String[] getKeyValues() { 29 return new String[]{""+ chatMessageId}; -
Master
[nits]
+は前後ともにスペースを空けてください。 -
-
-
230 230 } 231 231 CHAT_UI.htmlElementTextInitialize(languageCode) 232 232 233 socket.emit('join', loginParam, function (err) { 234 if (err) { 235 // #36174 236 $("#customAlertTitle").text(err); 237 $("#customAlertOk").text(getLocalizedString("yesTitle")); 238 239 $('#customAlert').appendTo("body").modal({ 240 backdrop: 'static', 241 keyboard: false 242 }) 243 .on('click', '#customAlertOk', function(e) { 244 }); 233 if (IS_ONLINE == 'true') { -
Master
indent?
-
-
-
247 } else { 248 console.log('No error'); 249 if (loginParam.roomName != undefined && loginParam.roomName != "null") { 250 $('.titleRoomName').text(loginParam.roomName).data('roomName', loginParam.roomName); 251 } else { 252 // 設定されていたroomNameがない場合 253 let roomListTitle = getLocalizedString("roomListTitle") 254 $('.titleRoomName').text(roomListTitle).data('roomName', roomListTitle); 255 } 256 } 257 // loadingIndicatorを表示しない 258 CHAT_UI.dismissLoadingIndicator(); 259 }); 260 } else { 261 // loadingIndicatorを表示しない 262 CHAT_UI.dismissLoadingIndicator(); -
Master
indent?
-
-
-
marked the task Jung kwangkyu as completed
Toggle commit list -
-
merged
Toggle commit list
