Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !97

Merged
Opened Apr 07, 2021 by Lee Munkyeong@lee-mk 3 of 3 tasks completed3/3 tasks
  • Report abuse
Report abuse

動画のフールスクリーンモード追加。

  • @kim-p
  • @lee-dh
  • @kang-dh
Edited Apr 08, 2021 by Kang Donghun
  • Discussion 5
  • Commits 3
  • Changes 5
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Lee Daehyun @lee-dh

    marked the task @lee-dh as completed

    Apr 07, 2021

    marked the task @lee-dh as completed

    marked the task **@lee-dh** as completed
    Toggle commit list
  • Lee Daehyun @lee-dh

    assigned to @lee-mk

    Apr 07, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @kang-dh

    Apr 07, 2021

    assigned to @kang-dh

    assigned to @kang-dh
    Toggle commit list
  • Kang Donghun
    @kang-dh started a discussion on an old version of the diff Apr 08, 2021
    Resolved by Kang Donghun Apr 08, 2021
    ABVJE_BL/src/jp/agentec/abook/abv/bl/data/dao/GroupDao.java
    565 565 public List<GroupDto> getUserGroups() {
    566 566 return rawQueryGetDtoList("select * from m_group where user_group_flg = 1 ORDER BY group_name", null, GroupDto.class);
    567 567 }
    568
    568
    569 public List<GroupDto> geMyGroups() {
    570 return rawQueryGetDtoList("select * from m_group where group_id IN (select group_id from m_shop_member sm inner join r_shop_member_group rmg on sm.shop_member_id = rmg.shop_member_id where sm.self_flg = 1) ORDER BY group_name", null, GroupDto.class);
    • Kang Donghun @kang-dh commented Apr 08, 2021
      Developer

      [ask] ORDER BY のvalueは入力しなくてもいいですか?

      ex) DESC, ASC

      Edited Apr 08, 2021 by Kang Donghun
      [ask] ORDER BY のvalueは入力しなくてもいいですか? ex) DESC, ASC
    • Lee Munkyeong @lee-mk

      changed this line in version 2 of the diff

      Apr 08, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/97/diffs?diff_id=5764&start_sha=842169d8cb0748a087111f92b7c14c66eaaa7d5f#41568e3efb70aba10829a16122bf6356ba16aeeb_570_569)
      Toggle commit list
    • Lee Munkyeong @lee-mk commented Apr 08, 2021
      Developer

      デフォルト値はASCですが入力した方が見やすいので修正しました。

      デフォルト値はASCですが入力した方が見やすいので修正しました。
    Please register or sign in to reply
  • Kang Donghun
    @kang-dh started a discussion on an old version of the diff Apr 08, 2021
    Resolved by Lee Munkyeong Apr 08, 2021
    ABVJE_BL/src/jp/agentec/abook/abv/bl/logic/CommunicationLogic.java
    179 179 }
    180 180
    181 181 public String getMyGroupUsers() {
    182 List<GroupDto> myGroupIds = groupDao.getUserGroups();
    182 List<GroupDto> myGroupIds = groupDao.geMyGroups();
    • Kang Donghun @kang-dh commented Apr 08, 2021
      Developer

      geMyGroups -> getMyGroups

      Edited Apr 08, 2021
      `geMyGroups` -> `getMyGroups`
    • Lee Munkyeong @lee-mk

      changed this line in version 2 of the diff

      Apr 08, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/97/diffs?diff_id=5764&start_sha=842169d8cb0748a087111f92b7c14c66eaaa7d5f#9dade916e7e6e24d1df91b7df12a428931b7a74c_182_182)
      Toggle commit list
    Please register or sign in to reply
  • Kang Donghun @kang-dh

    assigned to @lee-mk

    Apr 08, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Kang Donghun
    @kang-dh started a discussion on an old version of the diff Apr 08, 2021
    Resolved by Lee Munkyeong Apr 08, 2021
    ABVJE_BL/src/jp/agentec/abook/abv/bl/data/dao/GroupDao.java
    565 565 public List<GroupDto> getUserGroups() {
    566 566 return rawQueryGetDtoList("select * from m_group where user_group_flg = 1 ORDER BY group_name", null, GroupDto.class);
    567 567 }
    568
    568
    569 public List<GroupDto> geMyGroups() {
    • Kang Donghun @kang-dh commented Apr 08, 2021
      Developer

      geMyGroups -> getMyGroups

      Edited Apr 08, 2021
      `geMyGroups` -> `getMyGroups`
    • Lee Munkyeong @lee-mk

      changed this line in version 2 of the diff

      Apr 08, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/97/diffs?diff_id=5764&start_sha=842169d8cb0748a087111f92b7c14c66eaaa7d5f#41568e3efb70aba10829a16122bf6356ba16aeeb_569_569)
      Toggle commit list
    Please register or sign in to reply
  • Lee Munkyeong @lee-mk

    added 1 commit

    • f70a5a8b - コードレビュー対応。

    Compare with previous version

    Apr 08, 2021

    added 1 commit

    • f70a5a8b - コードレビュー対応。

    Compare with previous version

    added 1 commit * f70a5a8b - コードレビュー対応。 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/97/diffs?diff_id=5764&start_sha=842169d8cb0748a087111f92b7c14c66eaaa7d5f)
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @kang-dh

    Apr 08, 2021

    assigned to @kang-dh

    assigned to @kang-dh
    Toggle commit list
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Apr 08, 2021
    Resolved by Lee Munkyeong Apr 08, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/view/FullscreenableChromeClient.java 0 → 100644
    30
    31 if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.ICE_CREAM_SANDWICH) {
    32 if (mCustomView != null) {
    33 callback.onCustomViewHidden();
    34 return;
    35 }
    36
    37 mOriginalOrientation = mActivity.getRequestedOrientation();
    38 FrameLayout decor = (FrameLayout) mActivity.getWindow().getDecorView();
    39 mFullscreenContainer = new FullscreenHolder(mActivity);
    40 mFullscreenContainer.addView(view, COVER_SCREEN_PARAMS);
    41 decor.addView(mFullscreenContainer, COVER_SCREEN_PARAMS);
    42 mCustomView = view;
    43 setFullscreen(true);
    44 mCustomViewCallback = callback;
    45 // mActivity.setRequestedOrientation(requestedOrientation);
    • Kim Peace @kim-p commented Apr 08, 2021
      Master

      [nits] 必要のない commentは削除してください。

      Edited Apr 08, 2021
      [nits] 必要のない commentは削除してください。
    • Lee Munkyeong @lee-mk

      changed this line in version 3 of the diff

      Apr 08, 2021

      changed this line in version 3 of the diff

      changed this line in [version 3 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/97/diffs?diff_id=5779&start_sha=f70a5a8b35422b2ff394338820b42da71c918adc#dd6106ec27a5c8725b98ebfa82a23ac4869ab329_45_45)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace @kim-p

    marked the task @kim-p as completed

    Apr 08, 2021

    marked the task @kim-p as completed

    marked the task **@kim-p** as completed
    Toggle commit list
  • Kang Donghun @kang-dh

    marked the task @kang-dh as completed

    Apr 08, 2021

    marked the task @kang-dh as completed

    marked the task **@kang-dh** as completed
    Toggle commit list
  • Kang Donghun @kang-dh

    assigned to @lee-mk

    Apr 08, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Munkyeong @lee-mk

    added 1 commit

    • ffe143bb - コードレビュー対応。

    Compare with previous version

    Apr 08, 2021

    added 1 commit

    • ffe143bb - コードレビュー対応。

    Compare with previous version

    added 1 commit * ffe143bb - コードレビュー対応。 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/97/diffs?diff_id=5779&start_sha=f70a5a8b35422b2ff394338820b42da71c918adc)
    Toggle commit list
  • Lee Munkyeong @lee-mk

    resolved all discussions

    Apr 08, 2021

    resolved all discussions

    resolved all discussions
    Toggle commit list
  • Lee Munkyeong @lee-mk

    merged

    Apr 08, 2021

    merged

    merged
    Toggle commit list
  • Lee Munkyeong @lee-mk

    mentioned in commit fc58818a

    Apr 08, 2021

    mentioned in commit fc58818a

    mentioned in commit fc58818ab554eb240a365efa2e4b8f72dd5cc274
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Lee Munkyeong
Assignee
Lee Munkyeong @lee-mk
Assign to
None
Milestone
None
Assign milestone
Time tracking
4
4 participants
Reference: abook_android/abook_check!97
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.