Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !98

Merged
Opened Apr 07, 2021 by Lee Munkyeong@lee-mk 3 of 3 tasks completed3/3 tasks
  • Report abuse
Report abuse

Features/#42144 and search

  • @kim-p
  • @kang-dh
  • @lee-dh
Edited Apr 08, 2021 by Lee Daehyun
  • Discussion 5
  • Commits 5
  • Changes 7
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kang Donghun
    @kang-dh started a discussion on an old version of the diff Apr 08, 2021
    Resolved by Kang Donghun Apr 08, 2021
    ABVJE_BL/src/jp/agentec/abook/abv/bl/data/dao/GroupDao.java
    522 public List<GroupDto> getGroupByName(String[] keywords) {
    523 StringBuffer sql = new StringBuffer();
    524 sql.append(" SELECT * ");
    525 sql.append(" FROM m_group ");
    526 ArrayList<String> whereSqlList = new ArrayList<String>();
    527 for (String keyword : keywords) {
    528 if(StringUtil.isNullOrEmpty(keyword)){
    529 continue;
    530 }
    531 String whereSql = "group_name LIKE '%"+keyword+"%'";
    532 whereSqlList.add(whereSql);
    533 }
    534 if (CollectionUtil.isNotEmpty(whereSqlList)) {
    535 sql.append("WHERE " + StringUtil.join(" AND ", whereSqlList));
    536 }
    537 sql.append(" ORDER BY group_id ");
    • Kang Donghun @kang-dh commented Apr 08, 2021
      Developer

      [nits] 他の画面にはgroupNameでorderbyするsqlもありましたので、グループリストの並び替えの基準がgroupIdなのかgroupNameなのか一致する方がいいと思います。

      [nits] 他の画面にはgroupNameでorderbyするsqlもありましたので、グループリストの並び替えの基準がgroupIdなのかgroupNameなのか一致する方がいいと思います。
    • Lee Munkyeong @lee-mk

      changed this line in version 2 of the diff

      Apr 08, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/98/diffs?diff_id=5765&start_sha=b76cffafdd5758b873086889569d520a765831d5#41568e3efb70aba10829a16122bf6356ba16aeeb_537_537)
      Toggle commit list
    • Lee Munkyeong @lee-mk commented Apr 08, 2021
      Developer

      groupNameに修正しました。

      groupNameに修正しました。
    Please register or sign in to reply
  • Kang Donghun @kang-dh

    assigned to @lee-mk

    Apr 08, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Munkyeong @lee-mk

    added 1 commit

    • b616c5b3 - コードレビュー対応。

    Compare with previous version

    Apr 08, 2021

    added 1 commit

    • b616c5b3 - コードレビュー対応。

    Compare with previous version

    added 1 commit * b616c5b3 - コードレビュー対応。 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/98/diffs?diff_id=5765&start_sha=b76cffafdd5758b873086889569d520a765831d5)
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @kang-dh

    Apr 08, 2021

    assigned to @kang-dh

    assigned to @kang-dh
    Toggle commit list
  • Kim Peace @kim-p

    marked the task @kim-p as completed

    Apr 08, 2021

    marked the task @kim-p as completed

    marked the task **@kim-p** as completed
    Toggle commit list
  • Kang Donghun @kang-dh

    resolved all discussions

    Apr 08, 2021

    resolved all discussions

    resolved all discussions
    Toggle commit list
  • Kang Donghun @kang-dh

    marked the task @kang-dh as completed

    Apr 08, 2021

    marked the task @kang-dh as completed

    marked the task **@kang-dh** as completed
    Toggle commit list
  • Kang Donghun @kang-dh

    assigned to @lee-dh

    Apr 08, 2021

    assigned to @lee-dh

    assigned to @lee-dh
    Toggle commit list
  • Lee Daehyun
    @lee-dh started a discussion on the diff Apr 08, 2021
    ABVJE_BL/src/jp/agentec/abook/abv/bl/data/dao/ShopMemberDao.java
    189 192 sql.append(" m_shop_member AS sm ");
    190 193 sql.append(" INNER JOIN r_shop_member_group AS rsmg ");
    191 194 sql.append(" ON sm.shop_member_id = rsmg.shop_member_id ");
    192 sql.append(" WHERE rsmg.group_id IN (SELECT group_id FROM m_group WHERE user_group_flg = 1)");
    193 sql.append(" AND sm.self_flg != 1");
    194 sql.append(" AND sm.shop_member_name LIKE '%"+shopMemberName+"%' ");
    195 sql.append(" WHERE rsmg.group_id IN (SELECT group_id FROM m_group WHERE user_group_flg = 1) ");
    196 sql.append(" AND sm.self_flg != 1 ");
    197 ArrayList<String> whereSqlList = new ArrayList<String>();
    198 for (String keyword : keywords) {
    199 if (StringUtil.isNullOrEmpty(keyword)){
    • Lee Daehyun @lee-dh commented Apr 08, 2021
      Developer

      {スペースを空けてください

      `{`スペースを空けてください
    Please register or sign in to reply
  • Lee Daehyun
    @lee-dh started a discussion on the diff Apr 08, 2021
    ABVJE_BL/src/jp/agentec/abook/abv/bl/data/dao/ShopMemberDao.java
    211 224 sql.append(" WHERE rsmg.group_id IN (SELECT group_id FROM m_group WHERE user_group_flg = 1)");
    212 225 sql.append(" AND sm.self_flg != 1");
    213 226 sql.append(" AND sm.shop_member_id NOT IN (SELECT shop_member_id FROM r_chat_room_shop_member WHERE chat_room_id = ?)");
    214 sql.append(" AND sm.shop_member_name LIKE '%"+shopMemberName+"%' ");
    227 ArrayList<String> whereSqlList = new ArrayList<String>();
    228 for (String keyword : keywords) {
    229 if (StringUtil.isNullOrEmpty(keyword)){
    • Lee Daehyun @lee-dh commented Apr 08, 2021
      Developer

      {スペースを空けてください

      `{`スペースを空けてください
    Please register or sign in to reply
  • Lee Daehyun
    @lee-dh started a discussion on the diff Apr 08, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/activity/ChatWebviewActivity.java
    187 187 String fixedParam = "&platform=android&isMobile=true&chatServerUrl=" + ABVEnvironment.getInstance().websocketServerHttpUrl;
    188 188 //ページをロード
    189 189 if(roomId != 0 && roomName != null) { // by push message
    • Lee Daehyun @lee-dh commented Apr 08, 2021
      Developer

      if(スペースを空けてください

      `if(`スペースを空けてください
    Please register or sign in to reply
  • Lee Daehyun @lee-dh

    assigned to @lee-mk

    Apr 08, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Daehyun @lee-dh

    marked the task @lee-dh as completed

    Apr 08, 2021

    marked the task @lee-dh as completed

    marked the task **@lee-dh** as completed
    Toggle commit list
  • Lee Munkyeong @lee-mk

    added 1 commit

    • f45915ea - Merge branch 'features/abcomm_sp6' of…

    Compare with previous version

    Apr 08, 2021

    added 1 commit

    • f45915ea - Merge branch 'features/abcomm_sp6' of…

    Compare with previous version

    added 1 commit * f45915ea - Merge branch &#x27;features&#x2F;abcomm_sp6&#x27; of… [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/98/diffs?diff_id=5780&start_sha=b616c5b3364294232f89c95a0915576fbf33190c)
    Toggle commit list
  • Lee Munkyeong @lee-mk

    added 5 commits

    • f45915ea...fc58818a - 4 commits from branch features/abcomm_sp6
    • 30c6da84 - Merge branch 'features/abcomm_sp6' into 'features/#42144_and_search'

    Compare with previous version

    Apr 08, 2021

    added 5 commits

    • f45915ea...fc58818a - 4 commits from branch features/abcomm_sp6
    • 30c6da84 - Merge branch 'features/abcomm_sp6' into 'features/#42144_and_search'

    Compare with previous version

    added 5 commits * f45915ea...fc58818a - 4 commits from branch `features/abcomm_sp6` * 30c6da84 - Merge branch &#x27;features&#x2F;abcomm_sp6&#x27; into &#x27;features&#x2F;#42144_and_search&#x27; [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/98/diffs?diff_id=5782&start_sha=f45915ea9c17a14d55d9eb54ef38f7517416871a)
    Toggle commit list
  • Lee Munkyeong @lee-mk

    merged

    Apr 08, 2021

    merged

    merged
    Toggle commit list
  • Lee Munkyeong @lee-mk

    mentioned in commit b80e56dd

    Apr 08, 2021

    mentioned in commit b80e56dd

    mentioned in commit b80e56dd655d32d0fde755e42493d924aeef4664
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Lee Munkyeong
Assignee
Lee Munkyeong @lee-mk
Assign to
None
Milestone
None
Assign milestone
Time tracking
4
4 participants
Reference: abook_android/abook_check!98
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.