Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !99

Merged
Opened Apr 08, 2021 by Lee Munkyeong@lee-mk 3 of 3 tasks completed3/3 tasks
  • Report abuse
Report abuse

Features/#458 create new group table for communication

Reviewer

LGTMの場合、チェックをしてください。

  • @kim-p
  • @lee-dh
  • @kang-dh
Edited Apr 09, 2021 by Lee Munkyeong
  • Discussion 1
  • Commits 4
  • Changes 8
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Lee Daehyun @lee-dh

    changed the description

    Apr 09, 2021

    changed the description

    changed the description
    Toggle commit list
  • Lee Daehyun @lee-dh

    changed the description

    Apr 09, 2021

    changed the description

    changed the description
    Toggle commit list
  • Lee Daehyun @lee-dh

    changed the description

    Apr 09, 2021

    changed the description

    changed the description
    Toggle commit list
  • Lee Daehyun @lee-dh

    changed the description

    Apr 09, 2021

    changed the description

    changed the description
    Toggle commit list
  • Lee Daehyun @lee-dh

    assigned to @lee-mk

    Apr 09, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Daehyun @lee-dh

    marked the task @lee-dh as completed

    Apr 09, 2021

    marked the task @lee-dh as completed

    marked the task **@lee-dh** as completed
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @kang-dh

    Apr 09, 2021

    assigned to @kang-dh

    assigned to @kang-dh
    Toggle commit list
  • Kang Donghun @kang-dh

    assigned to @lee-mk

    Apr 09, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Kang Donghun @kang-dh

    marked the task @kang-dh as completed

    Apr 09, 2021

    marked the task @kang-dh as completed

    marked the task **@kang-dh** as completed
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @kim-p

    Apr 09, 2021

    assigned to @kim-p

    assigned to @kim-p
    Toggle commit list
  • Kim Peace
    @kim-p started a discussion on an old version of the diff Apr 09, 2021
    Last updated by Lee Munkyeong Apr 09, 2021
    ABVJE_BL/src/jp/agentec/abook/abv/bl/data/dao/ChatGroupDao.java 0 → 100644
    146
    147 public ChatGroupDto getGroup(int groupId) {
    148 return rawQueryGetDto("select * from m_chat_group where group_id = " + groupId, null, ChatGroupDto.class);
    149 }
    150
    151 public List<ChatGroupDto> getFavoriteGroup() {
    152 return rawQueryGetDtoList("select * from m_chat_group where favorite_register_date IS NOT NULL ORDER BY favorite_register_date ", null, ChatGroupDto.class);
    153 }
    154
    155 public List<ChatGroupDto> getGroupByName(String[] keywords) {
    156 StringBuffer sql = new StringBuffer();
    157 sql.append(" SELECT * ");
    158 sql.append(" FROM m_chat_group ");
    159 ArrayList<String> whereSqlList = new ArrayList<String>();
    160 for (String keyword : keywords) {
    161 if(StringUtil.isNullOrEmpty(keyword)){
    • Kim Peace @kim-p commented Apr 09, 2021
      Master

      [nits](は後ろにスペーシをつけてください。

      [nits]`(`は後ろにスペーシをつけてください。
    • Lee Munkyeong @lee-mk

      changed this line in version 2 of the diff

      Apr 09, 2021

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/99/diffs?diff_id=5809&start_sha=795a5353c2f23dafe1015d0da2cd75dddd28185c#0637d5e5645829927b59309ed1c642c1f2095e8e_161_161)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace @kim-p

    assigned to @lee-mk

    Apr 09, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Munkyeong @lee-mk

    added 1 commit

    • 4e243b6a - コードレビュー対応。

    Compare with previous version

    Apr 09, 2021

    added 1 commit

    • 4e243b6a - コードレビュー対応。

    Compare with previous version

    added 1 commit * 4e243b6a - コードレビュー対応。 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/99/diffs?diff_id=5809&start_sha=795a5353c2f23dafe1015d0da2cd75dddd28185c)
    Toggle commit list
  • Lee Munkyeong @lee-mk

    marked the task @kim-p as completed

    Apr 09, 2021

    marked the task @kim-p as completed

    marked the task **@kim-p** as completed
    Toggle commit list
  • Lee Munkyeong @lee-mk

    merged

    Apr 09, 2021

    merged

    merged
    Toggle commit list
  • Lee Munkyeong @lee-mk

    mentioned in commit 8a0562fb

    Apr 09, 2021

    mentioned in commit 8a0562fb

    mentioned in commit 8a0562fb1b6db989f8cac07a76bae39d6bc24da5
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Lee Munkyeong
Assignee
Lee Munkyeong @lee-mk
Assign to
None
Milestone
None
Assign milestone
Time tracking
4
4 participants
Reference: abook_android/abook_check!99
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.