Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
C
check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_web
  • check
  • Merge Requests
  • !5

Merged
Opened Oct 18, 2022 by Kang Donghun@kang-dh 
  • Report abuse
Report abuse

WIP: Feature/1.0 check web dev kangdh

  • Discussion 13
  • Commits 46
  • Changes 551
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Takumi Imai
    @imai-t started a discussion on commit 88d0aff8 Oct 11, 2022
    • Takumi Imai @imai-t

      mentioned in commit 0a93e7e8

      Oct 11, 2022

      mentioned in commit 0a93e7e8

      mentioned in commit 0a93e7e894171857cea8247db9f2986c57ff4ee0
      Toggle commit list
    Please register or sign in to reply
  • Kang Donghun @kang-dh

    assigned to @imai-t

    Oct 18, 2022

    assigned to @imai-t

    assigned to @imai-t
    Toggle commit list
  • Takumi Imai
    @imai-t started a discussion on the diff Oct 18, 2022
    Last updated by Kang Donghun Oct 18, 2022
    abvw/common/js/constant.js 0 → 100644
    57 LIST_REPORT_FORM: 'ListReportForm/showReport',
    58 },
    59 },
    60 WEB: {
    61 BASE: 'abvw/html/',
    62 },
    63 };
    64
    65 CONSTANT.LANG = {
    66 SAVE_NAME: 'lang',
    67 JAPAN: 'ja',
    68 KOREA: 'ko',
    69 ENGLISH: 'en',
    70 };
    71
    72 CONSTANT.KEYS = {
    • Takumi Imai @imai-t commented Oct 18, 2022
      Developer

      コメントは英語でお願いします

      コメントは英語でお願いします
    • Takumi Imai @imai-t commented Oct 18, 2022
      Developer

      CONSTANT.KEYSで必要のないものは削除をお願いします

      CONSTANT.KEYSで必要のないものは削除をお願いします
    • Kang Donghun @kang-dh commented Oct 18, 2022
      Developer

      他のJSで使っているもののみ残しましたのでコメントの対応だけ対応します。

      他のJSで使っているもののみ残しましたのでコメントの対応だけ対応します。
    Please register or sign in to reply
  • Takumi Imai
    @imai-t started a discussion on an old version of the diff Oct 18, 2022
    Last updated by Kang Donghun Oct 18, 2022
    abvw/js/settings.js → abvw/js/setting/settings.js
    784 784 if (!ValidationUtil.IsAlphabetOrNumberOrSymbol(SETTINGS.getNewPasswordRe())) {
    785 785 isOK = false;
    786 786 }
    787 // 連続3文字以上チェック
    • Takumi Imai @imai-t commented Oct 18, 2022
      Developer

      英語でお願いします

      英語でお願いします
    • Kang Donghun @kang-dh

      changed this line in version 2 of the diff

      Oct 18, 2022

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_web/check/merge_requests/5/diffs?diff_id=9676&start_sha=03e723b5b37058b5118553f94812d7cddc8a8127#3491c5137fe1c8ced71aee58040d2cdcc7d550fc_787_787)
      Toggle commit list
    Please register or sign in to reply
  • Takumi Imai
    @imai-t started a discussion on an old version of the diff Oct 18, 2022
    Last updated by Kang Donghun Oct 18, 2022
    abvw/js/login.js → abvw/js/login/login.js
    44 40 I18N.changeLanguage(lang);
    45 41
    46 42 // Set flag コンテンツデータチェックフラグ = true to sync local with server
    • Takumi Imai @imai-t commented Oct 18, 2022
      Developer

      全体的に英語でお願いします

      全体的に英語でお願いします
    • Kang Donghun @kang-dh

      changed this line in version 2 of the diff

      Oct 18, 2022

      changed this line in version 2 of the diff

      changed this line in [version 2 of the diff](https://gitlab.agentec.jp/abook_web/check/merge_requests/5/diffs?diff_id=9676&start_sha=03e723b5b37058b5118553f94812d7cddc8a8127#596f6f9024ef05e8cf76c2754af6291a9a5f26cc_42_42)
      Toggle commit list
    Please register or sign in to reply
  • Takumi Imai
    @imai-t started a discussion on an old version of the diff Oct 18, 2022
    abvw/js/login.js → abvw/js/login/login.js
    8 8
    • Takumi Imai @imai-t commented Oct 18, 2022
      Developer

      ファイルの説明コメントを書いてください

      ファイルの説明コメントを書いてください
    Please register or sign in to reply
  • Takumi Imai
    @imai-t started a discussion on an old version of the diff Oct 18, 2022
    abvw/js/login.js → abvw/js/login/login.js
    81 76 LOGIN.checkValidation = function() {
    82 77
    83 78 // 暗号化モードならチェック無し
    84 if (ClientData.serviceOpt_encryption() == 'Y') {
    85 return true;
    86 }
    79 // if (ClientData.serviceOpt_encryption() == 'Y') {
    • Takumi Imai @imai-t commented Oct 18, 2022
      Developer

      web版独自のコードになるためコメントアウトしているものは削除してい良いです

      web版独自のコードになるためコメントアウトしているものは削除してい良いです
    Please register or sign in to reply
  • Takumi Imai
    @imai-t started a discussion on an old version of the diff Oct 18, 2022
    abvw/js/login.js → abvw/js/login/login.js
    81 76 LOGIN.checkValidation = function() {
    82 77
    83 78 // 暗号化モードならチェック無し
    84 if (ClientData.serviceOpt_encryption() == 'Y') {
    85 return true;
    86 }
    79 // if (ClientData.serviceOpt_encryption() == 'Y') {
    80 // return true;
    81 // }
    87 82
    88 83 var accountPath = $('#txtAccPath').val();
    • Takumi Imai @imai-t commented Oct 18, 2022
      Developer

      constで良いと思います

      constで良いと思います
    Please register or sign in to reply
  • Takumi Imai
    @imai-t started a discussion on an old version of the diff Oct 18, 2022
    abvw/js/login.js → abvw/js/login/login.js
    81 76 LOGIN.checkValidation = function() {
    82 77
    83 78 // 暗号化モードならチェック無し
    84 if (ClientData.serviceOpt_encryption() == 'Y') {
    85 return true;
    86 }
    79 // if (ClientData.serviceOpt_encryption() == 'Y') {
    80 // return true;
    81 // }
    87 82
    88 83 var accountPath = $('#txtAccPath').val();
    • Takumi Imai @imai-t commented Oct 18, 2022
      Developer

      constで良いと思います

      constで良いと思います
    Please register or sign in to reply
  • Takumi Imai
    @imai-t started a discussion on an old version of the diff Oct 18, 2022
    abvw/js/login.js → abvw/js/login/login.js
    458 400 ClientData.userInfo_sid(ClientData.userInfo_sid_local());
    459 401
    460 402 if (ClientData.serviceOpt_abook_check() == 'Y') {
    • Takumi Imai @imai-t commented Oct 18, 2022
      Developer

      定数を使ってください

      定数を使ってください
    Please register or sign in to reply
  • Takumi Imai
    @imai-t started a discussion on an old version of the diff Oct 18, 2022
    abvw/js/login.js → abvw/js/login/login.js
    421 I18N.changeLanguage(COMMON.Consts.ConstLanguage_Ko);
    363 I18N.changeLanguage(CONSTANT.LANG.KOREA);
    422 364 document.title = I18N.i18nText('dspLogin') + ' | ' + I18N.i18nText('sysAppTitle');
    423 365 // ClientData.userInfo_language(COMMON.Consts.ConstLanguage_Ko);
    424 366 if (LOGIN.login_errorMessage != "") {
    425 $('#main-error-message').html(AVWEB.format(I18N.i18nText('msgLoginErrWrong'), LOGIN.login_errorMessage).toString());
    367 $('#main-error-message').html(COMMON.format(I18N.i18nText('msgLoginErrWrong'), LOGIN.login_errorMessage).toString());
    426 368 }
    427 369 };
    428 370
    429 371 // Change Language English
    430 372 LOGIN.changeLanguageEn = function() {
    431 I18N.changeLanguage(COMMON.Consts.ConstLanguage_En);
    373 I18N.changeLanguage(CONSTANT.LANG.ENGLISH);
    432 374 document.title = I18N.i18nText('dspLogin') + ' | ' + I18N.i18nText('sysAppTitle');
    433 375 // ClientData.userInfo_language(COMMON.Consts.ConstLanguage_En);
    • Takumi Imai @imai-t commented Oct 18, 2022
      Developer

      コメントアウトしたものは消して良いです

      コメントアウトしたものは消して良いです
    Please register or sign in to reply
  • Takumi Imai
    @imai-t started a discussion on an old version of the diff Oct 18, 2022
    abvw/js/login.js → abvw/js/login/login.js
    411 I18N.changeLanguage(COMMON.Consts.ConstLanguage_Ja);
    353 I18N.changeLanguage(CONSTANT.LANG.JAPAN);
    412 354 document.title = I18N.i18nText('dspLogin') + ' | ' + I18N.i18nText('sysAppTitle');
    413 355 // ClientData.userInfo_language(COMMON.Consts.ConstLanguage_Ja);
    414 356 if (LOGIN.login_errorMessage != "") {
    415 $('#main-error-message').html(AVWEB.format(I18N.i18nText('msgLoginErrWrong'), LOGIN.login_errorMessage).toString());
    357 $('#main-error-message').html(COMMON.format(I18N.i18nText('msgLoginErrWrong'), LOGIN.login_errorMessage).toString());
    416 358 }
    417 359 };
    418 360
    419 361 // Change Language Korean
    420 362 LOGIN.changeLanguageKo = function() {
    421 I18N.changeLanguage(COMMON.Consts.ConstLanguage_Ko);
    363 I18N.changeLanguage(CONSTANT.LANG.KOREA);
    422 364 document.title = I18N.i18nText('dspLogin') + ' | ' + I18N.i18nText('sysAppTitle');
    423 365 // ClientData.userInfo_language(COMMON.Consts.ConstLanguage_Ko);
    • Takumi Imai @imai-t commented Oct 18, 2022
      Developer

      コメントアウトしたものは消して良いです

      コメントアウトしたものは消して良いです
    Please register or sign in to reply
  • Takumi Imai
    @imai-t started a discussion on an old version of the diff Oct 18, 2022
    abvw/js/login.js → abvw/js/login/login.js
    386 326 ClientData.userInfo_sid(ClientData.userInfo_sid_local());
    387 327
    388 328 if (ClientData.serviceOpt_abook_check() == 'Y') {
    • Takumi Imai @imai-t commented Oct 18, 2022
      Developer

      定数使いましょう

      定数使いましょう
    Please register or sign in to reply
  • Kang Donghun @kang-dh

    added 1 commit

    • 3279537d - フィードバック対応

    Compare with previous version

    Oct 18, 2022

    added 1 commit

    • 3279537d - フィードバック対応

    Compare with previous version

    added 1 commit * 3279537d - フィードバック対応 [Compare with previous version](https://gitlab.agentec.jp/abook_web/check/merge_requests/5/diffs?diff_id=9677&start_sha=03e723b5b37058b5118553f94812d7cddc8a8127)
    Toggle commit list
  • Kang Donghun @kang-dh

    added 4 commits

    • 89f4ee7f - #49766 ファイル構成
    • 6ff2a335 - #49471 検索結果の保持
    • 24ef7ad7 - #49767 パス変更
    • 17d151f1 - Merge branch 'feature/1.0_check_web_dev' into feature/1.0_check_web_dev_kangdh

    Compare with previous version

    Oct 18, 2022

    added 4 commits

    • 89f4ee7f - #49766 ファイル構成
    • 6ff2a335 - #49471 検索結果の保持
    • 24ef7ad7 - #49767 パス変更
    • 17d151f1 - Merge branch 'feature/1.0_check_web_dev' into feature/1.0_check_web_dev_kangdh

    Compare with previous version

    added 4 commits * 89f4ee7f - #49766 ファイル構成 * 6ff2a335 - #49471 検索結果の保持 * 24ef7ad7 - #49767 パス変更 * 17d151f1 - Merge branch 'feature/1.0_check_web_dev' into feature/1.0_check_web_dev_kangdh [Compare with previous version](https://gitlab.agentec.jp/abook_web/check/merge_requests/5/diffs?diff_id=9678&start_sha=3279537d5b4f275a177ab9e980493f306c206d8f)
    Toggle commit list
  • Takumi Imai @imai-t

    merged

    Oct 19, 2022

    merged

    merged
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Takumi Imai
Assignee
Takumi Imai @imai-t
Assign to
None
Milestone
None
Assign milestone
Time tracking
2
2 participants
Reference: abook_web/check!5