Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
abook_check
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • abook_android
  • abook_check
  • Merge Requests
  • !146

Merged
Opened May 14, 2021 by Lee Munkyeong@lee-mk 0 of 1 task completed0/1 task
  • Report abuse
Report abuse

Features/abcomm sp6 document collaboration

  • @kim-p
Edited May 14, 2021 by Lee Munkyeong
  • Discussion 9
  • Commits 5
  • Changes 8
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Lee Munkyeong @lee-mk

    added 12 commits

    • fc73015e...e9ad4810 - 11 commits from branch communication/develop
    • 65e462e8 - Merge branch 'communication/develop' of…

    Compare with previous version

    May 14, 2021

    added 12 commits

    • fc73015e...e9ad4810 - 11 commits from branch communication/develop
    • 65e462e8 - Merge branch 'communication/develop' of…

    Compare with previous version

    added 12 commits * fc73015e...e9ad4810 - 11 commits from branch `communication/develop` * 65e462e8 - Merge branch 'communication/develop' of… [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/146/diffs?diff_id=6208&start_sha=fc73015edae37d98a81c63f1ea95361766e3ff16)
    Toggle commit list
  • Lee Munkyeong @lee-mk

    changed the description

    May 14, 2021

    changed the description

    changed the description
    Toggle commit list
  • Lee Munkyeong @lee-mk

    assigned to @kim-p

    May 14, 2021

    assigned to @kim-p

    assigned to @kim-p
    Toggle commit list
  • Kim Peace
    @kim-p started a discussion on an old version of the diff May 14, 2021
    Last updated by Lee Munkyeong May 16, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/viewer/activity/CommunicationWebViewActivity.java 0 → 100644
    81 protected void onDestroy() {
    82 Logger.d(TAG, "onDestroy");
    83 super.onDestroy();
    84 }
    85
    86
    87 protected Uri attachmentImageProcessing(Uri uri) throws Exception {
    88 if (uri == null) {
    89 return null;
    90 }
    91 String[] operationion = {MediaStore.MediaColumns.DATA};
    92 Cursor cursor = getContentResolver().query(uri, operationion, null, null, null);
    93 String photoFilePath = ABookCheckWebViewHelper.getInstance().contentSchemeUriToFilePath(cursor);
    94 try {
    95 int rotationAngle = ABookCheckWebViewHelper.getInstance().rotateBitmapOrientation(photoFilePath);
    96 mLocalFile = new File(photoFilePath);
    • Kim Peace @kim-p commented May 14, 2021
      Master

      indent?

      indent?
    • Lee Munkyeong @lee-mk

      changed this line in version 3 of the diff

      May 16, 2021

      changed this line in version 3 of the diff

      changed this line in [version 3 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/146/diffs?diff_id=6226&start_sha=65e462e81ede7f2f42600d0b63ea14f7b19506a5#46f6ce1a5bb3cd25d6d509a7a0da387ef69a6b1d_96_96)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff May 14, 2021
    Last updated by Lee Munkyeong May 16, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/activity/ChatWebviewActivity.java
    321 325 boolean result = false;
    322 326 // 画像が選択された場合
    323 327 if (fileChooserParams.getAcceptTypes()[0].toLowerCase().indexOf(ABookKeys.IMAGE) != -1) {
    324 result = startCameraIntent(ABOOK_CHECK_TASK_IMAGE, "Camera", ABookKeys.IMAGE, true);
    328 result = startCameraIntent(103, "Camera", ABookKeys.IMAGE, true);
    • Kim Peace @kim-p commented May 14, 2021
      Master

      [nits] 103 to CommunicationWebViewActivity.ABOOK_CHECK_TASK_IMAGE

      104 to CommunicationWebViewActivity.BOOK_CHECK_TASK_VIDEO

      [nits] 103 to `CommunicationWebViewActivity.ABOOK_CHECK_TASK_IMAGE` 104 to `CommunicationWebViewActivity.BOOK_CHECK_TASK_VIDEO`
    • Lee Munkyeong @lee-mk

      changed this line in version 3 of the diff

      May 16, 2021

      changed this line in version 3 of the diff

      changed this line in [version 3 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/146/diffs?diff_id=6226&start_sha=65e462e81ede7f2f42600d0b63ea14f7b19506a5#13bb3577d9f8893bdbdac5e5e2d0bdfd8d98dc92_328_0)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff May 14, 2021
    Last updated by Lee Munkyeong May 16, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/activity/ChatWebviewActivity.java
    1738 }
    1739 }
    1740
    1741 @Override
    1742 public boolean onKeyUp(int keyCode, KeyEvent event) {
    1743 boolean eventPrevent = false;
    1744 switch (keyCode) {
    1745 case KeyEvent.KEYCODE_BACK:
    1746 backToHome();
    1747 eventPrevent = true;
    1748 }
    1749 return eventPrevent;
    1750 }
    1751
    1752 @Override
    1753 public void onResume() {
    • Kim Peace @kim-p commented May 14, 2021
      Master

      [nits] 必要のない @overideは削除してください。

      [nits] 必要のない @overideは削除してください。
    • Lee Munkyeong @lee-mk

      changed this line in version 3 of the diff

      May 16, 2021

      changed this line in version 3 of the diff

      changed this line in [version 3 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/146/diffs?diff_id=6226&start_sha=65e462e81ede7f2f42600d0b63ea14f7b19506a5#13bb3577d9f8893bdbdac5e5e2d0bdfd8d98dc92_1753_0)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff May 14, 2021
    Last updated by Lee Munkyeong May 16, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/activity/ChatWebviewActivity.java
    1732 public void onDestroy(){
    1733 exitMettingRoom();
    1734 super.onDestroy();
    1735 if (receiver != null) {
    1736 unregisterReceiver(receiver);
    1737 receiver = null;
    1738 }
    1739 }
    1740
    1741 @Override
    1742 public boolean onKeyUp(int keyCode, KeyEvent event) {
    1743 boolean eventPrevent = false;
    1744 switch (keyCode) {
    1745 case KeyEvent.KEYCODE_BACK:
    1746 backToHome();
    1747 eventPrevent = true;
    • Kim Peace @kim-p commented May 14, 2021
      Master

      [nits] case文には break; をつけてください。

      [nits] case文には break; をつけてください。
    • Lee Munkyeong @lee-mk

      changed this line in version 3 of the diff

      May 16, 2021

      changed this line in version 3 of the diff

      changed this line in [version 3 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/146/diffs?diff_id=6226&start_sha=65e462e81ede7f2f42600d0b63ea14f7b19506a5#13bb3577d9f8893bdbdac5e5e2d0bdfd8d98dc92_1747_0)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff May 14, 2021
    Last updated by Lee Munkyeong May 16, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/activity/ChatWebviewActivity.java
    1483 1453 finish();
    1484 1454 Intent intent = new Intent();
    1485 1455 intent.setClass(ChatWebviewActivity.this, OperationListActivity.class);
    1486 intent.setFlags(Intent.FLAG_ACTIVITY_SINGLE_TOP);
    1456 intent.setFlags(Intent.FLAG_ACTIVITY_SINGLE_TOP | Intent.FLAG_ACTIVITY_CLEAR_TASK);
    1487 1457 startActivity(intent, NaviConsts.Left);
    1488 1458 }
    1489 1459
    1460 private void finishBeforeContentListActiviry() {
    1461 OperationRelatedContentActivity beforeActiryty = activityHandlingHelper.getActivity(OperationRelatedContentActivity.class);
    1462 if (beforeActiryty != null) {
    1463 beforeActiryty.finish();
    1464 }
    1465 }
    1466
    1467 public void exitMettingRoom() {
    • Kim Peace @kim-p commented May 14, 2021
      Master

      [nits] exitMettingRoom -> exitMeetingRoom

      [nits] `exitMettingRoom` -> `exitMeetingRoom`
    • Lee Munkyeong @lee-mk

      changed this line in version 3 of the diff

      May 16, 2021

      changed this line in version 3 of the diff

      changed this line in [version 3 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/146/diffs?diff_id=6226&start_sha=65e462e81ede7f2f42600d0b63ea14f7b19506a5#13bb3577d9f8893bdbdac5e5e2d0bdfd8d98dc92_1467_0)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff May 14, 2021
    Last updated by Lee Munkyeong May 16, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/activity/ChatWebviewActivity.java
    1480 1449 */
    1481 1450 private void backToHome() {
    1482 1451 mChatWebView.loadUrl("javascript:CHAT.leaveRoom()");
    1452 exitMettingRoom();
    1483 1453 finish();
    1484 1454 Intent intent = new Intent();
    1485 1455 intent.setClass(ChatWebviewActivity.this, OperationListActivity.class);
    1486 intent.setFlags(Intent.FLAG_ACTIVITY_SINGLE_TOP);
    1456 intent.setFlags(Intent.FLAG_ACTIVITY_SINGLE_TOP | Intent.FLAG_ACTIVITY_CLEAR_TASK);
    1487 1457 startActivity(intent, NaviConsts.Left);
    1488 1458 }
    1489 1459
    1460 private void finishBeforeContentListActiviry() {
    • Kim Peace @kim-p commented May 14, 2021
      Master

      finishBeforeContentListActiviry -> finishBeforeContentListActivity

      `finishBeforeContentListActiviry` -> `finishBeforeContentListActivity`
    • Lee Munkyeong @lee-mk

      changed this line in version 3 of the diff

      May 16, 2021

      changed this line in version 3 of the diff

      changed this line in [version 3 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/146/diffs?diff_id=6226&start_sha=65e462e81ede7f2f42600d0b63ea14f7b19506a5#13bb3577d9f8893bdbdac5e5e2d0bdfd8d98dc92_1460_0)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff May 14, 2021
    Last updated by Lee Munkyeong May 16, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/activity/ChatWebviewActivity.java
    111 113 * Created by AIS-NB-048 on 2019/07/31.
    112 114 */
    113 115
    114 public class ChatWebviewActivity extends ParentWebViewActivity {
    116 public class ChatWebviewActivity extends CommunicationWebViewActivity {
    • Kim Peace @kim-p commented May 14, 2021
      Master

      [nits] ChatWebviewActivity -> ChatWebViewActivity

      [nits] `ChatWebviewActivity` -> `ChatWebViewActivity`
    • Lee Munkyeong @lee-mk

      changed this line in version 3 of the diff

      May 16, 2021

      changed this line in version 3 of the diff

      changed this line in [version 3 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/146/diffs?diff_id=6226&start_sha=65e462e81ede7f2f42600d0b63ea14f7b19506a5#13bb3577d9f8893bdbdac5e5e2d0bdfd8d98dc92_116_0)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff May 14, 2021
    Last updated by Lee Munkyeong May 16, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/home/helper/ActivityHandlingHelper.java
    246 246 // ページの場合、0から始まるのでシーン設定は+1する
    247 247 path += "&startscene=scene" + (intent.getIntExtra(ABVActivity.PAGE, 1) + 1);
    248 248 }
    249 // 管理者モードで開く場合、パラメータ追加
    249 // 管理者モードで開く場合、パラメータ追加cr
    • Kim Peace @kim-p commented May 14, 2021
      Master

      cr?

      `cr`?
    • Lee Munkyeong @lee-mk

      changed this line in version 3 of the diff

      May 16, 2021

      changed this line in version 3 of the diff

      changed this line in [version 3 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/146/diffs?diff_id=6226&start_sha=65e462e81ede7f2f42600d0b63ea14f7b19506a5#9f691da92e673d9c91da4da742f20d398837c0be_249_249)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace
    @kim-p started a discussion on an old version of the diff May 14, 2021
    Last updated by Lee Munkyeong May 16, 2021
    ABVJE_UI_Android/src/jp/agentec/abook/abv/ui/viewer/activity/CommunicationWebViewActivity.java 0 → 100644
    45 import jp.agentec.abook.abv.ui.common.constant.ErrorCode;
    46 import jp.agentec.abook.abv.ui.common.constant.ErrorMessage;
    47 import jp.agentec.abook.abv.ui.common.dialog.ABookAlertDialog;
    48 import jp.agentec.abook.abv.ui.common.util.AlertDialogUtil;
    49 import jp.agentec.abook.abv.ui.common.util.PatternStringUtil;
    50 import jp.agentec.abook.abv.ui.home.activity.ABookSettingActivity;
    51 import jp.agentec.abook.abv.ui.home.helper.ABookCheckWebViewHelper;
    52 import jp.agentec.abook.abv.ui.home.helper.ABookPermissionHelper;
    53 import jp.agentec.abook.abv.ui.home.helper.ActivityHandlingHelper;
    54 import jp.agentec.abook.abv.ui.home.helper.ContentViewHelper;
    55 import jp.agentec.adf.util.DateTimeFormat;
    56 import jp.agentec.adf.util.DateTimeUtil;
    57 import jp.agentec.adf.util.FileUtil;
    58
    59 public class CommunicationWebViewActivity extends ABVAuthenticatedActivity {
    60 private static final String TAG = "ParentWebViewActivity";
    • Kim Peace @kim-p commented May 14, 2021
      Master

      [must]ParentWebViewActivity -> CommunicationWebViewActivity

      [must]`ParentWebViewActivity` -> `CommunicationWebViewActivity`
    • Lee Munkyeong @lee-mk

      changed this line in version 3 of the diff

      May 16, 2021

      changed this line in version 3 of the diff

      changed this line in [version 3 of the diff](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/146/diffs?diff_id=6226&start_sha=65e462e81ede7f2f42600d0b63ea14f7b19506a5#46f6ce1a5bb3cd25d6d509a7a0da387ef69a6b1d_60_60)
      Toggle commit list
    Please register or sign in to reply
  • Kim Peace @kim-p

    assigned to @lee-mk

    May 14, 2021

    assigned to @lee-mk

    assigned to @lee-mk
    Toggle commit list
  • Lee Munkyeong @lee-mk

    added 1 commit

    • 2fc75b31 - コードレビュー対応。

    Compare with previous version

    May 16, 2021

    added 1 commit

    • 2fc75b31 - コードレビュー対応。

    Compare with previous version

    added 1 commit * 2fc75b31 - コードレビュー対応。 [Compare with previous version](https://gitlab.agentec.jp/abook_android/abook_check/merge_requests/146/diffs?diff_id=6226&start_sha=65e462e81ede7f2f42600d0b63ea14f7b19506a5)
    Toggle commit list
  • Lee Munkyeong @lee-mk

    merged

    May 16, 2021

    merged

    merged
    Toggle commit list
  • Lee Munkyeong @lee-mk

    mentioned in commit 17680174

    May 16, 2021

    mentioned in commit 17680174

    mentioned in commit 176801742e453473734c781f59f0206d67c6bf5d
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Lee Munkyeong
Assignee
Lee Munkyeong @lee-mk
Assign to
None
Milestone
None
Assign milestone
Time tracking
2
2 participants
Reference: abook_android/abook_check!146
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.